Some cleanup

Author: Col-E

src/main/java/software/coley/llzip/ZipIO.java

@@ -1,10 +1,12 @@
 package software.coley.llzip;
 
+import software.coley.llzip.format.model.CentralDirectoryFileHeader;
+import software.coley.llzip.format.model.EndOfCentralDirectory;
+import software.coley.llzip.format.model.ZipArchive;
 import software.coley.llzip.format.read.ForwardScanZipReaderStrategy;
 import software.coley.llzip.format.read.JvmZipReaderStrategy;
 import software.coley.llzip.format.read.NaiveLocalFileZipReaderStrategy;
 import software.coley.llzip.format.read.ZipReaderStrategy;
-import software.coley.llzip.format.model.ZipArchive;
 import software.coley.llzip.util.BufferData;
 import software.coley.llzip.util.ByteData;
 import software.coley.llzip.util.FileMapUtil;
@@ -16,6 +18,11 @@
 
 /**
  * IO wrappers for reading {@link ZipArchive} contents.
+ * <ul>
+ *     <li>For JAR files or anything intended to be read by the JVM use the JVM operations which use {@link JvmZipReaderStrategy}.</li>
+ *     <li>For regular ZIP files use {@link ForwardScanZipReaderStrategy}.</li>
+ *     <li>For ZIP files without {@link CentralDirectoryFileHeader} or {@link EndOfCentralDirectory} items, use {@link NaiveLocalFileZipReaderStrategy}</li>
+ * </ul>
  *
  * @author Matt Coley
  */

src/main/java/software/coley/llzip/format/compression/DeflateDecompressor.java

@@ -17,7 +17,7 @@
  */
 public class DeflateDecompressor implements Decompressor {
 	@Override
-	public ByteData decompress(LocalFileHeader header, ByteData bytes) throws IOException {
+	public ByteData decompress(LocalFileHeader header, ByteData data) throws IOException {
 		if (header.getCompressionMethod() != ZipCompressions.DEFLATED)
 			throw new IOException("LocalFileHeader contents not using 'Deflated'!");
 		Inflater inflater = new Inflater(true);
@@ -26,14 +26,14 @@ public ByteData decompress(LocalFileHeader header, ByteData bytes) throws IOExce
 			byte[] output = new byte[1024];
 			byte[] buffer = new byte[1024];
 			long position = 0L;
-			long length = bytes.length();
+			long length = data.length();
 			do {
 				if (inflater.needsInput()) {
 					int remaining = (int) Math.min(buffer.length, length);
 					if (remaining == 0) {
 						break;
 					}
-					bytes.get(position, buffer, 0, remaining);
+					data.get(position, buffer, 0, remaining);
 					length -= remaining;
 					position += remaining;
 					inflater.setInput(buffer, 0, remaining);

src/main/java/software/coley/llzip/format/model/AbstractZipFileHeader.java

@@ -224,6 +224,8 @@ public ByteData getFileName() {
 	 * 		File name.
 	 */
 	public void setFileName(ByteData fileName) {
+		if (this.fileName != fileName)
+			fileNameCache = null;
 		this.fileName.set(fileName);
 	}