fix: Truncate file names in display with incredibly verbose directory paths

Prevents a stack-overflow with directory structures that are veeery long

Author: Col-E

src/main/java/me/coley/recaf/config/ConfDisplay.java

@@ -77,6 +77,11 @@ public class ConfDisplay extends Config {
 	 */
 	@Conf("display.usesystemmenubar")
 	public boolean useSystemMenubar;
+	/**
+	 * Maximum depth of a directory structure to display before it gets truncated.
+	 */
+	@Conf("display.maxtreedepth")
+	public int maxTreeDepth = 30;
 
 	ConfDisplay() {
 		super("display");

src/main/java/me/coley/recaf/ui/controls/pane/ConfigPane.java

@@ -54,6 +54,7 @@ public ConfigPane(GuiController controller, ConfDisplay config) {
 		editorOverrides.put("display.forceWordWrap", Toggle::new);
 		editorOverrides.put("display.suggest.classerrors", Toggle::new);
 		editorOverrides.put("display.maxrecent", v -> new NumberSlider<>(controller, v, 0, 20, 2));
+		editorOverrides.put("display.maxtreedepth", v -> new NumberSlider<>(controller, v, 10, 100, 10));
 		if (OSUtil.getOSType() == OSUtil.MAC) {
 			editorOverrides.put("display.usesystemmenubar", Toggle::new);
 		} else {

src/main/java/me/coley/recaf/ui/controls/tree/ClassFolderItem.java

@@ -1,5 +1,6 @@
 package me.coley.recaf.ui.controls.tree;
 
+import me.coley.recaf.Recaf;
 import me.coley.recaf.workspace.JavaResource;
 
 import java.util.*;
@@ -25,6 +26,15 @@ public ClassFolderItem(JavaResource resource) {
 	protected void addClass(String name) {
 		DirectoryItem item = this;
 		List<String> parts = new ArrayList<>(Arrays.asList(name.split("/")));
+		// Prune tree directory middle section if it is obnoxiously long
+		int maxDepth = Recaf.getController().config().display().maxTreeDepth;
+		if (parts.size() > maxDepth) {
+			while (parts.size() > maxDepth) {
+				parts.remove(maxDepth - 1);
+			}
+			parts.add(maxDepth - 1, "...");
+		}
+		// Build directory structure
 		StringBuilder sb = new StringBuilder();
 		while(!parts.isEmpty()) {
 			String part = parts.remove(0);

src/main/java/me/coley/recaf/ui/controls/tree/FileFolderItem.java

@@ -1,5 +1,6 @@
 package me.coley.recaf.ui.controls.tree;
 
+import me.coley.recaf.Recaf;
 import me.coley.recaf.workspace.JavaResource;
 
 import java.util.*;
@@ -25,6 +26,15 @@ public FileFolderItem(JavaResource resource) {
 	protected void addFile(String name) {
 		DirectoryItem item = this;
 		List<String> parts = new ArrayList<>(Arrays.asList(name.split("/")));
+		// Prune tree directory middle section if it is obnoxiously long
+		int maxDepth = Recaf.getController().config().display().maxTreeDepth;
+		if (parts.size() > maxDepth) {
+			while (parts.size() > maxDepth) {
+				parts.remove(maxDepth - 1);
+			}
+			parts.add(maxDepth - 1, "...");
+		}
+		// Build directory structure
 		while(!parts.isEmpty()) {
 			String part = parts.remove(0);
 			boolean isLeaf = parts.isEmpty();

src/main/resources/translations/en.json

@@ -479,6 +479,8 @@
 	"display.buttonbar.desc": "Show the easy-access button-bar in the UI. Restart to apply changes.",
 	"display.maxlength.tree.name": "Max tree name length",
 	"display.maxlength.tree.desc": "The max length of names in the file tree. Useful for obfuscated assemblies with crazy names.",
+	"display.maxtreedepth.name": "Max tree directory depth",
+	"display.maxtreedepth.desc": "The max number of directories to show in the file tree before truncation.",
 	"display.treesourcename.name": "Show SourceFile names",
 	"display.treesourcename.desc": "Display classes SourceFile next to their declared names in the file-tree.",
 	"display.exitwarning.name": "Give save prompt on exit",