Merge pull request #183 from CollActionteam/feature/crowdaction-not-found-response

fredabisai · web-flow · commit 20dc8b3bb4d3 · 2023-05-14T20:33:22.000+03:00
Fix: Change Status Code to 404 when CrowdAction is not found
diff --git a/src/modules/crowdaction/errors/crowdaction.error.ts b/src/modules/crowdaction/errors/crowdaction.error.ts
@@ -27,7 +27,7 @@ export class CrowdActionMustBeInTheFutureError extends ApiError {
 
 export class CrowdActionDoesNotExist extends ApiError {
     constructor() {
-        super({ message: `Could not find any CrowdAction that fit the criteria`, statusCode: HttpStatus.BAD_REQUEST });
+        super({ message: `Could not find any CrowdAction that fit the criteria`, statusCode: HttpStatus.NOT_FOUND });
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ export class CrowdActionMustBeInTheFutureError extends ApiError {`
`27`	`27`
`28`	`28`	`export class CrowdActionDoesNotExist extends ApiError {`
`29`	`29`	`constructor() {`
`30`		- super({ message: `Could not find any CrowdAction that fit the criteria`, statusCode: HttpStatus.BAD_REQUEST });
	`30`	+ super({ message: `Could not find any CrowdAction that fit the criteria`, statusCode: HttpStatus.NOT_FOUND });
`31`	`31`	`}`
`32`	`32`	`}`
`33`	`33`