Remove default value for $action in getWopiClientURL.

Author: donquixote

src/Discovery/Discovery.php

@@ -32,7 +32,7 @@ public function __construct(
   /**
    * {@inheritdoc}
    */
-  public function getWopiClientURL(string $action = 'view', string $mimetype = 'text/plain'): ?string {
+  public function getWopiClientURL(string $action, string $mimetype = 'text/plain'): ?string {
     $result = $this->parsedXml->xpath(sprintf(
       "/wopi-discovery/net-zone/app[@name='%s']/action[@name='%s']",
       $mimetype,

src/Discovery/DiscoveryInterface.php

@@ -33,7 +33,7 @@ interface DiscoveryInterface {
    *   The WOPI client URL, or NULL if none provided for the MIME type and
    *   operation.
    */
-  public function getWopiClientURL(string $action = 'view', string $mimetype = 'text/plain'): ?string;
+  public function getWopiClientURL(string $action, string $mimetype = 'text/plain'): ?string;
 
   /**
    * Gets the public key used for proofing.

tests/src/ExistingSite/FetchClientUrlTest.php

@@ -41,7 +41,7 @@ public function testFetchClientUrl(): void {
     /** @var \Drupal\collabora_online\Discovery\DiscoveryFetcherInterface $discovery_fetcher */
     $discovery_fetcher = \Drupal::service(DiscoveryFetcherInterface::class);
     $discovery = $discovery_fetcher->getDiscovery();
-    $client_url = $discovery->getWopiClientURL();
+    $client_url = $discovery->getWopiClientURL('view');
     $this->assertNotNull($client_url);
     // The protocol, domain and port are known when this test runs in the
     // docker-compose setup.

tests/src/Kernel/DiscoveryFetcherTest.php

@@ -117,7 +117,7 @@ public function testGetDiscovery(): void {
     $discovery = $fetcher->getDiscovery();
     $this->assertSame(
       'http://collabora.test:9980/browser/61cf2b4/cool.html?',
-      $discovery->getWopiClientURL(),
+      $discovery->getWopiClientURL('view'),
     );
     $this->assertSame(
       [

tests/src/Unit/CollaboraDiscoveryTest.php

@@ -25,7 +25,7 @@ public function testWopiClientUrl(): void {
     $discovery = $this->getDiscoveryFromFile($file);
     $this->assertSame(
       'http://collabora.test:9980/browser/61cf2b4/cool.html?',
-      $discovery->getWopiClientURL(),
+      $discovery->getWopiClientURL('view'),
     );
     $this->assertSame(
       'http://spreadsheet.collabora.test:9980/browser/61cf2b4/cool.html?',