Fix #736: GameIniVersion ignores mismatched value

Author: neon-nyan

CollapseLauncher/Classes/GameManagement/Versioning/GameVersionBase.IniConfig.cs

@@ -63,7 +63,7 @@ internal partial class GameVersionBase
         protected virtual IniFile GameIniProfile     { get; } = new();
         protected virtual IniFile GameIniVersion     { get; } = new();
         public virtual IniSection GameIniVersionSection { get => GameIniVersion[DefaultIniVersionSection]; }
-        public virtual IniSection GameIniProfileSection { get => GameIniVersion[DefaultIniProfileSection]; }
+        public virtual IniSection GameIniProfileSection { get => GameIniProfile[DefaultIniProfileSection]; }
         #endregion
 
         #region Game Config Path Properties
@@ -75,7 +75,7 @@ protected virtual string GameIniVersionPath
         {
             get
             {
-                var configPath = GameIniProfile[DefaultIniProfileSection]["game_install_path"].ToString();
+                var configPath = GameIniProfileSection["game_install_path"].ToString();
                 var defaultPath = Path.Combine(GameConfigDirPath ?? "", GamePreset.GameDirectoryName ?? "Games", ConfigFileName);
 
                 if (string.IsNullOrEmpty(configPath)) return defaultPath;
@@ -173,9 +173,9 @@ protected virtual void FixInvalidGameConfigId()
 
             string gameIniVersionPath = Path.Combine(GameDirPath, ConfigFileName);
 
-            GameIniVersion[DefaultIniVersionSection][channelIdKeyName] = GamePreset.ChannelID ?? 0;
-            GameIniVersion[DefaultIniVersionSection][subChannelIdKeyName] = GamePreset.SubChannelID ?? 0;
-            GameIniVersion[DefaultIniVersionSection][cpsKeyName] = GamePreset.LauncherCPSType;
+            GameIniVersionSection[channelIdKeyName] = GamePreset.ChannelID ?? 0;
+            GameIniVersionSection[subChannelIdKeyName] = GamePreset.SubChannelID ?? 0;
+            GameIniVersionSection[cpsKeyName] = GamePreset.LauncherCPSType;
 
             SaveGameIni(gameIniVersionPath, GameIniVersion);
         }
@@ -198,7 +198,7 @@ protected virtual void FixInvalidGameBilibiliStatus(string? executableName)
         #region Update Game Config Methods
         public void UpdateGamePath(string? path, bool saveValue = true)
         {
-            GameIniProfile[DefaultIniProfileSection]["game_install_path"] = path?.Replace('\\', '/');
+            GameIniProfileSection["game_install_path"] = path?.Replace('\\', '/');
             if (saveValue)
             {
                 SaveGameIni(GameIniProfilePath, GameIniProfile);
@@ -220,7 +220,7 @@ public void UpdateGameVersionToLatest(bool saveValue = true)
 
         public void UpdateGameVersion(GameVersion? version, bool saveValue = true)
         {
-            GameIniVersion[DefaultIniVersionSection]["game_version"] = version?.VersionString;
+            GameIniVersionSection["game_version"] = version?.VersionString;
             if (saveValue)
             {
                 SaveGameIni(GameIniVersionPath, GameIniVersion);
@@ -229,9 +229,9 @@ public void UpdateGameVersion(GameVersion? version, bool saveValue = true)
 
         public void UpdateGameChannels(bool saveValue = true)
         {
-            GameIniVersion[DefaultIniVersionSection]["channel"] = DefaultGameChannelID;
-            GameIniVersion[DefaultIniVersionSection]["sub_channel"] = DefaultGameSubChannelID;
-            GameIniVersion[DefaultIniVersionSection]["cps"] = DefaultGameCps;
+            GameIniVersionSection["channel"] = DefaultGameChannelID;
+            GameIniVersionSection["sub_channel"] = DefaultGameSubChannelID;
+            GameIniVersionSection["cps"] = DefaultGameCps;
 
             if (saveValue)
             {
@@ -253,7 +253,7 @@ public void UpdatePluginVersions(Dictionary<string, GameVersion> versions, bool
                 string keyName = $"plugin_{version.Key}_version";
 
                 // Set the value
-                GameIniVersion[DefaultIniVersionSection][keyName] = version.Value.VersionString;
+                GameIniVersionSection[keyName] = version.Value.VersionString;
             }
 
             if (saveValue)
@@ -274,7 +274,7 @@ public void UpdateSdkVersion(GameVersion? version, bool saveValue = true)
 
             // Set the value
             const string keyName = "plugin_sdk_version";
-            GameIniVersion[DefaultIniVersionSection][keyName] = version.ToString();
+            GameIniVersionSection[keyName] = version.ToString();
 
             if (saveValue)
             {
@@ -339,7 +339,7 @@ public virtual void InitializeIniProp()
             InitializeIniProp(GameIniProfilePath, GameIniProfile, DefaultIniProfile,
                               DefaultIniProfileSection);
             InitializeIniProp(GameIniVersionPath, GameIniVersion, DefaultIniVersion,
-                              DefaultIniVersionSection, true);
+                              DefaultIniVersionSection);
 
             // Initialize the GameVendorType
             VendorTypeProp = new GameVendorProp(GameDirPath,
@@ -392,7 +392,7 @@ private void InitializeIniDefaults(IniFile ini, IniSection defaults, string sect
                 }
             }
 
-            UpdateGameChannels(false);
+            // UpdateGameChannels(false);
         }
 
         private void SaveGameIni(string filePath, IniFile ini)