Preview 1.82.11 Hotfix (#648)

# What's new? - 1.82.11
- **[New]** Toggle "Playing" Discord RPC status per-region, by @bagusnl 
- You can disable "Playing" status per-region now by going to Quick
Settings (bottom right on Homepage) and toggling it off.
  - This is enabled by default (as it always is)
- **[Fix]** Bloated Sophon pre-download/update size due to duplicate
entries, by @neon-nyan
- **[Imp]** Match API requests headers, by @neon-nyan 
- **[Fix]** Cannot copy error message caused by ``HGlobal`` buffer
misallocation for some users, by @neon-nyan
- **[Fix]** IOSharingViolation due to file/directory handling in some
methods, by @neon-nyan
- **[Fix]** Repair causing application crashes due to value overflow, by
@bagusnl
- **[Fix]** Game installation error due to invalid VO language
selection, by @neon-nyan
- **[Imp]** Sentry improvements, by @bagusnl 
  - Filter exceptions to be sent
    + Exceptions caused by users' internet situation are filtered
  - Add loaded modules info to breadcrumb
  - Detach inner exception handler method
- **[Imp]** Sophon Download Improvements, by @neon-nyan 
- Adding disk-space check on Game Installation/Update and Pre-load
Download.
  - Ignore if VO's LanguageString is not valid on non-debug build
  - Separate Sophon methods to its own code files
- **[Imp]** UI/UX Improvements, by @shatyuka @neon-nyan and @bagusnl 
- New fallback background when the background sprite is not yet
downloaded
> The official HoYoPlay's default background is used for the fallback
background
  - Disable some tab focus within the PostPanel
  - Resize Pivot header in PostPanel
  - Make ScrollViewer receive focus as a whole
  - Enable navigation via arrow keys in ScrollViewer
- Adjust Audio-related setting's Grid layout on Genshin Game Settings
Page
- **[Fix]** DB sync buttons on App Settings page doesn't get disabled
when the toggle is off
- **[Loc]** Localization Sync from Transifex, by Localizers <3

### Templates

<details>
  <summary>Changelog Prefixes</summary>
  
  ```
    **[New]**
    **[Imp]**
    **[Fix]**
    **[Loc]**
    **[Doc]**
  ```

</details>

Author: neon-nyan

.github/workflows/qodana-scan-pr.yml

@@ -3,6 +3,8 @@ on:
  pull_request:
    branches:
      - main
+     - preview
+     - stable
 
 jobs:
   qodana:

CollapseLauncher/App.xaml

@@ -1,4 +1,5 @@
-using CollapseLauncher.Interfaces;
+using CollapseLauncher.Helper;
+using CollapseLauncher.Interfaces;
 using Hi3Helper;
 using System;
 using System.Collections.Generic;
@@ -57,19 +58,31 @@ private async Task<List<CacheAsset>> Check(List<CacheAsset> assetIndex, Cancella
 
         private void CheckUnusedAssets(List<CacheAsset> assetIndex, List<CacheAsset> returnAsset)
         {
+            // Directory info and if the directory doesn't exist, return
+            DirectoryInfo directoryInfo = new DirectoryInfo(_gamePath);
+            if (!directoryInfo.Exists)
+            {
+                return;
+            }
+
             // Iterate the file contained in the _gamePath
-            foreach (string filePath in Directory.EnumerateFiles(_gamePath!, "*", SearchOption.AllDirectories))
+            foreach (FileInfo fileInfo in directoryInfo.EnumerateFiles("*", SearchOption.AllDirectories)
+                .EnumerateNoReadOnly())
             {
-                if (!filePath.Contains("output_log") && !filePath.Contains("Crashes")
-                 && !filePath.Contains("Verify.txt") && !filePath.Contains("APM")
-                 && !filePath.Contains("FBData") && !filePath.Contains("asb.dat")
-                 && !assetIndex!.Exists(x => x!.ConcatPath == filePath))
+                string filePath = fileInfo.FullName;
+
+                if (!filePath.Contains("output_log", StringComparison.OrdinalIgnoreCase)
+                 && !filePath.Contains("Crashes", StringComparison.OrdinalIgnoreCase)
+                 && !filePath.Contains("Verify.txt", StringComparison.OrdinalIgnoreCase)
+                 && !filePath.Contains("APM", StringComparison.OrdinalIgnoreCase)
+                 && !filePath.Contains("FBData", StringComparison.OrdinalIgnoreCase)
+                 && !filePath.Contains("asb.dat", StringComparison.OrdinalIgnoreCase)
+                 && !assetIndex.Exists(x => x.ConcatPath == fileInfo.FullName))
                 {
                     // Increment the total found count
                     _progressAllCountFound++;
 
                     // Add asset to the returnAsset
-                    FileInfo fileInfo = new FileInfo(filePath);
                     CacheAsset asset = new CacheAsset()
                     {
                         BasePath = Path.GetDirectoryName(filePath),
@@ -106,10 +119,10 @@ private async ValueTask CheckAsset(CacheAsset asset, List<CacheAsset> returnAsse
             _status.ActivityAll = string.Format(Lang._CachesPage.CachesTotalStatusChecking!, _progressAllCountCurrent, _progressAllCountTotal);
 
             // Assign the file info.
-            FileInfo fileInfo = new FileInfo(asset.ConcatPath!);
+            FileInfo fileInfo = new FileInfo(asset.ConcatPath).EnsureNoReadOnly(out bool isExist);
 
             // Check if the file exist. If not, then add it to asset index.
-            if (!fileInfo.Exists)
+            if (!isExist)
             {
                 AddGenericCheckAsset(asset, CacheAssetStatus.New, returnAsset, null, asset.CRCArray);
                 return;

CollapseLauncher/Assets/Images/GameBackground/genshin.webp

@@ -126,12 +126,12 @@ private async Task UpdateCacheAsset((CacheAsset AssetIndex, IAssetProperty Asset
 
             FileInfo fileInfo = new FileInfo(asset.AssetIndex.ConcatPath!)
                                .EnsureCreationOfDirectory()
-                               .EnsureNoReadOnly();
+                               .EnsureNoReadOnly(out bool isExist);
 
             // This is a action for Unused asset.
             if (asset.AssetIndex.DataType == CacheAssetType.Unused)
             {
-                if (fileInfo.Exists)
+                if (isExist)
                     fileInfo.Delete();
 
                 LogWriteLine($"Deleted unused file: {fileInfo.FullName}", LogType.Default, true);

CollapseLauncher/Assets/Images/GameBackground/honkai.webp

@@ -1,4 +1,5 @@
-using Hi3Helper;
+using CollapseLauncher.Helper;
+using Hi3Helper;
 using Hi3Helper.EncTool.Parser.AssetMetadata.SRMetadataAsset;
 using System;
 using System.Collections.Generic;
@@ -79,12 +80,12 @@ private async ValueTask CheckAsset(SRAsset asset, List<SRAsset> returnAsset, str
             }
 
             // Get persistent and streaming paths
-            FileInfo fileInfoPersistent = new FileInfo(Path.Combine(basePersistent!, asset.LocalName!));
-            FileInfo fileInfoStreaming = new FileInfo(Path.Combine(baseStreaming!, asset.LocalName!));
+            FileInfo fileInfoPersistent = new FileInfo(Path.Combine(basePersistent!, asset.LocalName!)).EnsureNoReadOnly(out bool isPersistentExist);
+            FileInfo fileInfoStreaming = new FileInfo(Path.Combine(baseStreaming!, asset.LocalName!)).EnsureNoReadOnly(out bool isStreamingExist);
 
-            bool UsePersistent = !fileInfoStreaming.Exists;
-            bool IsPersistentExist = fileInfoPersistent.Exists && fileInfoPersistent.Length == asset.Size;
-            bool IsStreamingExist = fileInfoStreaming.Exists && fileInfoStreaming.Length == asset.Size;
+            bool UsePersistent = !isStreamingExist;
+            bool IsPersistentExist = isPersistentExist && fileInfoPersistent.Length == asset.Size;
+            bool IsStreamingExist = isStreamingExist && fileInfoStreaming.Length == asset.Size;
             asset.LocalName = UsePersistent ? fileInfoPersistent.FullName : fileInfoStreaming.FullName;
 
             // Check if the file exist. If not, then add it to asset index.

CollapseLauncher/Assets/Images/GameBackground/starrail.webp

@@ -6,8 +6,8 @@
 #nullable enable
 namespace CollapseLauncher.Extension
 {
-    internal delegate Task<TResult?> ActionTimeoutValueTaskCallback<TResult>(CancellationToken token);
-    internal delegate void ActionOnTimeOutRetry(int retryAttemptCount, int retryAttemptTotal, int timeOutSecond, int timeOutStep);
+    public delegate Task<TResult?> ActionTimeoutValueTaskCallback<TResult>(CancellationToken token);
+    public delegate void ActionOnTimeOutRetry(int retryAttemptCount, int retryAttemptTotal, int timeOutSecond, int timeOutStep);
     internal static class TaskExtensions
     {
         internal const int DefaultTimeoutSec = 10;