Fix disposed stream on resizing image due to unexpected async pattern

Author: neon-nyan

CollapseLauncher/Classes/Helper/Image/ImageLoaderHelper.cs

@@ -350,48 +350,36 @@ internal static FileInfo GetCacheFileInfo(string filePath)
 
         public static Task ResizeImageStream(Stream input, Stream output, uint toWidth, uint toHeight)
         {
-            TaskCompletionSource tcs = new();
-            Task.Factory.StartNew(Impl);
-
-            return tcs.Task;
+            return Task.Factory.StartNew(Impl);
 
             void Impl()
             {
-                try
+                ProcessImageSettings settings = new()
                 {
-                    ProcessImageSettings settings = new()
-                    {
-                        Width         = (int)toWidth,
-                        Height        = (int)toHeight,
-                        HybridMode    = HybridScaleMode.Off,
-                        Interpolation = InterpolationSettings.CubicSmoother,
-                        Anchor        = CropAnchor.Bottom | CropAnchor.Center
-                    };
-                    settings.TrySetEncoderFormat(ImageMimeTypes.Png);
-
-                    ImageFileInfo           imageFileInfo = ImageFileInfo.Load(input!);
-                    ImageFileInfo.FrameInfo frame         = imageFileInfo.Frames[0];
-                    input.Position = 0;
-
-                    bool isUseWaifu2X = IsWaifu2XEnabled && (frame.Width < toWidth || frame.Height < toHeight);
-                    using ProcessingPipeline pipeline =
-                        MagicImageProcessor
-                           .BuildPipeline(input,
-                                          isUseWaifu2X
-                                              ? ProcessImageSettings.Default
-                                              : settings);
+                    Width         = (int)toWidth,
+                    Height        = (int)toHeight,
+                    HybridMode    = HybridScaleMode.Off,
+                    Interpolation = InterpolationSettings.CubicSmoother,
+                    Anchor        = CropAnchor.Bottom | CropAnchor.Center
+                };
+                settings.TrySetEncoderFormat(ImageMimeTypes.Png);
 
-                    if (isUseWaifu2X)
-                        pipeline.AddTransform(new Waifu2XTransform(_waifu2X));
+                ImageFileInfo           imageFileInfo = ImageFileInfo.Load(input!);
+                ImageFileInfo.FrameInfo frame         = imageFileInfo.Frames[0];
+                input.Position = 0;
 
-                    pipeline.WriteOutput(output);
+                bool isUseWaifu2X = IsWaifu2XEnabled && (frame.Width < toWidth || frame.Height < toHeight);
+                using ProcessingPipeline pipeline =
+                    MagicImageProcessor
+                       .BuildPipeline(input,
+                                      isUseWaifu2X
+                                          ? ProcessImageSettings.Default
+                                          : settings);
 
-                    tcs.SetResult();
-                }
-                catch (Exception e)
-                {
-                    tcs.SetException(e);
-                }
+                if (isUseWaifu2X)
+                    pipeline.AddTransform(new Waifu2XTransform(_waifu2X));
+
+                pipeline.WriteOutput(output);
             }
         }