Fix calling UserFeedback dialog crashes app due to nulled game property

fix #839

Put the only thing GameProperty used (game header) inside a trycatch so it can fail when GameProperty is somehow broken.

Author: bagusnl

CollapseLauncher/XAMLs/Theme/CustomControls/UserFeedbackDialog/UserFeedbackDialog.cs

@@ -5,6 +5,7 @@
 using CollapseLauncher.Statics;
 using CommunityToolkit.WinUI;
 using Hi3Helper;
+using Hi3Helper.SentryHelper;
 using Hi3Helper.Shared.Region;
 using Microsoft.UI.Input;
 using Microsoft.UI.Text;
@@ -92,15 +93,25 @@ protected override void OnApplyTemplate()
             _layoutCloseButton?.EnableImplicitAnimation();
 
             // Assign dialog title image background
-            GamePresetProperty currentGameProperty = GamePropertyVault.GetCurrentGameProperty();
-            GameNameType       gameNameType        = currentGameProperty.GamePreset.GameType;
-            string relFilePath = gameNameType switch
+            var relFilePath = @"Assets\\Images\\GamePoster\\headerposter_genshin.png";
+            try
             {
-                GameNameType.Zenless => @"Assets\\Images\\GamePoster\\headerposter_zzz.png",
-                GameNameType.Honkai => @"Assets\\Images\\GamePoster\\headerposter_honkai.png",
-                GameNameType.StarRail => @"Assets\\Images\\GamePoster\\headerposter_starrail.png",
-                _ => @"Assets\\Images\\GamePoster\\headerposter_genshin.png"
-            };
+                var currentGameProperty = GamePropertyVault.GetCurrentGameProperty();
+                var gameNameType        = currentGameProperty.GamePreset.GameType;
+                relFilePath = gameNameType switch
+                                     {
+                                         GameNameType.Zenless => @"Assets\\Images\\GamePoster\\headerposter_zzz.png",
+                                         GameNameType.Honkai => @"Assets\\Images\\GamePoster\\headerposter_honkai.png",
+                                         GameNameType.StarRail => @"Assets\\Images\\GamePoster\\headerposter_starrail.png",
+                                         _ => @"Assets\\Images\\GamePoster\\headerposter_genshin.png"
+                                     };
+            }
+            catch (Exception ex)
+            {
+                SentryHelper.ExceptionHandler(ex);
+                Logger.LogWriteLine($"[UserFeedbackDialog::OnApplyTemplate] Failed to grab game type! Returning default game header..." +
+                                    $"\r\n{ex}", LogType.Error, true);
+            }
             // Get the title image background and load it.
             FileInfo filePathInfo = new(Path.Combine(LauncherConfig.AppExecutableDir, relFilePath));
             if (filePathInfo.Exists)
@@ -155,8 +166,8 @@ protected override void OnApplyTemplate()
             // Find an overlay grid where the UI element will be spawn to
             _parentOverlayGrid = XamlRoot.FindOverlayGrid(_isAlwaysOnTop);
             // Get the count of the Rows and Column so it can be spanned across the grid.
-            int parentGridRowCount = _parentOverlayGrid?.RowDefinitions.Count ?? 1;
-            int parentGridColumnCount = _parentOverlayGrid?.ColumnDefinitions.Count ?? 1;
+            var parentGridRowCount    = _parentOverlayGrid?.RowDefinitions.Count ?? 1;
+            var parentGridColumnCount = _parentOverlayGrid?.ColumnDefinitions.Count ?? 1;
             // Add the UI element to the grid
             _parentOverlayGrid?.AddElementToGridRowColumn(this,
                                                           0,
@@ -200,14 +211,14 @@ protected override void OnApplyTemplate()
         private void AssignLocalization()
         {
             // Assign locale for Text header, button, placeholders and stuffs...
-            _layoutTitleGridText?.BindProperty(TextBlock.TextProperty, Locale.Lang._Dialogs, nameof(Locale.Lang._Dialogs.UserFeedback_DialogTitle));
-            _layoutFeedbackTitleInput?.BindProperty(TextBox.PlaceholderTextProperty, Locale.Lang._Dialogs, nameof(Locale.Lang._Dialogs.UserFeedback_TextFieldTitlePlaceholder));
-            _layoutFeedbackMessageInput?.BindProperty(TextBox.PlaceholderTextProperty, Locale.Lang._Dialogs, nameof(Locale.Lang._Dialogs.UserFeedback_TextFieldMessagePlaceholder));
-            SetTextBoxPropertyHeaderLocale(_layoutFeedbackTitleInput, Locale.Lang._Dialogs.UserFeedback_TextFieldTitleHeader, Locale.Lang._Dialogs.UserFeedback_TextFieldRequired);
-            SetTextBoxPropertyHeaderLocale(_layoutFeedbackMessageInput, Locale.Lang._Dialogs.UserFeedback_TextFieldMessageHeader, Locale.Lang._Dialogs.UserFeedback_TextFieldRequired);
-            _layoutFeedbackRatingText?.BindProperty(TextBlock.TextProperty, Locale.Lang._Dialogs, nameof(Locale.Lang._Dialogs.UserFeedback_RatingText));
-            SetButtonPropertyTextLocale(_layoutPrimaryButton, Locale.Lang._Dialogs, nameof(Locale.Lang._Dialogs.UserFeedback_SubmitBtn));
-            SetButtonPropertyTextLocale(_layoutCloseButton, Locale.Lang._Dialogs, nameof(Locale.Lang._Dialogs.UserFeedback_CancelBtn));
+            _layoutTitleGridText?.BindProperty(TextBlock.TextProperty, Lang._Dialogs, nameof(Lang._Dialogs.UserFeedback_DialogTitle));
+            _layoutFeedbackTitleInput?.BindProperty(TextBox.PlaceholderTextProperty, Lang._Dialogs, nameof(Lang._Dialogs.UserFeedback_TextFieldTitlePlaceholder));
+            _layoutFeedbackMessageInput?.BindProperty(TextBox.PlaceholderTextProperty, Lang._Dialogs, nameof(Lang._Dialogs.UserFeedback_TextFieldMessagePlaceholder));
+            SetTextBoxPropertyHeaderLocale(_layoutFeedbackTitleInput, Lang._Dialogs.UserFeedback_TextFieldTitleHeader, Lang._Dialogs.UserFeedback_TextFieldRequired);
+            SetTextBoxPropertyHeaderLocale(_layoutFeedbackMessageInput, Lang._Dialogs.UserFeedback_TextFieldMessageHeader, Lang._Dialogs.UserFeedback_TextFieldRequired);
+            _layoutFeedbackRatingText?.BindProperty(TextBlock.TextProperty, Lang._Dialogs, nameof(Lang._Dialogs.UserFeedback_RatingText));
+            SetButtonPropertyTextLocale(_layoutPrimaryButton, Lang._Dialogs, nameof(Lang._Dialogs.UserFeedback_SubmitBtn));
+            SetButtonPropertyTextLocale(_layoutCloseButton, Lang._Dialogs, nameof(Lang._Dialogs.UserFeedback_CancelBtn));
         }
 
         private static void SetButtonPropertyTextLocale(Button? button, object localeObject, string nameOfLocale)