Replace managed process APIs with ProcessChecker

GamePresetProperty.GetGameProcessWithActiveWindow -> ProcessChecker.TryGetProcessIdWithActiveWindow

Author: neon-nyan

CollapseLauncher/Classes/GamePresetProperty.cs

@@ -13,9 +13,9 @@
 using Hi3Helper.SentryHelper;
 using Hi3Helper.Win32.Native.ManagedTools;
 using Hi3Helper;
+using Microsoft.Extensions.Logging;
 using Microsoft.UI.Xaml;
 using System;
-using System.Diagnostics;
 using System.IO;
 using System.Diagnostics.CodeAnalysis;
 
@@ -80,6 +80,7 @@ internal GamePresetProperty(UIElement uiElementParent, RegionResourceProp apiRes
             }
 
             GamePlaytime = new Playtime(GameVersion, GameSettings);
+            GamePropLogger = ILoggerHelper.GetILogger($"[GameProp: {GameVersion.GameName} - {GameVersion.GameRegion}]");
 
             SentryHelper.CurrentGameCategory   = GameVersion.GameName;
             SentryHelper.CurrentGameRegion     = GameVersion.GameRegion;
@@ -95,7 +96,8 @@ internal GamePresetProperty(UIElement uiElementParent, RegionResourceProp apiRes
         internal IGamePlaytime        GamePlaytime    { get; set; }
         internal IRepair?             GameRepair      { get; set; }
         internal ICache?              GameCache       { get; set; }
-        internal IGameVersion    GameVersion     { get; set; }
+        internal ILogger              GamePropLogger  { get; set; }
+        internal IGameVersion         GameVersion     { get; set; }
         internal IGameInstallManager  GameInstall     { get; set; }
         internal PresetConfig         GamePreset      { get => GameVersion.GamePreset; }
 
@@ -122,50 +124,29 @@ internal string GameExecutableNameWithoutExtension
         }
 
         [field: AllowNull, MaybeNull]
-        internal string GameExecutablePath
+        internal string GameExecutableDir
         {
-            get => field ??= Path.Combine(GameVersion.GameDirPath, GameExecutableName);
+            get => field ??= GameVersion.GameDirPath;
         }
 
-        internal bool IsGameRunning
+        [field: AllowNull, MaybeNull]
+        internal string GameExecutablePath
         {
-            get => ProcessChecker.IsProcessExist(GameExecutableName, out _, out _, GameExecutablePath, ILoggerHelper.GetILogger());
+            get => field ??= Path.Combine(GameExecutableDir, GameExecutableName);
         }
 
-        internal Process? GetGameProcessWithActiveWindow()
+        internal bool IsGameRunning
         {
-            Process[] processArr = Process.GetProcessesByName(GameExecutableNameWithoutExtension);
-            int selectedIndex = -1;
-
-            try
-            {
-                for (int i = 0; i < processArr.Length; i++)
-                {
-                    Process process = processArr[i];
-                    int processId = process.Id;
-
-                    string? processPath = ProcessChecker.GetProcessPathByProcessId(processId, ILoggerHelper.GetILogger());
-                    string expectedProcessPath = Path.Combine(GameVersion?.GameDirPath ?? "", GameExecutableName);
-                    if (string.IsNullOrEmpty(processPath) || !expectedProcessPath.Equals(processPath, StringComparison.OrdinalIgnoreCase)
-                     || process.MainWindowHandle == IntPtr.Zero)
-                        continue;
-
-                    selectedIndex = i;
-                    return process;
-                }
-            }
-            finally
-            {
-                for (int i = 0; i < processArr.Length; i++)
-                {
-                    if (i == selectedIndex)
-                        continue;
-                    processArr[i].Dispose();
-                }
-            }
-            return null;
+            get => ProcessChecker.IsProcessExist(GameExecutableName, out _, out _, GameExecutablePath, GamePropLogger);
         }
 
+        internal bool TryGetGameProcessIdWithActiveWindow(out int processId, out nint windowHandle)
+            => ProcessChecker.TryGetProcessIdWithActiveWindow(GameExecutableNameWithoutExtension,
+                                                              out processId,
+                                                              out windowHandle,
+                                                              GameExecutableDir,
+                                                              logger: GamePropLogger);
+
         ~GamePresetProperty()
         {
             Dispose();

CollapseLauncher/XAMLs/MainApp/Pages/HomePage.xaml.cs

@@ -1095,9 +1095,11 @@ private async void CheckRunningGameInstance(CancellationToken token)
                         PlaytimeIdleStack.Visibility = Visibility.Collapsed;
                         PlaytimeRunningStack.Visibility = Visibility.Visible;
 
-                        Process currentGameProcess = CurrentGameProperty.GetGameProcessWithActiveWindow();
-                        if (currentGameProcess != null)
+                        int processId;
+                        if (!CurrentGameProperty.TryGetGameProcessIdWithActiveWindow(out processId, out _))
                         {
+                            Process currentGameProcess = Process.GetProcessById(processId);
+
                             // HACK: For some reason, the text still unchanged.
                             //       Make sure the start game button text also changed.
                             startGameBtnText.Text = Lang._HomePage.StartBtnRunning;
@@ -1116,8 +1118,7 @@ private async void CheckRunningGameInstance(CancellationToken token)
                             int? width = gameSettings.SettingsScreen.width;
 
                             // Start the resizable window payload
-                            StartResizableWindowPayload(
-                                                        gamePreset.GameExecutableName,
+                            StartResizableWindowPayload(gamePreset.GameExecutableName,
                                                         gameSettings,
                                                         gamePreset.GameType, height, width);
 
@@ -2837,19 +2838,22 @@ private static void GenshinHDREnforcer()
         private async Task GameBoost_Invoke(GamePresetProperty gameProp)
         {
 #nullable enable
-            // Init new target process
             Process? toTargetProc = null;
             try
             {
+                int processId;
                 // Try catching the non-zero MainWindowHandle pointer and assign it to "toTargetProc" variable by using GetGameProcessWithActiveWindow()
-                while ((toTargetProc = gameProp.GetGameProcessWithActiveWindow()) == null)
+                while (!gameProp.TryGetGameProcessIdWithActiveWindow(out processId, out _))
                 {
                     await Task.Delay(1000); // Waiting the process to be found and assigned to "toTargetProc" variable.
                     // This is where the magic happen. When the "toTargetProc" doesn't meet the comparison to be compared as null,
                     // it will instead return a non-null value and assign it to "toTargetProc" variable,
                     // which it will break the loop and execute the next code below it.
                 }
 
+                // Init new target process
+                toTargetProc = Process.GetProcessById(processId);
+
                 LogWriteLine($"[HomePage::GameBoost_Invoke] Found target process! Waiting 10 seconds for process initialization...\r\n\t" +
                              $"Target Process : {toTargetProc.ProcessName} [{toTargetProc.Id}]", LogType.Default, true);