[Urgent] Preview 1.82.7 Hotfix Release (#624)

# What's new? - 1.82.7 Hotfix
- **[Fix]** Fix redundant Ini save-load mechanism and
FileNotFoundException upon loading, by @neon-nyan
This caused the launcher to throw ``FileNotFoundException`` error in the
background and causing the region fail to load.
- **[Imp]** Improvement on ``IniValue``, by @neon-nyan 
- Always cache ``IsEmpty`` property and update it only if the ``Value``
property is being set.
  - Add missing casting for ``Size`` struct
  - Add ``Create()`` static method
  - Add ``ToGuid()`` method and cast support
  - Add support for creating ``IniValue`` from ``Enum``
- **[Fix]** Avoid double desktop shortcut by using user's Desktop path,
by @neon-nyan
- **[Fix]** Fix wrong casting on implicit IniValue operator for Int32,
by @neon-nyan

----------------

# What's new? - 1.82.6
- **[Fix]** Download corruption due to download chunk size being too
small, by @neon-nyan
- **[Fix]** Double taskbar entry if console is enabled, by @bagusnl 
- **[Fix]** Repair function for GI/SR/HI3 detected updated plugin as
corrupted, by @bagusnl
- **[Imp]** Update 7z dll to 24.09, by @neon-nyan 
- **[Imp]** Http downloader module improvements, by @neon-nyan 
  - Bypass drive write cache
  - Use multi threaded file writer
- **[Imp]** ``IniFile`` parser improvements, by @neon-nyan 
    + Improving implicit casting on IniValue to numbers
This to allow maintainers to directly assign the IniValue to variable
types.
    + Reduce memory allocation on loading and saving IniFile
    + Improving saving performance to file or a stream.
    + More safety bound check to IniSection
    + Reduce overhead on checking Section Keys and Value Keys
    + Add more checks on loading values
    + Splitting class and structs into their own files

## ```IniFile``` benchmark (Old vs. New)
### Note
There might be some minor performance degradation on Loading mechanism
due to additional check overhead.
More work will be implemented later to fix this.
| Method | Mean Time | Ratio | Time Imp (%) | Allocated Mem. | Ratio |
Mem. Imp (%) |
|-----------------
|-----------:|-----------:|----------------------:|------------:|------------:|-----------------------:|
| Load_Old | 77.85 µs | 1.000 | - | 217.3 KB | 1.000 | - |
| Load_New | 80.80 µs | 1.038 | -3.8% | 138.3 KB | 0.637 | +36.4% |
| Load_OrderedNew | 79.73 µs | 1.024 | -2.4% | 138.3 KB | 0.637 | +36.4%
|
| Save_Old | 0.10 µs | 1.000 | - | 2.2 KB | 1.000 | - |
| Save_New | 0.06 µs | 0.630 | +37.0% | 0.4 KB | 0.181 | +81.8% |
| Save_OrderedNew | 0.06 µs | 0.665 | +33.5% | 0.4 KB | 0.181 | +81.8% |


### Templates

<details>
  <summary>Changelog Prefixes</summary>
  
  ```
    **[New]**
    **[Imp]**
    **[Fix]**
    **[Loc]**
    **[Doc]**
  ```

</details>

Author: neon-nyan

CollapseLauncher/Classes/GameManagement/GameVersion/BaseClass/GameVersionBase.cs

@@ -242,8 +242,8 @@ protected GameVersion? GameVersionInstalled
             }
             set
             {
-                UpdateGameVersion(value ?? GameVersionAPI);
-                UpdateGameChannels();
+                UpdateGameVersion(value ?? GameVersionAPI, false);
+                UpdateGameChannels(false);
             }
         }
 
@@ -1071,7 +1071,7 @@ protected virtual void TryReinitializeGameVersion()
         {
             // Check if the GameVersionInstalled == null (version config doesn't exist),
             // Reinitialize the version config and save the version config by assigning GameVersionInstalled.
-            if (GameVersionInstalled == null && GameAPIProp.data?.game?.latest?.version != null)
+            if (!GameVersionInstalled.HasValue && !string.IsNullOrEmpty(GameAPIProp.data?.game?.latest?.version))
             {
                 GameVersionInstalled = GameVersionAPI;
             }
@@ -1122,6 +1122,12 @@ private void InitializeIniProp()
 
         private bool IsTryParseIniVersionExist(string iniPath)
         {
+            // If the file doesn't exist, return false by default
+            if (!File.Exists(iniPath))
+            {
+                return false;
+            }
+
             // Load version config file.
             IniFile iniFile = new IniFile();
             iniFile.Load(iniPath);
@@ -1156,7 +1162,7 @@ private bool IsDiskPartitionExist(string path)
             }
         }
 
-        private void SaveGameIni(string filePath, in IniFile INI)
+        private void SaveGameIni(string filePath, IniFile INI)
         {
             // Check if the disk partition exist. If it's exist, then save the INI.
             if (IsDiskPartitionExist(filePath))
@@ -1165,7 +1171,7 @@ private void SaveGameIni(string filePath, in IniFile INI)
             }
         }
 
-        private void InitializeIniProp(string iniFilePath, in IniFile ini, IniSection defaults, string section, bool allowOverwriteUnmatchValues = false)
+        private void InitializeIniProp(string iniFilePath, IniFile ini, IniSection defaults, string section, bool allowOverwriteUnmatchValues = false)
         {
             // Get the file path of the INI file and normalize it
             iniFilePath = ConverterTool.NormalizePath(iniFilePath);
@@ -1174,26 +1180,17 @@ private void InitializeIniProp(string iniFilePath, in IniFile ini, IniSection de
             // Check if the disk partition is ready (exist)
             bool IsDiskReady = IsDiskPartitionExist(iniDirPath);
 
-            // Create the directory of the file if it doesn't exist
-            if (iniDirPath != null && !Directory.Exists(iniDirPath) && IsDiskReady)
-            {
-                Directory.CreateDirectory(iniDirPath);
-            }
-
-            // Load the INI file.
-            if (IsDiskReady)
+            // Load the existing INI file if only the file exist.
+            if (IsDiskReady && File.Exists(iniFilePath))
             {
                 ini.Load(iniFilePath);
             }
 
             // Initialize and ensure the non-existed values to their defaults.
             InitializeIniDefaults(ini, defaults, section, allowOverwriteUnmatchValues);
-
-            // Always save the file to ensure file existency
-            SaveGameIni(iniFilePath, ini);
         }
 
-        private void InitializeIniDefaults(in IniFile ini, IniSection defaults, string section, bool allowOverwriteUnmatchValues)
+        private void InitializeIniDefaults(IniFile ini, IniSection defaults, string section, bool allowOverwriteUnmatchValues)
         {
             // If the section doesn't exist, then add the section.
             if (!ini.ContainsKey(section))

CollapseLauncher/Classes/Helper/Database/DBConfig.cs

@@ -17,7 +17,7 @@ public static class DbConfig
         private const string _configFileName = "dbConfig.ini";
         private const string DbSectionName   = "database";
 
-        private static readonly string  _configPath = Path.Combine(_configFolder, _configFileName);
+        private static readonly string _configPath = Path.Combine(_configFolder, _configFileName);
 
         // ReSharper disable once FieldCanBeMadeReadOnly.Local
         private static IniFile _config = new();
@@ -32,7 +32,7 @@ public static void Init()
 
             DefaultChecker();
         }
-        
+
         private static void EnsureConfigExist()
         {
             if (File.Exists(_configPath)) return;
@@ -53,7 +53,14 @@ private static void DefaultChecker()
             }
         }
 
-        private static void Load(CancellationToken token = default) => _config.Load(_configPath);
+        private static void Load(CancellationToken token = default)
+        {
+            if (File.Exists(_configPath))
+            {
+                _config.Load(_configPath);
+            }
+        }
+
         private static void Save(CancellationToken token = default) => _config.Save(_configPath);
 
         public static IniValue GetConfig(string key) => _config[DbSectionName][key];

CollapseLauncher/Classes/Helper/TaskSchedulerHelper.cs

@@ -215,7 +215,7 @@ internal static (string IconStartMenu, string IconDesktop) GetIconLocationPaths(
             appProductName = currentExecVersionInfo.ProductName;
             string shortcutFilename = appProductName + ".lnk";
             string startMenuLocation = Environment.GetFolderPath(Environment.SpecialFolder.CommonStartMenu);
-            string desktopLocation = Environment.GetFolderPath(Environment.SpecialFolder.CommonDesktopDirectory);
+            string desktopLocation = Environment.GetFolderPath(Environment.SpecialFolder.DesktopDirectory);
             string iconLocationStartMenu = Path.Combine(
                 startMenuLocation,
                 "Programs",

CollapseLauncher/CollapseLauncher.csproj

@@ -16,7 +16,7 @@
         <Authors>$(Company). neon-nyan, Cry0, bagusnl, shatyuka, gablm.</Authors>
         <Copyright>Copyright 2022-2024 $(Company)</Copyright>
         <!-- Versioning -->
-        <Version>1.82.6</Version>
+        <Version>1.82.7</Version>
         <LangVersion>preview</LangVersion>
         <!-- Target Settings -->
         <Platforms>x64</Platforms>

CollapseLauncher/XAMLs/Invoker/Classes/Migrate.cs

@@ -98,9 +98,11 @@ public void DoMigration(string source, string target)
 
             IniFile iniFile = new IniFile();
 
-            if (File.Exists(Path.Combine(source, "config.ini")))
+            string configFilePath = Path.Combine(source, "config.ini");
+
+            if (File.Exists(configFilePath))
             {
-                iniFile.Load(Path.Combine(source, "config.ini"));
+                iniFile.Load(configFilePath, true);
                 sourceGame = ConverterTool.NormalizePath(iniFile["launcher"]["game_install_path"].ToString());
                 targetGame = Path.Combine(target, Path.GetFileName(sourceGame));
                 Console.WriteLine($"Moving From:\r\n\t{source}\r\nTo Destination:\r\n\t{target}");

Hi3Helper.Core/Classes/Shared/Region/LauncherConfig.cs

@@ -95,14 +95,14 @@ public static void SetAndSaveConfigValue(string key, IniValue value, bool doNotL
         }
         public static void SetAppConfigValue(string key, IniValue value) => appIni.Profile![SectionName]![key!] = value;
 
-        public static void LoadAppConfig() => appIni.Profile!.Load(appIni.ProfilePath);
+        public static void LoadAppConfig() => appIni.Profile!.Load(appIni.ProfilePath, true);
         public static void SaveAppConfig() => appIni.Profile!.Save(appIni.ProfilePath);
 
         public static void CheckAndSetDefaultConfigValue()
         {
             foreach (KeyValuePair<string, IniValue> Entry in AppSettingsTemplate!)
             {
-                if (!appIni.Profile![SectionName]!.ContainsKey(Entry.Key!) || string.IsNullOrEmpty(appIni.Profile[SectionName][Entry.Key]))
+                if (!appIni.Profile![SectionName]!.ContainsKey(Entry.Key!) || appIni.Profile[SectionName][Entry.Key].IsEmpty)
                 {
                     SetAppConfigValue(Entry.Key, Entry.Value);
                 }
@@ -111,7 +111,7 @@ public static void CheckAndSetDefaultConfigValue()
         #endregion
 
         #region Misc Methods
-        public static void LoadGamePreset() => AppGameFolder = Path.Combine(GetAppConfigValue("GameFolder").ToString()!);
+        public static void LoadGamePreset() => AppGameFolder = Path.Combine(GetAppConfigValue("GameFolder")!);
 
         public static void GetScreenResolutionString(ScreenProp screenProp)
         {
@@ -161,7 +161,7 @@ private static void InitScreenResSettings(ScreenProp screenProp)
               },
           };
 
-        public static CDNURLProperty GetCurrentCDN() => CDNList![GetAppConfigValue("CurrentCDN").ToInt()];
+        public static CDNURLProperty GetCurrentCDN() => CDNList![GetAppConfigValue("CurrentCDN")];
         #endregion
 
         #region Misc Fields
@@ -202,7 +202,7 @@ private static void InitScreenResSettings(ScreenProp screenProp)
         public static string AppImagesFolder = Path.Combine(AppFolder, "Assets", "Images");
         public static string AppGameFolder
         {
-            get => GetAppConfigValue("GameFolder").ToString();
+            get => GetAppConfigValue("GameFolder");
             set => SetAppConfigValue("GameFolder", value);
         }
         public static string[] AppCurrentArgument;
@@ -262,11 +262,11 @@ public static int AppCurrentThread
         {
             get
             {
-                int val = GetAppConfigValue("ExtractionThread").ToInt();
+                int val = GetAppConfigValue("ExtractionThread");
                 return val <= 0 ? Environment.ProcessorCount : val;
             }
         }
-        public static int AppCurrentDownloadThread => GetAppConfigValue("DownloadThread").ToInt();
+        public static int AppCurrentDownloadThread => GetAppConfigValue("DownloadThread");
         public static string AppGameConfigMetadataFolder { get => Path.Combine(AppGameFolder!, "_metadatav3"); }
 
         public static readonly bool IsAppLangNeedRestart    = false;
@@ -278,55 +278,55 @@ public static int AppCurrentThread
         public static bool IsFirstInstall                   = false;
         public static bool IsConsoleEnabled
         {
-            get => GetAppConfigValue("EnableConsole").ToBoolNullable() ?? false;
+            get => GetAppConfigValue("EnableConsole");
             set => SetAppConfigValue("EnableConsole", value);
         }
 
         public static bool IsMultipleInstanceEnabled
         {
-            get => GetAppConfigValue("EnableMultipleInstance").ToBoolNullable() ?? false;
+            get => GetAppConfigValue("EnableMultipleInstance");
             set => SetAndSaveConfigValue("EnableMultipleInstance", value);
         }
 
         public static bool IsShowRegionChangeWarning
         {
-            get => GetAppConfigValue("ShowRegionChangeWarning").ToBool();
+            get => GetAppConfigValue("ShowRegionChangeWarning");
             set => SetAndSaveConfigValue("ShowRegionChangeWarning", value);
         }
 
         public static bool EnableAcrylicEffect
         {
-            get => GetAppConfigValue("EnableAcrylicEffect").ToBoolNullable() ?? false;
+            get => GetAppConfigValue("EnableAcrylicEffect");
             set => SetAndSaveConfigValue("EnableAcrylicEffect", value);
         }
 
         public static bool IsUseVideoBGDynamicColorUpdate
         {
-            get => GetAppConfigValue("IsUseVideoBGDynamicColorUpdate").ToBoolNullable() ?? false;
+            get => GetAppConfigValue("IsUseVideoBGDynamicColorUpdate");
             set => SetAndSaveConfigValue("IsUseVideoBGDynamicColorUpdate", value);
         }
 
         public static bool IsIntroEnabled
         {
-            get => GetAppConfigValue("IsIntroEnabled").ToBoolNullable() ?? true;
+            get => GetAppConfigValue("IsIntroEnabled");
             set => SetAndSaveConfigValue("IsIntroEnabled", value);
         }
 
         public static bool IsBurstDownloadModeEnabled
         {
-            get => GetAppConfigValue("IsBurstDownloadModeEnabled").ToBoolNullable() ?? true;
+            get => GetAppConfigValue("IsBurstDownloadModeEnabled");
             set => SetAndSaveConfigValue("IsBurstDownloadModeEnabled", value);
         }
 
         public static bool IsUsePreallocatedDownloader
         {
-            get => GetAppConfigValue("IsUsePreallocatedDownloader").ToBoolNullable() ?? true;
+            get => GetAppConfigValue("IsUsePreallocatedDownloader");
             set => SetAndSaveConfigValue("IsUsePreallocatedDownloader", value);
         }
 
         public static bool IsUseDownloadSpeedLimiter
         {
-            get => GetAppConfigValue("IsUseDownloadSpeedLimiter").ToBoolNullable() ?? true;
+            get => GetAppConfigValue("IsUseDownloadSpeedLimiter");
             set
             {
                 SetAndSaveConfigValue("IsUseDownloadSpeedLimiter", value);
@@ -337,7 +337,7 @@ public static bool IsUseDownloadSpeedLimiter
 
         public static long DownloadSpeedLimit
         {
-            get => DownloadSpeedLimitCached = GetAppConfigValue("DownloadSpeedLimit").ToLong();
+            get => DownloadSpeedLimitCached = GetAppConfigValue("DownloadSpeedLimit");
             set => SetAndSaveConfigValue("DownloadSpeedLimit", DownloadSpeedLimitCached = value);
         }
 
@@ -346,7 +346,7 @@ public static int DownloadChunkSize
             get
             {
                 // Clamp value, Min: 32 MiB, Max: 512 MiB
-                int configValue = GetAppConfigValue("DownloadChunkSize").ToInt();
+                int configValue = GetAppConfigValue("DownloadChunkSize");
                 configValue = Math.Clamp(configValue, 32 << 20, 512 << 20);
                 return configValue;
             }
@@ -360,7 +360,7 @@ public static int DownloadChunkSize
 
         public static bool IsEnforceToUse7zipOnExtract
         {
-            get => GetAppConfigValue("EnforceToUse7zipOnExtract").ToBool();
+            get => GetAppConfigValue("EnforceToUse7zipOnExtract");
             set => SetAndSaveConfigValue("EnforceToUse7zipOnExtract", value);
         }
 
@@ -384,7 +384,7 @@ public static bool IsInstantRegionChange
         {
             get
             {
-                _cachedIsInstantRegionChange ??= GetAppConfigValue("UseInstantRegionChange").ToBool();
+                _cachedIsInstantRegionChange ??= GetAppConfigValue("UseInstantRegionChange");
                 return (bool)_cachedIsInstantRegionChange;
             }
             set => SetAndSaveConfigValue("UseInstantRegionChange", value);
@@ -395,14 +395,14 @@ public static bool IsInstantRegionChange
 
         public static Guid GetGuid(int sessionNum)
         {
-            var guidString = GetAppConfigValue($"sessionGuid{sessionNum}").ToString();
-            if (string.IsNullOrEmpty(guidString))
+            Guid guidString = GetAppConfigValue($"sessionGuid{sessionNum}");
+            if (guidString == Guid.Empty)
             {
                 var g = Guid.NewGuid();
-                SetAndSaveConfigValue($"sessionGuid{sessionNum}", g.ToString());
+                SetAndSaveConfigValue($"sessionGuid{sessionNum}", g);
                 return g;
             }
-            return Guid.Parse(guidString);
+            return guidString;
         }
         #endregion
 
@@ -422,7 +422,7 @@ public static Guid GetGuid(int sessionNum)
             { "SendRemoteCrashData", true },
             { "EnableMultipleInstance", false },
             { "DontAskUpdate", false },
-            { "ThemeMode", new IniValue(AppThemeMode.Default) },
+            { "ThemeMode", IniValue.Create(AppThemeMode.Default) },
             { "AppLanguage", "en-us" },
             { "UseCustomBG", false },
             { "IsUseVideoBGDynamicColorUpdate", false },

Hi3Helper.Core/Data/IniFile.cs

@@ -104,6 +104,8 @@ public IniFile(IEqualityComparer<string>? stringComparer, bool isSaveOrdered)
         #region Load and Save Methods
         public void Save(string path)
         {
+            EnsureFolderExist(path);
+
             using FileStream stream = new FileStream(path, FileMode.Create, FileAccess.Write, FileShare.ReadWrite, CreateStreamBufferSize, FileOptions.None);
             using StreamWriter writer = new StreamWriter(stream, encoding: Encoding.UTF8, leaveOpen: false);
             SaveInner(writer);
@@ -152,9 +154,16 @@ private void SaveInner(StreamWriter writer)
             }
         }
 
-        public void Load(string path)
+        public void Load(string path, bool createIfNotExist = false)
         {
-            using FileStream stream = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite, OpenStreamBufferSize, FileOptions.None);
+            FileMode fileMode = createIfNotExist ? FileMode.OpenOrCreate : FileMode.Open;
+            if (createIfNotExist)
+            {
+                // Always ensure folder existence if createIfNotExist was toggled
+                EnsureFolderExist(path);
+            }
+
+            using FileStream stream = new FileStream(path, fileMode, FileAccess.Read, FileShare.ReadWrite, OpenStreamBufferSize, FileOptions.None);
             using StreamReader reader = new StreamReader(stream, leaveOpen: false);
             LoadInner(reader);
         }
@@ -227,6 +236,14 @@ private void LoadInner(TextReader reader)
             }
         }
 
+        private void EnsureFolderExist(string filePath)
+        {
+            // Always create the directory if none of it exist
+            string? pathDirectory = Path.GetDirectoryName(filePath);
+            if (!string.IsNullOrEmpty(pathDirectory))
+                _ = Directory.CreateDirectory(pathDirectory);
+        }
+
         private void GetOrCreateSection(string sectionName, [NotNull] out IniSection? iniSection)
         {
             // Try get the section and if it's not exist yet, then add it