[EncTool] CodeQA

Author: neon-nyan

CollapseLauncher/Classes/CachesManagement/Honkai/Fetch.cs

@@ -256,7 +256,7 @@ private async ValueTask<ValueTuple<int, long>> BuildAssetIndex(CacheAssetType ty
 
             // Parse asset index file from UABT
             BundleFile bundleFile = new BundleFile(stream);
-            SerializedFile serializeFile = new SerializedFile(bundleFile.fileList!.FirstOrDefault()!.stream);
+            SerializedFile serializeFile = new SerializedFile(bundleFile.fileList!.FirstOrDefault()!.Stream);
 
             // Try to get the asset index file as byte[] and load it as TextAsset
             byte[] dataRaw = serializeFile.GetDataFirstOrDefaultByName("packageversion.txt");

CollapseLauncher/Classes/RepairManagement/Genshin/Fetch.cs

@@ -584,7 +584,7 @@ private async Task<QueryProperty> GetDispatcherQuery(HttpClient client, Cancella
                 DispatchInfo dispatchInfo = await dispatchHelper.LoadDispatchInfo();
 
                 // DEBUG ONLY: Show encrypted Proto as JSON+Base64 format
-                string dFormat = $"Query Response (RAW Encrypted form):\r\n{dispatchInfo?.content}";
+                string dFormat = $"Query Response (RAW Encrypted form):\r\n{dispatchInfo?.Content}";
 #if DEBUG
                 LogWriteLine(dFormat);
 #endif
@@ -598,10 +598,8 @@ private async Task<QueryProperty> GetDispatcherQuery(HttpClient client, Cancella
 
         private async Task<QueryProperty> TryDecryptAndParseDispatcher(DispatchInfo dispatchInfo, DispatchHelper dispatchHelper)
         {
-            YSDispatchDec dispatchDecryptor = new YSDispatchDec();
-
             // Decrypt the dispatcher data from the dispatcher info content
-            byte[] decryptedData = dispatchDecryptor.DecryptYSDispatch(dispatchInfo.content, GameVersionManager.GamePreset.DispatcherKeyBitLength ?? 0, GameVersionManager.GamePreset.DispatcherKey);
+            byte[] decryptedData = YSDispatchDec.DecryptYSDispatch(dispatchInfo.Content, GameVersionManager.GamePreset.DispatcherKeyBitLength ?? 0, GameVersionManager.GamePreset.DispatcherKey);
 
             // DEBUG ONLY: Show the decrypted Proto as Base64 format
             string dFormat = $"Proto Response (RAW Decrypted form):\r\n{Convert.ToBase64String(decryptedData)}";

CollapseLauncher/Classes/RepairManagement/Honkai/Check.cs

@@ -791,7 +791,7 @@ protected override ConfiguredTaskAwaitable<byte[]> GetCryptoHashAsync<T>(
             if (_isGame820PostVersion && typeof(T) == typeof(MD5))
             {
                 // Create the Hasher provider by explicitly specify the length of the stream.
-                MhyMurmurHash2_64B murmurHashProvider = MhyMurmurHash2_64B.CreateForStream(stream, 0, stream.Length);
+                MhyMurmurHash264B murmurHashProvider = MhyMurmurHash264B.CreateForStream(stream, 0, stream.Length);
 
                 // Pass the provider and return the task
                 return Hash.GetHashAsync(stream,

CollapseLauncher/Classes/RepairManagement/Honkai/Fetch.cs

@@ -386,8 +386,8 @@ private static bool GetAssetBundleRefSpan(
             keyIndexes = new Dictionary<string, int>(StringComparer.OrdinalIgnoreCase);
             var alternativeLookup = keyIndexes.GetAlternateLookup<ReadOnlySpan<char>>();
 
-            ref AssetBundleReferenceKVPData startKvpIndex = ref MemoryMarshal.GetReference(span.KeyValuePair);
-            ref AssetBundleReferenceKVPData endKvpIndex = ref Unsafe.Add(ref startKvpIndex, span.KeyValuePair.Length);
+            ref AssetBundleReferenceKvpData startKvpIndex = ref MemoryMarshal.GetReference(span.KeyValuePair);
+            ref AssetBundleReferenceKvpData endKvpIndex = ref Unsafe.Add(ref startKvpIndex, span.KeyValuePair.Length);
 
             int currentDataOffset = 0;
             ref AssetBundleReferenceData startDataOffset = ref MemoryMarshal.GetReference(span.Data);
@@ -535,7 +535,7 @@ private HonkaiRepairAssetIgnore GetIgnoredAssetsProperty()
             }
 
             // Find the cache asset. If null, then return
-            CacheAsset cacheAsset = cacheProperty.Item1.FirstOrDefault(x => x!.N!.EndsWith($"{HashID.CGMetadata}"));
+            CacheAsset cacheAsset = cacheProperty.Item1.FirstOrDefault(x => x!.N!.EndsWith($"{HashID.CgMetadata}"));
 
             // Deserialize and build video index into asset index
             await BuildVideoIndex(downloadClient, cacheAsset, cacheProperty.Item2, assetIndex, ignoredAssetIDs, cacheProperty.Item4, token);

CollapseLauncher/XAMLs/MainApp/Pages/HomePage.GameLauncher.cs

@@ -581,15 +581,13 @@ private async void StartResizableWindowPayload(string       executableName, IGam
                 LogWriteLine("Game executable directory is not set! Cannot start Resizable Window payload!", LogType.Error);
                 return;
             }
-            
-            var resizableWindowHook     = new ResizableWindowHook();
 
             // Set the pos + size reinitialization to true if the game is Honkai: Star Rail
             // This is required for Honkai: Star Rail since the game will reset its pos + size. Making
             // it impossible to use custom resolution (but since you are using Collapse, it's now
             // possible :teriStare:)
             bool isNeedToResetPos = gameType == GameNameType.StarRail;
-            await Task.Run(() => resizableWindowHook.StartHook(executableName, height, width, ResizableWindowHookToken.Token,
+            await Task.Run(() => ResizableWindowHook.StartHook(executableName, height, width, ResizableWindowHookToken.Token,
                                                                isNeedToResetPos, ILoggerHelper.GetILogger(), gameExecutableDirectory));
         }
         catch (Exception ex)