SystemUI: fix race condition in ScreenshotController

// java.lang.IllegalStateException
//      at android.media.MediaPlayer._start(Native Method)
//      at android.media.MediaPlayer.startImpl(MediaPlayer.java:1371)
//      at android.media.MediaPlayer.start(MediaPlayer.java:1345)
//      at com.android.systemui.user.CreateUserActivity$$ExternalSyntheticLambda1.run(R8$$SyntheticClass:194)
//      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
//      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
//      at java.lang.Thread.run(Thread.java:1012)
//
** Monkey aborted due to error.

Change-Id: Ic159f3c32d2074f4002dc36f8cd24cc518ba288f
Signed-off-by: RakeshBatra <raakesh.batra@rediffmail.com>

Author: nift4

packages/SystemUI/src/com/android/systemui/screenshot/ScreenshotController.java

@@ -275,7 +275,8 @@ interface TransitionDestination {
     private final WindowManager mWindowManager;
     private final WindowManager.LayoutParams mWindowLayoutParams;
     private final AccessibilityManager mAccessibilityManager;
-    private final ListenableFuture<MediaPlayer> mCameraSound;
+
+    private ListenableFuture<MediaPlayer> mCameraSound;
     private final AudioManager mAudioManager;
     private final Vibrator mVibrator;
     private final CameraManager mCameraManager;
@@ -492,9 +493,12 @@ private void releaseMediaPlayer() {
         // Note that this may block if the sound is still being loaded (very unlikely) but we can't
         // reliably release in the background because the service is being destroyed.
         try {
-            MediaPlayer player = mCameraSound.get();
-            if (player != null) {
-                player.release();
+            if (mCameraSound != null) {
+                MediaPlayer player = mCameraSound.get();
+                if (player != null) {
+                    player.release();
+                }
+                mCameraSound = null;
             }
         } catch (InterruptedException | ExecutionException e) {
         }
@@ -910,15 +914,24 @@ private ListenableFuture<MediaPlayer> loadCameraSound() {
     }
 
     private void playCameraSound() {
-        mCameraSound.addListener(() -> {
-            try {
-                MediaPlayer player = mCameraSound.get();
-                if (player != null) {
-                    player.start();
+        if (Settings.System.getIntForUser(mContext.getContentResolver(),
+                 Settings.System.SCREENSHOT_SHUTTER_SOUND, 1, UserHandle.USER_CURRENT) == 0) {
+            return;
+        }
+
+        if (mCameraSound != null) {
+            mCameraSound.addListener(() -> {
+                try {
+                    if (mCameraSound != null) {
+                        MediaPlayer player = mCameraSound.get();
+                        if (player != null) {
+                            player.start();
+                        }
+                    }
+                } catch (InterruptedException | ExecutionException e) {
                 }
-            } catch (InterruptedException | ExecutionException e) {
-            }
-        }, mBgExecutor);
+            }, mBgExecutor);
+        }
     }
 
     /**