fix: fix the out-of-bound access in from_simple_string

HanatoK · jhenin · commit a80c6c4b171d · 2025-12-04T18:57:48.000+01:00
This commit ensures that the boundary check happens first.
diff --git a/src/colvartypes.h b/src/colvartypes.h
@@ -345,7 +345,7 @@ template <class T> class colvarmodule::vector1d
     std::stringstream stream(s);
     size_t i = 0;
     if (this->size()) {
-      while ((stream >> (*this)[i]) && (i < this->size())) {
+      while ((i < this->size()) && (stream >> (*this)[i])) {
         i++;
       }
       if (i < this->size()) {

Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ template <class T> class colvarmodule::vector1d`
`345`	`345`	`std::stringstream stream(s);`
`346`	`346`	`size_t i = 0;`
`347`	`347`	`if (this->size()) {`
`348`		`- while ((stream >> (*this)[i]) && (i < this->size())) {`
	`348`	`+ while ((i < this->size()) && (stream >> (*this)[i])) {`
`349`	`349`	`i++;`
`350`	`350`	`}`
`351`	`351`	`if (i < this->size()) {`