cleanup: Remove unused flag

Author: giacomofiorin

gromacs/src/applied_forces/colvars/colvarproxygromacs.cpp.patch

@@ -0,0 +1,14 @@
+diff --git a/src/gromacs/applied_forces/colvars/colvarproxygromacs.cpp b/src/gromacs/applied_forces/colvars/colvarproxygromacs.cpp
+index 76b350c611..37e5b53647 100644
+--- a/src/gromacs/applied_forces/colvars/colvarproxygromacs.cpp
++++ b/src/gromacs/applied_forces/colvars/colvarproxygromacs.cpp
+@@ -79,9 +79,6 @@ ColvarProxyGromacs::ColvarProxyGromacs(const std::string& colvarsConfigString,
+     // Retrieve masses and charges from input file
+     updated_masses_ = updated_charges_ = true;
+ 
+-    // User-scripted forces are not available in GROMACS
+-    have_scripts = false;
+-
+     angstrom_value_ = 0.1;
+ 
+     // From Gnu units

namd/src/colvarproxy_namd.C

@@ -134,12 +134,6 @@ colvarproxy_namd::colvarproxy_namd(GlobalMasterColvars *gm)
   // save to Node for Tcl script access
   Node::Object()->colvars = colvars;
 
-#ifdef NAMD_TCL
-  have_scripts = true;
-#else
-  have_scripts = false;
-#endif
-
   if (simparams->firstTimestep != 0) {
     colvars->set_initial_step(static_cast<cvm::step_number>(simparams->firstTimestep));
   }

src/colvarproxy.cpp

@@ -416,18 +416,14 @@ int colvarproxy_smp::smp_unlock()
 
 
 
-colvarproxy_script::colvarproxy_script()
-{
-  script = NULL;
-  have_scripts = false;
-}
+colvarproxy_script::colvarproxy_script() {}
 
 
 colvarproxy_script::~colvarproxy_script()
 {
-  if (script != NULL) {
+  if (script) {
     delete script;
-    script = NULL;
+    script = nullptr;
   }
 }
 

src/colvarproxy.h

@@ -529,10 +529,7 @@ class colvarproxy_script {
 
   /// Pointer to the scripting interface object
   /// (does not need to be allocated in a new interface)
-  colvarscript *script;
-
-  /// Do we have a scripting interface?
-  bool have_scripts;
+  colvarscript *script = nullptr;
 
   /// Run a user-defined colvar forces script
   virtual int run_force_callback();

vmd/src/colvarproxy_vmd.C

@@ -85,15 +85,9 @@ colvarproxy_vmd::colvarproxy_vmd(Tcl_Interp *interp, VMDApp *v, int molid)
   // both fields are taken from data structures already available
   updated_masses_ = updated_charges_ = true;
 
-  // Do we have scripts?
-  // For now colvars depend on Tcl, but this may not always be the case
-  // in the future
 #if defined(VMDTCL)
-  have_scripts = true;
   // Need to set this before constructing colvarmodule, which creates colvarscript object
   set_tcl_interp(interp);
-#else
-  have_scripts = false;
 #endif
 
   colvars = new colvarmodule(this);