Skip to content

Commit 99d53d4

Browse files
committed
adds readme todo
1 parent 802743e commit 99d53d4

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,13 @@ A common pattern in list based views is to load a very long list of elements in
110110

111111
**CombineDataSources** includes a data source allowing you to easily implement the batched list pattern called `BatchesDataSource`.
112112

113+
## Todo
113114

115+
- [ ] make the batches data source prepend or append the new batch (e.g. new items come from the top or at the bottom)
116+
- [ ] cover every API with tests
117+
- [ ] make the default batches view controller neater
118+
- [ ] add AppKit version of the data sources
119+
- [ ] support Cocoapods
114120

115121
## Installation
116122

Sources/CombineDataSources/BatchesDataSource/BatchesDataSource.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public struct BatchesDataSource<Element> {
6262
case error(Error)
6363
}
6464

65-
/// Initialiazes a list data source using a token to fetch batches of items.
65+
/// Initializes a list data source using a token to fetch batches of items.
6666
/// - Parameter items: initial list of items.
6767
/// - Parameter input: the input to control the data source.
6868
/// - Parameter initialToken: the token to use to fetch the first batch.

Tests/CombineDataSourcesTests/TestFixtures.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import XCTest
99
import CombineDataSources
1010
import UIKit
1111

12-
struct Model: Equatable {
12+
struct Model: Hashable {
1313
var text: String
1414
}
1515

0 commit comments

Comments
 (0)