s/predicate/comparator for all occurrences related to .removeAllDuplicates.

Author: jasdev

README.md

@@ -407,7 +407,7 @@ intArrayPublisher.send([10, 2, 2, 4, 3, 8])
 
 `Publisher.removeAllDuplicates` and `.removeAllDuplicates(by:)` are stricter forms of Apple’s [`Publisher.removeDuplicates`](https://developer.apple.com/documentation/combine/publisher/3204745-removeduplicates) and [`.removeDuplicates(by:)`](https://developer.apple.com/documentation/combine/publisher/3204746-removeduplicates)—the operators de-duplicate across _all_ previous value events, instead of pairwise.
 
-If your `Output` doesn‘t conform to `Hashable` or `Equatable`, you may instead use the predicate-based version of this operator to decide whether two elements are equal.
+If your `Output` doesn‘t conform to `Hashable` or `Equatable`, you may instead use the comparator-based version of this operator to decide whether two elements are equal.
 
 ```swift
 subscription = [1, 1, 2, 1, 3, 3, 4].publisher

Sources/Operators/RemoveAllDuplicates.swift

@@ -36,11 +36,11 @@ public extension Publisher where Output: Equatable {
 }
 
 public extension Publisher {
-    /// De-duplicates _all_ published value events, along the provided `by` predicate, as opposed to pairwise with `Publisher.removeDuplicates(by:)`.
+    /// De-duplicates _all_ published value events, along the provided `by` comparator, as opposed to pairwise with `Publisher.removeDuplicates(by:)`.
     ///
-    /// - parameter by: A predicate to use when determining uniqueness. `Publisher.removeAllDuplicates` will iterate
-    ///                 over all seen values applying each known unique value as the first argument to the predicate and the
-    ///                 incoming value event as the second, i.e. `by(see, next) -> Bool`. If this predicate is `true` for any
+    /// - parameter by: A comparator to use when determining uniqueness. `Publisher.removeAllDuplicates` will iterate
+    ///                 over all seen values applying each known unique value as the first argument to the comparator and the
+    ///                 incoming value event as the second, i.e. `by(see, next) -> Bool`. If this comparator is `true` for any
     ///                 seen value, the next incoming value isn’t emitted downstream.
     ///
     /// - note: It’s important to note that this operator stores all emitted values

Tests/RemoveAllDuplicatesTests.swift

@@ -167,11 +167,11 @@ final class RemoveAllDuplicatesTests: XCTestCase {
         XCTAssertEqual(completion, .failure(.anError))
     }
 
-    // MARK: - Predicate-related tests
+    // MARK: - Comparator-related tests
 
     private let isMultipleOf: (Int, Int) -> Bool = { seen, incoming in incoming.isMultiple(of: seen) }
 
-    func testPredicateExpectedDeduplication() {
+    func testComparatorExpectedDeduplication() {
         var results = [Int]()
 
         subscription = [2, 3, 3, 4].publisher
@@ -181,7 +181,7 @@ final class RemoveAllDuplicatesTests: XCTestCase {
         XCTAssertEqual(results, [2, 3])
     }
 
-    func testPredicateDeduplicationWithNoDuplicates() {
+    func testComparatorDeduplicationWithNoDuplicates() {
         var results = [Int]()
 
         subscription = [3, 5, 7, 11].publisher
@@ -191,7 +191,7 @@ final class RemoveAllDuplicatesTests: XCTestCase {
         XCTAssertEqual(results, [3, 5, 7, 11])
     }
 
-    func testPredicateDeduplicationDoesntInterfereWithFinishEvents() {
+    func testComparatorDeduplicationDoesntInterfereWithFinishEvents() {
         let integers = PassthroughSubject<Int, Never>()
 
         var completion: Subscribers.Completion<Never>?
@@ -211,7 +211,7 @@ final class RemoveAllDuplicatesTests: XCTestCase {
         XCTAssertEqual(completion, .finished)
     }
 
-    func testPredicateDeduplicationDoesntInterfereWithErrorEvents() {
+    func testComparatorDeduplicationDoesntInterfereWithErrorEvents() {
         let integers = PassthroughSubject<Int, RemoveAllDuplicatesTestError>()
 
         var completion: Subscribers.Completion<RemoveAllDuplicatesTestError>?