N°7150 - Backup : on MariaDB >= 11.0.1 call mariadb-dump instead of mysqldump

Author: accognet

datamodels/2.x/itop-backup/status.php

@@ -96,7 +96,7 @@ function GenerateBackupsList(string $sListTitleDictKey, string $sNoRecordDictKey
 	//
 	$sMySQLBinDir = MetaModel::GetConfig()->GetModuleSetting('itop-backup', 'mysql_bindir', '');
 	$sMySQLBinDir = utils::ReadParam('mysql_bindir', $sMySQLBinDir, true);
-	$sMySQLDump = DBBackup::MakeSafeMySQLCommand($sMySQLBinDir, 'mysqldump');
+	$sMySQLDump = DBBackup::MakeSafeMySQLCommand($sMySQLBinDir, DBBackup::GetDumpFunction());
 	$sCommand = "$sMySQLDump -V 2>&1";
 
 	$aOutput = [];

setup/backup.class.inc.php

@@ -346,7 +346,7 @@ public function DoBackup($sBackupFileName)
 		$this->LogInfo("Starting backup of $this->sDBHost/$this->sDBName(suffix:'$this->sDBSubName')");
 		$sMySQLBinDir = utils::ReadParam('mysql_bindir', $this->sMySQLBinDir, true);
 
-		$sMySQLDump = $this->MakeSafeMySQLCommand($sMySQLBinDir, 'mysqldump');
+		$sMySQLDump = $this->MakeSafeMySQLCommand($sMySQLBinDir, DBBackup::GetDumpFunction());
 
 		// Store the results in a temporary file
 		$sTmpFileName = self::EscapeShellArg($sBackupFileName);
@@ -603,6 +603,16 @@ public static function MakeSafeMySQLCommand($sMySQLBinDir, string $sCmd)
 
 		return '"'.$sMySQLCommand.'"';
 	}
+
+	public static function GetDumpFunction(): string
+	{
+		$version = CMDBSource::QueryToScalar('SELECT VERSION()');
+		if (is_string($version) && stripos($version, 'MariaDB') !== false) {
+			return 'mariadb-dump';
+		}
+
+		return 'mysqldump';
+	}
 }
 
 class TarGzArchive implements BackupArchive

setup/setuputils.class.inc.php

@@ -564,7 +564,7 @@ public static function CheckBackupPrerequisites($sDBBackupPath, $sMySQLBinDir =
 			$sMySQLBinDir = MetaModel::GetConfig()->GetModuleSetting('itop-backup', 'mysql_bindir', '');
 		}
 		try {
-			$sMySQLDump = DBBackup::MakeSafeMySQLCommand($sMySQLBinDir, 'mysqldump');
+			$sMySQLDump = DBBackup::MakeSafeMySQLCommand($sMySQLBinDir, DBBackup::GetDumpFunction());
 		} catch (Exception $e) {
 			$aResult[] = new CheckResult(CheckResult::ERROR, $e->getMessage());
 			return $aResult;