N°9141 Log when extension uninstallation is forced

Author: Timmy38

setup/wizardsteps/WizStepInstall.php

@@ -83,14 +83,34 @@ public function Display(WebPage $oPage)
 		$oPage->add('<input type="hidden" id="authent_token" value="'.$sAuthentToken.'"/>');
 		if (!$this->CheckDependencies()) {
 			$oPage->error($this->sDependencyIssue);
+			$oPage->add_ready_script(<<<JS
+	$("#wiz_form").data("installation_status", "error");
+	document.getElementById("setup_msg").innerText = "Unmet dependencies";
+JS);
+			return;
+		}
+
+		//When the setup reach this step, it already checked whether extensions were uninstallable (during WizStepModulesChoice). We only need to log what has been done.
+		if ($this->oWizard->GetParameter('force-uninstall', false)) {
+			SetupLog::Warning("User disabled uninstallation checks");
+		}
+		$aExtensionsRemoved = json_decode($this->oWizard->GetParameter('removed_extensions'), true) ?? [];
+		$aExtensionsNotUninstallable = json_decode($this->oWizard->GetParameter('extensions_not_uninstallable'));
+		$aExtensionsForceUninstalled = [];
+		foreach ($aExtensionsRemoved as $sExtensionCode => $sLabel) {
+			if (in_array($sExtensionCode, $aExtensionsNotUninstallable)) {
+				$aExtensionsForceUninstalled[] = $sExtensionCode;
+			}
+		}
+		if (count($aExtensionsForceUninstalled)) {
+			SetupLog::Warning("Extensions uninstalled forcefully : ".implode(',', $aExtensionsForceUninstalled));
 		}
 
-		$oPage->add_ready_script(
-			<<<JS
+		$oPage->add_ready_script(<<<JS
 	$("#wiz_form").data("installation_status", "not started");
 	ExecuteStep("");
-JS
-		);
+JS);
+
 	}
 
 	/**

setup/wizardsteps/WizStepModulesChoice.php

@@ -107,7 +107,7 @@ public function GetAddedAndRemovedExtensions($aSelectedExtensions)
 			$bSelected = in_array($oExtension->sCode, $aSelectedExtensions);
 			if ($oExtension->bInstalled && !$bSelected) {
 				$aExtensionsRemoved[$oExtension->sCode] = $oExtension->sLabel;
-				if (!$oExtension->CanBeUninstalled()) {
+				if (!$oExtension->CanBeUninstalled() || $oExtension->sSource === iTopExtension::SOURCE_REMOTE) {
 					$aExtensionsNotUninstallable[$oExtension->sCode] = true;
 				}
 			} elseif (!$oExtension->bInstalled && $bSelected) {