Add support for non-relative paths

Author: Hipska

setup/backup.class.inc.php

@@ -651,8 +651,9 @@ public static function MakeSafeMySQLCommand($sMySQLBinDir, string $sCmd)
 	public static function GetTmpDir(Config $oConfig): string
 	{
 		$sTmpDir = $oConfig->GetModuleSetting('itop-backup', 'backup_tmpdir', 'data/');
+		if (utils::RealPath(APPROOT.$sTmpDir, APPROOT) === false) $sTmpDir = APPROOT.$sTmpDir;
 
-		$sTmpDir = tempnam(empty($sTmpDir) ? SetupUtils::getTmpDir() : APPROOT.$sTmpDir , 'itop-backup-');
+		$sTmpDir = @tempnam(empty($sTmpDir) ? SetupUtils::getTmpDir() : $sTmpDir , 'itop-backup-');
 		unlink($sTmpDir); // I need a directory, not a file...
 		SetupUtils::builddir($sTmpDir);
 

tests/php-unit-tests/unitary-tests/setup/DBBackupTest.php

@@ -201,7 +201,7 @@ public function MakeNameProvider(): array
 	 * @covers DBBackup::GetTmpDir
 	 * @dataProvider GetTmpDirProvider
 	 */
-	public function testGetTmpDir(string $sTmpDir, string $sStartsWith): void
+	public function testGetTmpDir(?string $sTmpDir, string $sStartsWith): void
 	{
 		$this->RequireOnceItopFile('setup/setuputils.class.inc.php');
 		$oConfig = \utils::GetConfig(true);
@@ -217,6 +217,10 @@ public function testGetTmpDir(string $sTmpDir, string $sStartsWith): void
 	public function GetTmpDirProvider(): array
 	{
 		return [
+			'Not configured' => [
+				null,
+				static::GetAppRoot() . 'data/itop-backup',
+			],
 			'Default settings' => [
 				'data/',
 				static::GetAppRoot() . 'data/itop-backup',
@@ -225,17 +229,9 @@ public function GetTmpDirProvider(): array
 				'',
 				sys_get_temp_dir() . '/itop-backup',
 			],
-			'System directory attempt with existing root dir' => [
-				'/lib',
-				static::GetAppRoot() . 'lib/itop-backup',
-			],
-			'System directory attempt with non existing root dir' => [
-				'/etc',
-				static::GetAppRoot() . 'data/itop-backup',
-			],
-			'Breakout attempt' => [
-				'../../../var',
-				static::GetAppRoot() . 'data/itop-backup',
+			'Fixed system directory' => [
+				'/tmp',
+				'/tmp/itop-backup',
 			],
 		];
 	}