Changed modifiedTime param for RefreshIfModifiedAfter to int64

Author: pt-nguyen

cache.go

@@ -2,8 +2,6 @@
 // including support for LRU, Segmented LRU and TinyLFU.
 package cache
 
-import "time"
-
 // Key is any value which is comparable.
 // See http://golang.org/ref/spec#Comparison_operators for details.
 type Key interface{}
@@ -69,7 +67,7 @@ type LoadingCache interface {
 	// RefreshIfModifiedAfter asynchronously reloads value for Key if the provided timestamp
 	// indicates the data was modified after the entry was last loaded. If the entry doesn't exist,
 	// it will synchronously load and block until the value is loaded.
-	RefreshIfModifiedAfter(Key, time.Time)
+	RefreshIfModifiedAfter(Key, int64)
 }
 
 // LoaderFunc retrieves the value corresponding to given Key.

local.go

@@ -243,7 +243,7 @@ func (c *localCache) Refresh(k Key) {
 // RefreshIfModifiedAfter asynchronously reloads value for Key if the provided timestamp
 // indicates the data was modified after the entry was last loaded. If the entry doesn't exist,
 // it will synchronously load and block until the value is loaded.
-func (c *localCache) RefreshIfModifiedAfter(k Key, modifiedTime time.Time) {
+func (c *localCache) RefreshIfModifiedAfter(k Key, modifiedTime int64) {
 	if c.loader == nil {
 		return
 	}
@@ -252,7 +252,7 @@ func (c *localCache) RefreshIfModifiedAfter(k Key, modifiedTime time.Time) {
 		c.load(k)
 	} else {
 		// Only refresh if the data was modified after the entry was last loaded
-		if modifiedTime.UnixNano() > en.getWriteTime() {
+		if modifiedTime > en.getWriteTime() {
 			c.refreshAsync(en)
 		}
 	}

local_test.go

@@ -415,23 +415,23 @@ func TestRefreshIfModifiedAfter(t *testing.T) {
 
 	// 1. Entry does not exist, should load synchronously.
 	wg.Add(1)
-	c.RefreshIfModifiedAfter(key, mockTime.now())
+	c.RefreshIfModifiedAfter(key, mockTime.now().UnixNano())
 	wg.Wait()
 
 	if loadCount != 1 {
 		t.Fatalf("expected loadCount to be 1 after initial load, got %d", loadCount)
 	}
 
 	// 2. Entry exists, but modifiedTime is not after entry's write time. Should not refresh.
-	c.RefreshIfModifiedAfter(key, mockTime.now().Add(-1*time.Millisecond)) // modified time is before write time
+	c.RefreshIfModifiedAfter(key, mockTime.now().Add(-1*time.Millisecond).UnixNano()) // modified time is before write time
 	// No wg.Add/Wait as it should be synchronous and do nothing.
 	if loadCount != 1 {
 		t.Fatalf("expected loadCount to be 1 when not modified, got %d", loadCount)
 	}
 
 	// 3. Entry exists, and modifiedTime is after entry's write time. Should refresh.
 	wg.Add(1)
-	c.RefreshIfModifiedAfter(key, mockTime.now().Add(1*time.Millisecond)) // modified time is after write time
+	c.RefreshIfModifiedAfter(key, mockTime.now().Add(1*time.Millisecond).UnixNano()) // modified time is after write time
 	wg.Wait()
 	if loadCount != 2 {
 		t.Fatalf("expected loadCount to be 2 after refresh, got %d", loadCount)
@@ -448,14 +448,14 @@ func TestRefreshIfModifiedAfter(t *testing.T) {
 		t.Fatalf("unexpected get: %v %v", v, err)
 	}
 
-	c.RefreshIfModifiedAfter(key2, mockTime.now()) // modified time is the same as write time
+	c.RefreshIfModifiedAfter(key2, mockTime.now().UnixNano()) // modified time is the same as write time
 	// No wg.Add/Wait as it should be synchronous and do nothing.
 	if loadCount != 2 {
 		t.Fatalf("expected loadCount to be 2 when not modified, got %d", loadCount)
 	}
 
 	wg.Add(1)
-	c.RefreshIfModifiedAfter(key, mockTime.now().Add(1*time.Millisecond)) // modified time is after write time
+	c.RefreshIfModifiedAfter(key, mockTime.now().Add(1*time.Millisecond).UnixNano()) // modified time is after write time
 	wg.Wait()
 	if loadCount != 3 {
 		t.Fatalf("expected loadCount to be 3 after refresh, got %d", loadCount)