Skip to content

Commit e497b8b

Browse files
committed
Drop punycode dependency in favor of idna4s js implementation
1 parent 58f62fb commit e497b8b

File tree

5 files changed

+6492
-43
lines changed

5 files changed

+6492
-43
lines changed

build.sbt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,11 @@ lazy val core = crossProject(JVMPlatform, JSPlatform, NativePlatform)
8787
"org.scalacheck" %%% "scalacheck" % "1.19.0" % Test
8888
)
8989
)
90+
.jsSettings(
91+
libraryDependencies ++= Seq(
92+
"org.typelevel" %%% "idna4s-core" % "0.1.0"
93+
)
94+
)
9095
.nativeSettings(
9196
libraryDependencies ++= Seq(
9297
"org.typelevel" %%% "idna4s-core" % "0.1.0"
@@ -101,7 +106,6 @@ lazy val coreJS = core.js
101106
.disablePlugins(DoctestPlugin)
102107
.enablePlugins(ScalaJSBundlerPlugin)
103108
.settings(
104-
Compile / npmDependencies += "punycode" -> "2.1.1",
105109
scalaJSLinkerConfig ~= (_.withModuleKind(ModuleKind.CommonJSModule))
106110
)
107111

native/src/main/scala/com/comcast/ip4s/IDNCompanionPlatform.scala renamed to js-native/src/main/scala/com/comcast/ip4s/IDNCompanionPlatform.scala

File renamed without changes.

0 commit comments

Comments
 (0)