Merge pull request #60 from Comfy-Org/sno-coreping

refactor(coreping): migrate from index.tsx to coreping.ts implementation

Author: snomiao

.github/workflows/coreping.yaml

@@ -25,7 +25,7 @@ jobs:
       - run: bun i
 
       # Run CorePing task
-      - run: bun app/tasks/coreping/index.tsx
+      - run: bun app/tasks/coreping/coreping.ts
         timeout-minutes: 8
         env:
           GH_TOKEN_COMFY_PR: ${{ secrets.GH_TOKEN_COMFY_PR_BOT }}

app/tasks/coreping/index.tsx renamed to app/tasks/coreping/coreping.ts

@@ -111,6 +111,9 @@ if (import.meta.main) {
   // Designed to be mon to sat, TIME CHECKING
   // Pacific Daylight Time
 
+  // drop everytime since outdated data is useless, we kept lastSlackmessage in Meta collection which is enough
+  await ComfyCorePRs.drop();
+
   console.log("start", import.meta.file);
   let freshCount = 0;
 
@@ -240,7 +243,7 @@ if (import.meta.main) {
   const freshMsg = !freshCorePRs.length
     ? ""
     : `and there are ${freshCorePRs.length} more fresh Core/Core-Important PRs.\n`;
-  const notifyMessage = `Hey <@comfy>, Here's x${staleCorePRs.length} Core/Important PRs waiting your feedback!\n\n${staleCorePRsMessage}\n${freshMsg}\nSent from <CorePing> by <@snomiao> cc <@Yoland>`;
+  const notifyMessage = `Hey <@comfy>, Here's x${staleCorePRs.length} Core/Important PRs waiting your feedback!\n\n${staleCorePRsMessage}\n${freshMsg}\nSent from CorePing.ts by <@snomiao> cc <@yoland>`;
   console.log(chalk.bgBlue(notifyMessage));
 
   // TODO: update message with delete line when it's reviewed

app/tasks/gh-desktop-release-notification/upsertSlackMessage.ts

@@ -48,9 +48,8 @@ export async function upsertSlackMessage({
   }
   if (!channel) DIE(`No slack channel specified`);
 
-  if (process.env.DRY_RUN) throw new Error("sending slack message: " + JSON.stringify({ text, channel, url }));
-
   if (!url) {
+    if (process.env.DRY_RUN) throw new Error("sending slack message: " + JSON.stringify({ text, channel }));
     const thread_ts = !replyUrl ? undefined : slackMessageUrlParse(replyUrl).ts;
     const msg = !thread_ts
       ? await slack.chat.postMessage({ text, channel })
@@ -59,6 +58,7 @@ export async function upsertSlackMessage({
     const url = slackMessageUrlStringify({ channel, ts: msg.ts! });
     return { ...msg, url, text, channel };
   }
+  if (process.env.DRY_RUN) throw new Error("updating slack message: " + JSON.stringify({ text, channel, url }));
   const ts = slackMessageUrlParse(url).ts;
   const msg = await slack.chat.update({ text, channel, ts });
   return { ...msg, url, text, channel };