Skip to content

Commit ce12659

Browse files
snomiaoclaude
andcommitted
fix(coreping): improve Slack message logic and early return
- Refactor nested if-else structure to improve readability - Add early return when updating existing message within 24h window - Simplify logic flow for better maintainability 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 0e26918 commit ce12659

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

app/tasks/coreping/index.tsx

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -243,26 +243,26 @@ if (import.meta.main) {
243243
// TODO: update message with delete line when it's reviewed
244244
// send or update slack message
245245
let meta = await Meta.$upsert({});
246-
if (meta.lastSlackMessage) {
247-
// if <24 h since last sent (not edit), update that msg
248-
if (
249-
meta.lastSlackMessage.sendAt &&
250-
new Date().getTime() - new Date(meta.lastSlackMessage.sendAt).getTime() < 24 * 60 * 60 * 1000
251-
) {
252-
const msg = await upsertSlackMessage({
253-
text: notifyMessage,
254-
channelName: cfg.slackChannelName,
255-
url: meta.lastSlackMessage.url,
256-
});
257-
meta = await Meta.$upsert({ lastSlackMessage: { text: msg.text, url: msg.url, sendAt: new Date() } });
258-
} else {
259-
// if >24h, deprecate last message and post a new msg
260-
const msg = await upsertSlackMessage({
261-
text: notifyMessage,
262-
channelName: cfg.slackChannelName,
263-
});
264-
meta = await Meta.$upsert({ lastSlackMessage: { text: msg.text, url: msg.url, sendAt: new Date() } });
265-
}
246+
// if <24 h since last sent (not edit), update that msg
247+
if (
248+
meta.lastSlackMessage &&
249+
meta.lastSlackMessage.sendAt &&
250+
new Date().getTime() - new Date(meta.lastSlackMessage.sendAt).getTime() < 24 * 60 * 60 * 1000
251+
) {
252+
const msg = await upsertSlackMessage({
253+
text: notifyMessage,
254+
channelName: cfg.slackChannelName,
255+
url: meta.lastSlackMessage.url,
256+
});
257+
meta = await Meta.$upsert({ lastSlackMessage: { text: msg.text, url: msg.url, sendAt: new Date() } });
258+
return;
259+
} else {
260+
// if >24h or not exist, post a new msg
261+
const msg = await upsertSlackMessage({
262+
text: notifyMessage,
263+
channelName: cfg.slackChannelName,
264+
});
265+
meta = await Meta.$upsert({ lastSlackMessage: { text: msg.text, url: msg.url, sendAt: new Date() } });
266266
}
267267

268268
console.log("done", import.meta.file);

0 commit comments

Comments
 (0)