Skip to content

Commit e9f569e

Browse files
snomiaoclaudeCopilot
authored
feat: enhance notification reply broadcast functionality (#50)
* feat: enhance notification reply broadcast functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Update app/tasks/gh-desktop-release-notification/upsertSlackMessage.ts Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Claude <[email protected]> Co-authored-by: Copilot <[email protected]>
1 parent 962ebb5 commit e9f569e

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

app/tasks/gh-desktop-release-notification/index.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,8 @@ async function runGithubDesktopReleaseNotificationTask() {
107107
.replace("{url}", task.url)
108108
.replace("{repo}", parseGithubUrl(task.url)?.repo || DIE(`unable parse REPO from URL ${task.url}`))
109109
.replace("{version}", task.version || DIE(`unable to parse version from task ${JSON.stringify(task)}`))
110-
.replace("{status}", task.status),
110+
.replace("{status}", task.status)
111+
.replace(/$/, !coreTask?.version ? "" : " Core: " + coreTask.version),
111112
};
112113

113114
// upsert drafting message if new/changed
@@ -125,12 +126,14 @@ async function runGithubDesktopReleaseNotificationTask() {
125126
// upsert stable message if new/changed
126127
const shouldSendMessage = task.isStable || task.slackMessage?.url;
127128
if (shouldSendMessage && task.slackMessage?.text?.trim() !== newSlackMessage.text.trim()) {
129+
// const replyUrl =
130+
// coreTask?.slackMessageDrafting?.url || coreTask?.slackMessage?.url || task.slackMessageDrafting?.url;
128131
task = await save({
129132
url,
130133
slackMessage: await upsertSlackMessage({
131134
...newSlackMessage,
132-
replyUrl:
133-
coreTask?.slackMessageDrafting?.url || coreTask?.slackMessage?.url || task.slackMessageDrafting?.url,
135+
// replyUrl: replyUrl,
136+
// reply_broadcast: replyUrl ? true : false,
134137
}),
135138
});
136139
}

app/tasks/gh-desktop-release-notification/upsertSlackMessage.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,21 @@ export async function upsertSlackMessage({
66
channel,
77
url,
88
replyUrl,
9+
reply_broadcast,
910
}: {
1011
text: string;
1112
channel: string;
1213
url?: string;
1314
replyUrl?: string;
15+
reply_broadcast?: boolean;
1416
}) {
1517
if (process.env.DRY_RUN) throw new Error("sending slack message: " + JSON.stringify({ text, channel, url }));
1618
if (!url) {
1719
const thread_ts = !replyUrl ? undefined : slackMessageUrlParse(replyUrl).ts;
18-
const msg = await slack.chat.postMessage({ text, channel, thread_ts });
20+
const msg = !thread_ts
21+
? await slack.chat.postMessage({ text, channel })
22+
: await slack.chat.postMessage({ text, channel, thread_ts, reply_broadcast: reply_broadcast ?? false });
23+
1924
const url = slackMessageUrlStringify({ channel, ts: msg.ts! });
2025
return { ...msg, url, text, channel };
2126
}

0 commit comments

Comments
 (0)