docs: add comment about update notification feature in coreping #111
+487
−252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a comment noting the feature request for pinging when updates are made to previously-reviewed PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot finished reviewing on behalf of
snomiao
November 13, 2025 02:24
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comment documenting a feature request for notifying reviewers when previously-reviewed PRs receive updates. The comment is placed at the top of the coreping task file, which handles PR review reminders.
Key Changes
- Added informal comment about a feature request for pinging on PR updates
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import z from "zod"; | ||
| import { upsertSlackMessage } from "../gh-desktop-release-notification/upsertSlackMessage"; | ||
|
|
||
| // yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful |
There was a problem hiding this comment.
This comment lacks important context for a feature request. Consider using a more structured format that includes:
- A TODO or FEATURE label for tracking
- Who requested this feature or where it was discussed
- A brief description of what "previously-reviewed PR" means in this context
Example:
// TODO: Feature request - Add notification when updates are made to previously-reviewed PRs
// This would ping reviewers when a PR they've already reviewed receives new commits
// Requested by: [name/team] or tracked in issue #[number]This makes it easier to track and understand the feature request in the future.
Suggested change
| // yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful | |
| // TODO: Feature request - Notify reviewers when updates are made to previously-reviewed PRs |
| import z from "zod"; | ||
| import { upsertSlackMessage } from "../gh-desktop-release-notification/upsertSlackMessage"; | ||
|
|
||
| // yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful |
There was a problem hiding this comment.
The informal tone of this comment ("yeah, if the bot could...") is inconsistent with the professional documentation style used elsewhere in this file. Consider rephrasing to match the existing documentation standards, such as:
// Feature request: Enable pinging when updates are made to previously-reviewed PRs
Suggested change
| // yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful | |
| // Feature request: Enable pinging when updates are made to previously-reviewed PRs |
…remental updates This update significantly improves the coreping task to provide real-time status tracking of Core/Core-Important PRs with intelligent notification system: **New Features:** - Real-time PR status detection (DRAFT, OPEN, REVIEW_REQUESTED, COMMITTED, AUTHOR_COMMENTED, REVIEWER_COMMENTED, REVIEWED, MERGED, CLOSED) - Incremental status change tracking with ping notifications when PRs need attention - Individual Slack thread replies for status changes - Enhanced timeline analysis to determine exact review state - 5-minute scheduled runs (previously daily) for faster response times **New Utilities:** - `ghData()`: Helper to extract data from GitHub API responses - `ghPaged()`: Universal pagination helper for any GitHub API endpoint - Enhanced `ghc.ts` with better typing support **Improvements:** - More accurate detection of when PRs need reviewer attention - Smart ping system that only notifies on meaningful status transitions - Consolidated notifications with thread support - Better status explanations for transparency This makes the review process more responsive and ensures important PRs get timely attention. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code