Skip to content

docs: add comment about update notification feature in coreping #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: add comment about update notification feature in coreping #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/tasks/coreping/coreping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ import sflow, { pageFlow } from "sflow";
import { P } from "ts-pattern";
import z from "zod";
import { upsertSlackMessage } from "../gh-desktop-release-notification/upsertSlackMessage";

// yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment lacks important context for a feature request. Consider using a more structured format that includes:

  • A TODO or FEATURE label for tracking
  • Who requested this feature or where it was discussed
  • A brief description of what "previously-reviewed PR" means in this context

Example:

// TODO: Feature request - Add notification when updates are made to previously-reviewed PRs
// This would ping reviewers when a PR they've already reviewed receives new commits
// Requested by: [name/team] or tracked in issue #[number]

This makes it easier to track and understand the feature request in the future.

Suggested change
// yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful
// TODO: Feature request - Notify reviewers when updates are made to previously-reviewed PRs

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The informal tone of this comment ("yeah, if the bot could...") is inconsistent with the professional documentation style used elsewhere in this file. Consider rephrasing to match the existing documentation standards, such as:

// Feature request: Enable pinging when updates are made to previously-reviewed PRs
Suggested change
// yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful
// Feature request: Enable pinging when updates are made to previously-reviewed PRs

Copilot uses AI. Check for mistakes.

/**
* [Comfy- CorePing] The Core/Important PR Review Reminder Service
* This service reminders @comfyanonymous for unreviewed Core/Core-Important PRs every 24 hours in the morning 8am of california
Expand All @@ -36,6 +39,7 @@ import { upsertSlackMessage } from "../gh-desktop-release-notification/upsertSla
* match theLabel('Core-Ready-For-Review'):
*
*/

export const coreReviewTrackerConfig = {
REPOLIST: [
"https://github.com/comfyanonymous/ComfyUI",
Expand Down
Loading