Skip to content

Commit 4d172e9

Browse files
christian-byrneKosinkadink
christian-byrne
and
Kosinkadink
authored
feat: mark 429 widgets as advanced for collapsible UI (#12197)
* feat: mark 429 widgets as advanced for collapsible UI Mark widgets as advanced across core, comfy_extras, and comfy_api_nodes to support the new collapsible advanced inputs section in the frontend. Changes: - 267 advanced markers in comfy_extras/ - 162 advanced markers in comfy_api_nodes/ - All files pass python3 -m py_compile verification Widgets marked advanced (hidden by default): - Scheduler internals: sigma_max, sigma_min, rho, mu, beta, alpha - Sampler internals: eta, s_noise, order, rtol, atol, h_init, pcoeff, etc. - Memory optimization: tile_size, overlap, temporal_size, temporal_overlap - Pipeline controls: add_noise, start_at_step, end_at_step - Timing controls: start_percent, end_percent - Layer selection: stop_at_clip_layer, layers, block_number - Video encoding: codec, crf, format - Device/dtype: device, noise_device, dtype, weight_dtype Widgets kept basic (always visible): - Core params: strength, steps, cfg, denoise, seed, width, height - Model selectors: ckpt_name, lora_name, vae_name, sampler_name - Common controls: upscale_method, crop, batch_size, fps, opacity Related: frontend PR #11939 Amp-Thread-ID: https://ampcode.com/threads/T-019c1734-6b61-702e-b333-f02c399963fc * fix: remove advanced=True from DynamicCombo.Input (unsupported) Amp-Thread-ID: https://ampcode.com/threads/T-019c1734-6b61-702e-b333-f02c399963fc * fix: address review - un-mark model merge, video, image, and training node widgets as advanced Per comfyanonymous review: - Model merge arguments should not be advanced (all 14 model-specific merge classes) - SaveAnimatedWEBP lossless/quality/method should not be advanced - SaveWEBM/SaveVideo codec/crf/format should not be advanced - TrainLoraNode options should not be advanced (7 inputs) Amp-Thread-ID: https://ampcode.com/threads/T-019c322b-a3a8-71b7-9962-d44573ca6352 * fix: un-mark batch_size and webcam width/height as advanced (should stay basic) Amp-Thread-ID: https://ampcode.com/threads/T-019c3236-1417-74aa-82a3-bcb365fbe9d1 --------- Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>
1 parent 5632b2d commit 4d172e9

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

65 files changed

+407
-267
lines changed

‎comfy_api_nodes/nodes_bfl.py‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ def define_schema(cls) -> IO.Schema:
5757
tooltip="Whether to perform upsampling on the prompt. "
5858
"If active, automatically modifies the prompt for more creative generation, "
5959
"but results are nondeterministic (same seed will not produce exactly the same result).",
60+
advanced=True,
6061
),
6162
IO.Int.Input(
6263
"seed",
@@ -200,6 +201,7 @@ def define_schema(cls) -> IO.Schema:
200201
"prompt_upsampling",
201202
default=False,
202203
tooltip="Whether to perform upsampling on the prompt. If active, automatically modifies the prompt for more creative generation, but results are nondeterministic (same seed will not produce exactly the same result).",
204+
advanced=True,
203205
),
204206
IO.Image.Input(
205207
"input_image",
@@ -296,6 +298,7 @@ def define_schema(cls) -> IO.Schema:
296298
tooltip="Whether to perform upsampling on the prompt. "
297299
"If active, automatically modifies the prompt for more creative generation, "
298300
"but results are nondeterministic (same seed will not produce exactly the same result).",
301+
advanced=True,
299302
),
300303
IO.Int.Input(
301304
"top",
@@ -433,6 +436,7 @@ def define_schema(cls) -> IO.Schema:
433436
tooltip="Whether to perform upsampling on the prompt. "
434437
"If active, automatically modifies the prompt for more creative generation, "
435438
"but results are nondeterministic (same seed will not produce exactly the same result).",
439+
advanced=True,
436440
),
437441
IO.Float.Input(
438442
"guidance",
@@ -577,6 +581,7 @@ def define_schema(cls) -> IO.Schema:
577581
default=True,
578582
tooltip="Whether to perform upsampling on the prompt. "
579583
"If active, automatically modifies the prompt for more creative generation.",
584+
advanced=True,
580585
),
581586
IO.Image.Input("images", optional=True, tooltip="Up to 9 images to be used as references."),
582587
],

‎comfy_api_nodes/nodes_bytedance.py‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ def define_schema(cls):
114114
default=False,
115115
tooltip='Whether to add an "AI generated" watermark to the image',
116116
optional=True,
117+
advanced=True,
117118
),
118119
],
119120
outputs=[
@@ -259,12 +260,14 @@ def define_schema(cls):
259260
default=False,
260261
tooltip='Whether to add an "AI generated" watermark to the image.',
261262
optional=True,
263+
advanced=True,
262264
),
263265
IO.Boolean.Input(
264266
"fail_on_partial",
265267
default=True,
266268
tooltip="If enabled, abort execution if any requested images are missing or return an error.",
267269
optional=True,
270+
advanced=True,
268271
),
269272
],
270273
outputs=[
@@ -432,18 +435,21 @@ def define_schema(cls):
432435
tooltip="Specifies whether to fix the camera. The platform appends an instruction "
433436
"to fix the camera to your prompt, but does not guarantee the actual effect.",
434437
optional=True,
438+
advanced=True,
435439
),
436440
IO.Boolean.Input(
437441
"watermark",
438442
default=False,
439443
tooltip='Whether to add an "AI generated" watermark to the video.',
440444
optional=True,
445+
advanced=True,
441446
),
442447
IO.Boolean.Input(
443448
"generate_audio",
444449
default=False,
445450
tooltip="This parameter is ignored for any model except seedance-1-5-pro.",
446451
optional=True,
452+
advanced=True,
447453
),
448454
],
449455
outputs=[
@@ -561,18 +567,21 @@ def define_schema(cls):
561567
tooltip="Specifies whether to fix the camera. The platform appends an instruction "
562568
"to fix the camera to your prompt, but does not guarantee the actual effect.",
563569
optional=True,
570+
advanced=True,
564571
),
565572
IO.Boolean.Input(
566573
"watermark",
567574
default=False,
568575
tooltip='Whether to add an "AI generated" watermark to the video.',
569576
optional=True,
577+
advanced=True,
570578
),
571579
IO.Boolean.Input(
572580
"generate_audio",
573581
default=False,
574582
tooltip="This parameter is ignored for any model except seedance-1-5-pro.",
575583
optional=True,
584+
advanced=True,
576585
),
577586
],
578587
outputs=[
@@ -694,18 +703,21 @@ def define_schema(cls):
694703
tooltip="Specifies whether to fix the camera. The platform appends an instruction "
695704
"to fix the camera to your prompt, but does not guarantee the actual effect.",
696705
optional=True,
706+
advanced=True,
697707
),
698708
IO.Boolean.Input(
699709
"watermark",
700710
default=False,
701711
tooltip='Whether to add an "AI generated" watermark to the video.',
702712
optional=True,
713+
advanced=True,
703714
),
704715
IO.Boolean.Input(
705716
"generate_audio",
706717
default=False,
707718
tooltip="This parameter is ignored for any model except seedance-1-5-pro.",
708719
optional=True,
720+
advanced=True,
709721
),
710722
],
711723
outputs=[
@@ -834,6 +846,7 @@ def define_schema(cls):
834846
default=False,
835847
tooltip='Whether to add an "AI generated" watermark to the video.',
836848
optional=True,
849+
advanced=True,
837850
),
838851
],
839852
outputs=[

‎comfy_api_nodes/nodes_gemini.py‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,7 @@ def define_schema(cls):
316316
default="",
317317
optional=True,
318318
tooltip="Foundational instructions that dictate an AI's behavior.",
319+
advanced=True,
319320
),
320321
],
321322
outputs=[
@@ -593,13 +594,15 @@ def define_schema(cls):
593594
tooltip="Choose 'IMAGE' for image-only output, or "
594595
"'IMAGE+TEXT' to return both the generated image and a text response.",
595596
optional=True,
597+
advanced=True,
596598
),
597599
IO.String.Input(
598600
"system_prompt",
599601
multiline=True,
600602
default=GEMINI_IMAGE_SYS_PROMPT,
601603
optional=True,
602604
tooltip="Foundational instructions that dictate an AI's behavior.",
605+
advanced=True,
603606
),
604607
],
605608
outputs=[
@@ -714,6 +717,7 @@ def define_schema(cls):
714717
options=["IMAGE+TEXT", "IMAGE"],
715718
tooltip="Choose 'IMAGE' for image-only output, or "
716719
"'IMAGE+TEXT' to return both the generated image and a text response.",
720+
advanced=True,
717721
),
718722
IO.Image.Input(
719723
"images",
@@ -733,6 +737,7 @@ def define_schema(cls):
733737
default=GEMINI_IMAGE_SYS_PROMPT,
734738
optional=True,
735739
tooltip="Foundational instructions that dictate an AI's behavior.",
740+
advanced=True,
736741
),
737742
],
738743
outputs=[

‎comfy_api_nodes/nodes_ideogram.py‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ def define_schema(cls):
261261
default="AUTO",
262262
tooltip="Determine if MagicPrompt should be used in generation",
263263
optional=True,
264+
advanced=True,
264265
),
265266
IO.Int.Input(
266267
"seed",
@@ -394,6 +395,7 @@ def define_schema(cls):
394395
default="AUTO",
395396
tooltip="Determine if MagicPrompt should be used in generation",
396397
optional=True,
398+
advanced=True,
397399
),
398400
IO.Int.Input(
399401
"seed",
@@ -411,6 +413,7 @@ def define_schema(cls):
411413
default="NONE",
412414
tooltip="Style type for generation (V2 only)",
413415
optional=True,
416+
advanced=True,
414417
),
415418
IO.String.Input(
416419
"negative_prompt",
@@ -564,6 +567,7 @@ def define_schema(cls):
564567
default="AUTO",
565568
tooltip="Determine if MagicPrompt should be used in generation",
566569
optional=True,
570+
advanced=True,
567571
),
568572
IO.Int.Input(
569573
"seed",
@@ -590,6 +594,7 @@ def define_schema(cls):
590594
default="DEFAULT",
591595
tooltip="Controls the trade-off between generation speed and quality",
592596
optional=True,
597+
advanced=True,
593598
),
594599
IO.Image.Input(
595600
"character_image",

‎comfy_api_nodes/nodes_kling.py‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2334,6 +2334,7 @@ def define_schema(cls) -> IO.Schema:
23342334
max=2.0,
23352335
display_mode=IO.NumberDisplay.slider,
23362336
tooltip="Speech Rate. Valid range: 0.8~2.0, accurate to one decimal place.",
2337+
advanced=True,
23372338
),
23382339
],
23392340
outputs=[
@@ -2455,6 +2456,7 @@ def define_schema(cls) -> IO.Schema:
24552456
IO.Combo.Input(
24562457
"image_type",
24572458
options=[i.value for i in KlingImageGenImageReferenceType],
2459+
advanced=True,
24582460
),
24592461
IO.Float.Input(
24602462
"image_fidelity",
@@ -2464,6 +2466,7 @@ def define_schema(cls) -> IO.Schema:
24642466
step=0.01,
24652467
display_mode=IO.NumberDisplay.slider,
24662468
tooltip="Reference intensity for user-uploaded images",
2469+
advanced=True,
24672470
),
24682471
IO.Float.Input(
24692472
"human_fidelity",
@@ -2473,6 +2476,7 @@ def define_schema(cls) -> IO.Schema:
24732476
step=0.01,
24742477
display_mode=IO.NumberDisplay.slider,
24752478
tooltip="Subject reference similarity",
2479+
advanced=True,
24762480
),
24772481
IO.Combo.Input("model_name", options=["kling-v3", "kling-v2", "kling-v1-5"]),
24782482
IO.Combo.Input(
@@ -2588,7 +2592,7 @@ def define_schema(cls) -> IO.Schema:
25882592
IO.Combo.Input("mode", options=["pro"]),
25892593
IO.Combo.Input("aspect_ratio", options=["16:9", "9:16", "1:1"]),
25902594
IO.Combo.Input("duration", options=[5, 10]),
2591-
IO.Boolean.Input("generate_audio", default=True),
2595+
IO.Boolean.Input("generate_audio", default=True, advanced=True),
25922596
],
25932597
outputs=[
25942598
IO.Video.Output(),
@@ -2656,7 +2660,7 @@ def define_schema(cls) -> IO.Schema:
26562660
IO.String.Input("prompt", multiline=True, tooltip="Positive text prompt."),
26572661
IO.Combo.Input("mode", options=["pro"]),
26582662
IO.Combo.Input("duration", options=[5, 10]),
2659-
IO.Boolean.Input("generate_audio", default=True),
2663+
IO.Boolean.Input("generate_audio", default=True, advanced=True),
26602664
],
26612665
outputs=[
26622666
IO.Video.Output(),

‎comfy_api_nodes/nodes_ltxv.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ def define_schema(cls):
7474
default=False,
7575
optional=True,
7676
tooltip="When true, the generated video will include AI-generated audio matching the scene.",
77+
advanced=True,
7778
),
7879
],
7980
outputs=[
@@ -151,6 +152,7 @@ def define_schema(cls):
151152
default=False,
152153
optional=True,
153154
tooltip="When true, the generated video will include AI-generated audio matching the scene.",
155+
advanced=True,
154156
),
155157
],
156158
outputs=[

‎comfy_api_nodes/nodes_magnific.py‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,11 +110,13 @@ def define_schema(cls):
110110
IO.Combo.Input(
111111
"engine",
112112
options=["automatic", "magnific_illusio", "magnific_sharpy", "magnific_sparkle"],
113+
advanced=True,
113114
),
114115
IO.Boolean.Input(
115116
"auto_downscale",
116117
default=False,
117118
tooltip="Automatically downscale input image if output would exceed maximum pixel limit.",
119+
advanced=True,
118120
),
119121
],
120122
outputs=[
@@ -280,6 +282,7 @@ def define_schema(cls):
280282
"auto_downscale",
281283
default=False,
282284
tooltip="Automatically downscale input image if output would exceed maximum resolution.",
285+
advanced=True,
283286
),
284287
],
285288
outputs=[
@@ -440,6 +443,7 @@ def define_schema(cls):
440443
"softy",
441444
],
442445
tooltip="Processing engine selection.",
446+
advanced=True,
443447
),
444448
IO.DynamicCombo.Input(
445449
"portrait_mode",
@@ -468,6 +472,7 @@ def define_schema(cls):
468472
default=True,
469473
tooltip="When disabled, expect each generation to introduce a degree of randomness, "
470474
"leading to more diverse outcomes.",
475+
advanced=True,
471476
),
472477
],
473478
outputs=[
@@ -582,16 +587,19 @@ def define_schema(cls):
582587
"interpolate_from_original",
583588
default=False,
584589
tooltip="Restricts generation freedom to match original more closely.",
590+
advanced=True,
585591
),
586592
IO.Boolean.Input(
587593
"change_background",
588594
default=True,
589595
tooltip="Modifies background based on prompt/reference.",
596+
advanced=True,
590597
),
591598
IO.Boolean.Input(
592599
"preserve_details",
593600
default=True,
594601
tooltip="Maintains texture and fine details from original.",
602+
advanced=True,
595603
),
596604
IO.DynamicCombo.Input(
597605
"advanced_settings",

‎comfy_api_nodes/nodes_meshy.py‎

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,12 @@ def define_schema(cls):
5858
],
5959
tooltip="When set to false, returns an unprocessed triangular mesh.",
6060
),
61-
IO.Combo.Input("symmetry_mode", options=["auto", "on", "off"]),
61+
IO.Combo.Input("symmetry_mode", options=["auto", "on", "off"], advanced=True),
6262
IO.Combo.Input(
6363
"pose_mode",
6464
options=["", "A-pose", "T-pose"],
6565
tooltip="Specify the pose mode for the generated model.",
66+
advanced=True,
6667
),
6768
IO.Int.Input(
6869
"seed",
@@ -155,6 +156,7 @@ def define_schema(cls):
155156
tooltip="Generate PBR Maps (metallic, roughness, normal) in addition to the base color. "
156157
"Note: this should be set to false when using Sculpture style, "
157158
"as Sculpture style generates its own set of PBR maps.",
159+
advanced=True,
158160
),
159161
IO.String.Input(
160162
"texture_prompt",
@@ -299,6 +301,7 @@ def define_schema(cls):
299301
"pose_mode",
300302
options=["", "A-pose", "T-pose"],
301303
tooltip="Specify the pose mode for the generated model.",
304+
advanced=True,
302305
),
303306
IO.Int.Input(
304307
"seed",
@@ -429,7 +432,7 @@ def define_schema(cls):
429432
],
430433
tooltip="When set to false, returns an unprocessed triangular mesh.",
431434
),
432-
IO.Combo.Input("symmetry_mode", options=["auto", "on", "off"]),
435+
IO.Combo.Input("symmetry_mode", options=["auto", "on", "off"], advanced=True),
433436
IO.DynamicCombo.Input(
434437
"should_texture",
435438
options=[
@@ -466,6 +469,7 @@ def define_schema(cls):
466469
"pose_mode",
467470
options=["", "A-pose", "T-pose"],
468471
tooltip="Specify the pose mode for the generated model.",
472+
advanced=True,
469473
),
470474
IO.Int.Input(
471475
"seed",
@@ -728,8 +732,9 @@ def define_schema(cls):
728732
tooltip="Use the original UV of the model instead of generating new UVs. "
729733
"When enabled, Meshy preserves existing textures from the uploaded model. "
730734
"If the model has no original UV, the quality of the output might not be as good.",
735+
advanced=True,
731736
),
732-
IO.Boolean.Input("pbr", default=False),
737+
IO.Boolean.Input("pbr", default=False, advanced=True),
733738
IO.String.Input(
734739
"text_style_prompt",
735740
default="",

0 commit comments

Comments
 (0)