Skip to content

Commit 0497421

Browse files
add aria labels on vue node widgets (#6032)
## Summary Adds aria labels to buttons and widgets without pre-existing text labels. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6032-add-aria-labels-on-vue-node-widgets-28a6d73d36508198a1c0ef7098ad24e8) by [Unito](https://www.unito.io)
1 parent 01b4ad0 commit 0497421

File tree

12 files changed

+31
-2
lines changed

12 files changed

+31
-2
lines changed

src/locales/en/main.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,14 @@
99
"downloadImage": "Download image",
1010
"downloadVideo": "Download video",
1111
"editOrMaskImage": "Edit or mask image",
12+
"editImage": "Edit image",
13+
"deleteImage": "Delete image",
14+
"deleteAudioFile": "Delete audio file",
1215
"removeImage": "Remove image",
1316
"removeVideo": "Remove video",
17+
"chart": "Chart",
18+
"chartLowercase": "chart",
19+
"file": "file",
1420
"viewImageOfTotal": "View image {index} of {total}",
1521
"viewVideoOfTotal": "View video {index} of {total}",
1622
"imagePreview": "Image preview - Use arrow keys to navigate between images",

src/renderer/extensions/vueNodes/widgets/components/WidgetButton.vue

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
<label v-if="widget.name" class="text-sm opacity-80">{{
44
widget.name
55
}}</label>
6-
<Button v-bind="filteredProps" size="small" @click="handleClick" />
6+
<Button
7+
v-bind="filteredProps"
8+
:aria-label="widget.name || widget.label"
9+
size="small"
10+
@click="handleClick"
11+
/>
712
</div>
813
</template>
914

src/renderer/extensions/vueNodes/widgets/components/WidgetChart.vue

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,12 @@
33
<div
44
class="max-h-[48rem] rounded border border-gray-300 p-4 dark-theme:border-gray-600"
55
>
6-
<Chart :type="chartType" :data="chartData" :options="chartOptions" />
6+
<Chart
7+
:type="chartType"
8+
:data="chartData"
9+
:options="chartOptions"
10+
:aria-label="`${widget.name || $t('g.chart')} - ${chartType} ${$t('g.chartLowercase')}`"
11+
/>
712
</div>
813
</div>
914
</template>

src/renderer/extensions/vueNodes/widgets/components/WidgetColorPicker.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
v-model="localValue"
1111
v-bind="filteredProps"
1212
class="h-4 w-8 overflow-hidden !rounded-full border-none"
13+
:aria-label="widget.name"
1314
:pt="{
1415
preview: '!w-full !h-full !border-none'
1516
}"

src/renderer/extensions/vueNodes/widgets/components/WidgetFileUpload.vue

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
>
5151
<!-- Edit button -->
5252
<button
53+
:aria-label="$t('g.editImage')"
5354
class="flex h-6 w-6 items-center justify-center rounded border-none transition-all duration-150 focus:outline-none"
5455
style="background-color: #262729"
5556
@click="handleEdit"
@@ -58,6 +59,7 @@
5859
</button>
5960
<!-- Delete button -->
6061
<button
62+
:aria-label="$t('g.deleteImage')"
6163
class="flex h-6 w-6 items-center justify-center rounded border-none transition-all duration-150 focus:outline-none"
6264
style="background-color: #262729"
6365
@click="clearFile"
@@ -128,6 +130,7 @@
128130
<div class="flex gap-1">
129131
<!-- Delete button -->
130132
<button
133+
:aria-label="$t('g.deleteAudioFile')"
131134
class="flex h-8 w-8 items-center justify-center rounded border-none transition-all duration-150 hover:bg-[#262729] focus:outline-none"
132135
@click="clearFile"
133136
>
@@ -168,6 +171,7 @@
168171
type="file"
169172
class="hidden"
170173
:accept="widget.options?.accept"
174+
:aria-label="`${$t('g.upload')} ${widget.name || $t('g.file')}`"
171175
:multiple="false"
172176
@change="handleFileChange"
173177
/>

src/renderer/extensions/vueNodes/widgets/components/WidgetInputNumberSlider.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
v-bind="filteredProps"
1111
class="flex-grow text-xs"
1212
:step="stepValue"
13+
:aria-label="widget.name"
1314
@update:model-value="updateLocalValue"
1415
/>
1516
<InputNumber
@@ -19,6 +20,7 @@
1920
:step="stepValue"
2021
:min-fraction-digits="precision"
2122
:max-fraction-digits="precision"
23+
:aria-label="widget.name"
2224
size="small"
2325
pt:pc-input-text:root="min-w-full bg-transparent border-none text-center"
2426
class="w-16"

src/renderer/extensions/vueNodes/widgets/components/WidgetInputText.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
v-model="localValue"
55
v-bind="filteredProps"
66
:class="cn(WidgetInputBaseClass, 'w-full text-xs py-2 px-4')"
7+
:aria-label="widget.name"
78
size="small"
89
@update:model-value="onChange"
910
/>

src/renderer/extensions/vueNodes/widgets/components/WidgetMultiSelect.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
:options="multiSelectOptions"
66
v-bind="combinedProps"
77
class="w-full text-xs"
8+
:aria-label="widget.name"
89
size="small"
910
display="chip"
1011
:pt="{

src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
:options="selectOptions"
66
v-bind="combinedProps"
77
:class="cn(WidgetInputBaseClass, 'w-full text-xs')"
8+
:aria-label="widget.name"
89
size="small"
910
:pt="{
1011
option: 'text-xs'

src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
v-bind="filteredProps"
66
:class="cn(WidgetInputBaseClass, 'w-full text-xs lod-toggle')"
77
:placeholder="placeholder || widget.name || ''"
8+
:aria-label="widget.name"
89
size="small"
910
rows="3"
1011
data-capture-wheel="true"

0 commit comments

Comments
 (0)