fix: cache promoted widget views, use standard prototype, revert nav test

- Cache _getPromotedViews result for reference stability (widgets getter)
- Replace Object.create(null) with {} for standard Object prototype
- Revert navigateIntoSubgraph to dblclick approach (title button click fails in CI)

Amp-Thread-ID: https://ampcode.com/threads/T-019c59d8-632b-750c-a1a2-93920c89f63e
Co-authored-by: Amp <amp@ampcode.com>

Author: DrJKL

browser_tests/fixtures/utils/litegraphUtils.ts

@@ -458,13 +458,15 @@ export class NodeReference {
     const nodePos = await this.getPosition()
     const nodeSize = await this.getSize()
 
-    // Click the enter_subgraph title button (top-right of title bar).
-    // This is more reliable than dblclick on the node body because
-    // promoted DOM widgets can overlay the body and intercept events.
-    const buttonPos = {
-      x: nodePos.x + nodeSize.width - 15,
-      y: nodePos.y - titleHeight / 2
-    }
+    // Try multiple positions to avoid DOM widget interference
+    const clickPositions = [
+      { x: nodePos.x + nodeSize.width / 2, y: nodePos.y + titleHeight + 5 },
+      {
+        x: nodePos.x + nodeSize.width / 2,
+        y: nodePos.y + nodeSize.height / 2
+      },
+      { x: nodePos.x + 20, y: nodePos.y + titleHeight + 5 }
+    ]
 
     const checkIsInSubgraph = async () => {
       return this.comfyPage.page.evaluate(() => {
@@ -474,13 +476,20 @@ export class NodeReference {
     }
 
     await expect(async () => {
-      await this.comfyPage.canvas.click({
-        position: buttonPos,
-        force: true
-      })
-      await this.comfyPage.nextFrame()
-
-      if (await checkIsInSubgraph()) return
+      for (const position of clickPositions) {
+        // Clear any selection first
+        await this.comfyPage.canvas.click({
+          position: { x: 250, y: 250 },
+          force: true
+        })
+        await this.comfyPage.nextFrame()
+
+        // Double-click to enter subgraph
+        await this.comfyPage.canvas.dblclick({ position, force: true })
+        await this.comfyPage.nextFrame()
+
+        if (await checkIsInSubgraph()) return
+      }
       throw new Error('Not in subgraph yet')
     }).toPass({ timeout: 5000, intervals: [100, 200, 500] })
   }

src/core/graph/subgraph/promotedWidgetView.ts

@@ -36,7 +36,7 @@ export function createPromotedWidgetView(
 ): PromotedWidgetView {
   const bareNodeId = stripGraphPrefix(nodeId as NodeId)
 
-  const view: PromotedWidgetView = Object.create(null)
+  const view = {} as PromotedWidgetView
 
   // Identity — own data properties
   Object.defineProperties(view, {

src/lib/litegraph/src/subgraph/SubgraphNode.ts

@@ -69,6 +69,8 @@ export class SubgraphNode extends LGraphNode implements BaseLGraph {
   private _viewCache = new Map<string, PromotedWidgetView>()
   private _proxyWidgetsRaw?: unknown
   private _promotionList: Array<[string, string]> = []
+  private _viewsCached: PromotedWidgetView[] = []
+  private _viewsCacheDirty = true
 
   // Declared as accessor via Object.defineProperty in constructor.
   // TypeScript doesn't allow overriding a property with get/set syntax,
@@ -80,17 +82,21 @@ export class SubgraphNode extends LGraphNode implements BaseLGraph {
     if (raw === undefined || raw === null) {
       this._proxyWidgetsRaw = raw
       this._promotionList = []
+      this._viewsCacheDirty = true
       return this._promotionList
     }
     if (raw !== this._proxyWidgetsRaw) {
       this._proxyWidgetsRaw = raw
       this._promotionList = parseProxyWidgets(raw)
+      this._viewsCacheDirty = true
     }
     return this._promotionList
   }
 
   private _getPromotedViews(): PromotedWidgetView[] {
     const list = this._getPromotionList()
+    if (!this._viewsCacheDirty) return this._viewsCached
+
     const views: PromotedWidgetView[] = []
     const seenKeys = new Set<string>()
     let hadLegacyEntries = false
@@ -133,6 +139,8 @@ export class SubgraphNode extends LGraphNode implements BaseLGraph {
       this._promotionList = resolved
     }
 
+    this._viewsCached = views
+    this._viewsCacheDirty = false
     return views
   }