Skip to content

Commit 08fe282

Browse files
authored
feat: node border and hover and selected style, and when error (#5491)
* feat: node border and hover and selected style, and when error * fix test error
1 parent e70ddea commit 08fe282

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

src/renderer/extensions/vueNodes/components/LGraphNode.vue

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,19 @@
99
cn(
1010
'bg-white dark-theme:bg-charcoal-100',
1111
'min-w-[445px]',
12-
'lg-node absolute border border-solid rounded-2xl',
13-
'outline-transparent outline-2',
12+
'lg-node absolute rounded-2xl',
13+
// border
14+
'border border-solid border-sand-100 dark-theme:border-charcoal-300',
15+
!!error && 'border-red-700 dark-theme:border-red-300',
16+
// hover
17+
'hover:ring-7 ring-gray-500/50 dark-theme:ring-gray-500/20',
18+
// Selected
19+
'outline-transparent -outline-offset-2 outline-2',
20+
!!isSelected && 'outline-black dark-theme:outline-white',
21+
!!(isSelected && error) && 'outline-red-500 dark-theme:outline-red-500',
1422
{
15-
'outline-black dark-theme:outline-white': isSelected
16-
},
17-
{
18-
'border-blue-500 ring-2 ring-blue-300': isSelected,
19-
'border-sand-100 dark-theme:border-charcoal-300': !isSelected,
2023
'animate-pulse': executing,
2124
'opacity-50': nodeData.mode === 4,
22-
'border-red-500 bg-red-50': error,
2325
'will-change-transform': isDragging
2426
},
2527
lodCssClass,
@@ -229,7 +231,7 @@ const hasCustomContent = computed(() => {
229231
230232
// Computed classes and conditions for better reusability
231233
const separatorClasses =
232-
'bg-sand-primary dark-theme:bg-charcoal-tertiary h-[1px] mx-0'
234+
'bg-sand-100 dark-theme:bg-charcoal-300 h-[1px] mx-0 w-full'
233235
234236
// Common condition computations to avoid repetition
235237
const shouldShowWidgets = computed(

tests-ui/tests/renderer/extensions/vueNodes/components/LGraphNode.spec.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,9 @@ describe('LGraphNode', () => {
9292
{ nodeData: mockNodeData, selected: true },
9393
new Set(['test-node-123'])
9494
)
95-
96-
expect(wrapper.classes()).toContain('border-blue-500')
97-
expect(wrapper.classes()).toContain('ring-2')
98-
expect(wrapper.classes()).toContain('ring-blue-300')
95+
expect(wrapper.classes()).toContain('outline-2')
96+
expect(wrapper.classes()).toContain('outline-black')
97+
expect(wrapper.classes()).toContain('dark-theme:outline-white')
9998
})
10099

101100
it('should apply executing animation when executing prop is true', () => {

0 commit comments

Comments
 (0)