Skip to content

Commit 0c0e0f8

Browse files
fix: address PR review comments - revert shorthand CSS properties
- Remove `declaration-block-no-redundant-longhand-properties` stylelint rule to avoid browser compatibility issues with modern CSS shorthands - Revert `flex-flow` and `place-content` back to longhand properties in NodePreview.vue for better browser support - Revert `inset: 0` back to longhand `top/left/right/bottom` in TreeExplorer.vue for browser compatibility - Update knip.config.ts CSS compiler to properly handle `url()` wrappers in @import statements
1 parent cc44118 commit 0c0e0f8

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

.stylelintrc.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"rules": {
1010
"import-notation": "string",
1111
"font-family-no-missing-generic-family-keyword": true,
12-
"declaration-block-no-redundant-longhand-properties": true,
1312
"declaration-property-value-no-unknown": [
1413
true,
1514
{

knip.config.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ const config: KnipConfig = {
4444
compilers: {
4545
// https://github.com/webpro-nl/knip/issues/1008#issuecomment-3207756199
4646
css: (text: string) =>
47-
[
48-
...text.replaceAll('plugin', 'import').matchAll(/(?<=@)import[^;]+/g)
49-
].join('\n')
47+
[...text.replaceAll('plugin', 'import').matchAll(/(?<=@)import[^;]+/g)]
48+
.map((match) => match[0].replace(/url\(['"]?([^'"()]+)['"]?\)/, '$1'))
49+
.join('\n')
5050
},
5151
vite: {
5252
config: ['vite?(.*).config.mts']

src/components/common/TreeExplorer.vue

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,10 @@ defineExpose({
263263
:deep(.p-tree-node-content:has(.tree-folder.can-drop))::after {
264264
content: '';
265265
position: absolute;
266-
inset: 0;
266+
top: 0;
267+
left: 0;
268+
right: 0;
269+
bottom: 0;
267270
border: 1px solid var(--p-content-color);
268271
pointer-events: none;
269272
}

src/components/node/NodePreview.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,8 +251,10 @@ const truncateDefaultValue = (value: any, charLimit: number = 32): string => {
251251
border: 0 solid #000;
252252
display: flex;
253253
align-items: flex-end;
254-
flex-flow: row-reverse nowrap;
255-
place-content: flex-start flex-end;
254+
flex-direction: row-reverse;
255+
flex-wrap: nowrap;
256+
align-content: flex-start;
257+
justify-content: flex-end;
256258
}
257259
258260
._sb_inherit {

0 commit comments

Comments
 (0)