fix: avoid redundant checkout attribution persistence

Author: benceruleanlu

src/platform/telemetry/types.ts

@@ -281,12 +281,7 @@ export interface PageViewMetadata {
   [key: string]: unknown
 }
 
-export interface BeginCheckoutMetadata extends Record<string, unknown> {
-  user_id: string
-  tier: TierKey
-  cycle: BillingCycle
-  checkout_type: 'new' | 'change'
-  previous_tier?: TierKey
+export interface CheckoutAttributionMetadata {
   ga_client_id?: string
   ga_session_id?: string
   ga_session_number?: string
@@ -302,6 +297,15 @@ export interface BeginCheckoutMetadata extends Record<string, unknown> {
   wbraid?: string
 }
 
+export interface BeginCheckoutMetadata
+  extends Record<string, unknown>, CheckoutAttributionMetadata {
+  user_id: string
+  tier: TierKey
+  cycle: BillingCycle
+  checkout_type: 'new' | 'change'
+  previous_tier?: TierKey
+}
+
 /**
  * Telemetry provider interface for individual providers.
  * All methods are optional - providers only implement what they need.

src/platform/telemetry/utils/__tests__/checkoutAttribution.test.ts

@@ -104,4 +104,32 @@ describe('getCheckoutAttribution', () => {
       im_ref: 'impact-789'
     })
   })
+
+  it('does not persist when explicit search attribution matches stored values', () => {
+    storage.set(
+      'comfy_checkout_attribution',
+      JSON.stringify({ utm_source: 'impact', im_ref: 'impact-789' })
+    )
+
+    captureCheckoutAttributionFromSearch('?utm_source=impact&im_ref=impact-789')
+
+    expect(mockLocalStorage.setItem).not.toHaveBeenCalled()
+  })
+
+  it('does not persist from URL when query attribution matches stored values', () => {
+    storage.set(
+      'comfy_checkout_attribution',
+      JSON.stringify({ gclid: 'gclid-123', im_ref: 'impact-abc' })
+    )
+    window.history.pushState({}, '', '/?gclid=gclid-123&im_ref=impact-abc')
+
+    const attribution = getCheckoutAttribution()
+
+    expect(attribution).toMatchObject({
+      gclid: 'gclid-123',
+      im_ref: 'impact-abc',
+      impact_click_id: 'impact-abc'
+    })
+    expect(mockLocalStorage.setItem).not.toHaveBeenCalled()
+  })
 })

src/platform/telemetry/utils/checkoutAttribution.ts

@@ -1,20 +1,8 @@
 import { isPlainObject } from 'es-toolkit'
 
-interface CheckoutAttribution {
-  ga_client_id?: string
-  ga_session_id?: string
-  ga_session_number?: string
-  im_ref?: string
-  impact_click_id?: string
-  utm_source?: string
-  utm_medium?: string
-  utm_campaign?: string
-  utm_term?: string
-  utm_content?: string
-  gclid?: string
-  gbraid?: string
-  wbraid?: string
-}
+import type { CheckoutAttributionMetadata } from '../types'
+
+type CheckoutAttribution = CheckoutAttributionMetadata
 
 type GaIdentity = {
   client_id?: string
@@ -68,6 +56,20 @@ function persistAttribution(
   }
 }
 
+function hasAttributionChanges(
+  existing: Partial<Record<AttributionQueryKey, string>>,
+  incoming: Partial<Record<AttributionQueryKey, string>>
+): boolean {
+  for (const key of ATTRIBUTION_QUERY_KEYS) {
+    const value = incoming[key]
+    if (value !== undefined && existing[key] !== value) {
+      return true
+    }
+  }
+
+  return false
+}
+
 function readAttributionFromUrl(
   search: string
 ): Partial<Record<AttributionQueryKey, string>> {
@@ -106,6 +108,7 @@ export function captureCheckoutAttributionFromSearch(search: string): void {
   const stored = readStoredAttribution()
   const fromSearch = readAttributionFromUrl(search)
   if (Object.keys(fromSearch).length === 0) return
+  if (!hasAttributionChanges(stored, fromSearch)) return
 
   persistAttribution({
     ...stored,
@@ -123,7 +126,10 @@ export function getCheckoutAttribution(): CheckoutAttribution {
     ...fromUrl
   }
 
-  if (Object.keys(fromUrl).length > 0) {
+  if (
+    Object.keys(fromUrl).length > 0 &&
+    hasAttributionChanges(stored, fromUrl)
+  ) {
     persistAttribution(merged)
   }