Skip to content

Commit 1dc386a

Browse files
christian-byrneclaude
christian-byrne
and
claude
committed
feat: Complete manager migration cleanup and integration
- Remove outdated legacy manager detection from LoadWorkflowWarning - Update InfoPanelHeader with conflict detection improvements - Fix all failing unit tests from state management transition - Clean up algolia search provider type mappings - Remove unused @ts-expect-error directives 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 2c5b6da commit 1dc386a

27 files changed

+150172
-62
lines changed

‎.nx/cache/run.json‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"run": {
3+
"command": "nx serve",
4+
"startTime": "2025-09-01T19:16:09.362Z",
5+
"endTime": "2025-09-01T19:19:52.329Z",
6+
"inner": false
7+
},
8+
"tasks": []
9+
}

‎.nx/cache/terminalOutputs/15473051516218995888‎

Lines changed: 2943 additions & 0 deletions
Large diffs are not rendered by default.

‎.nx/cache/terminalOutputs/18409600201984416432‎

Lines changed: 772 additions & 0 deletions
Large diffs are not rendered by default.

‎.nx/cache/terminalOutputs/265737970939451950‎

Lines changed: 140 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,140 @@
1+
> vitest tests-ui/tests/stores/managerStateStore.test.ts
2+
3+
4+
 RUN  v3.2.4 /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone
5+
6+
stdout | tests-ui/tests/stores/managerStateStore.test.ts > useManagerStateStore > managerUIState computed > should return DISABLED state when --disable-manager is present
7+
[Manager State Debug] {
8+
systemStats: [ 'python', 'main.py', '--disable-manager' ],
9+
clientSupportsV4: false,
10+
serverSupportsV4: false,
11+
hasLegacyManager: false,
12+
extensions: []
13+
}
14+
[Manager State Debug] {
15+
systemStats: [ 'python', 'main.py', '--disable-manager' ],
16+
clientSupportsV4: false,
17+
serverSupportsV4: false,
18+
hasLegacyManager: false,
19+
extensions: []
20+
}
21+
22+
stdout | tests-ui/tests/stores/managerStateStore.test.ts > useManagerStateStore > managerUIState computed > should return LEGACY_UI state when --enable-manager-legacy-ui is present
23+
[Manager State Debug] {
24+
systemStats: [ 'python', 'main.py', '--enable-manager-legacy-ui' ],
25+
clientSupportsV4: false,
26+
serverSupportsV4: false,
27+
hasLegacyManager: false,
28+
extensions: []
29+
}
30+
[Manager State Debug] {
31+
systemStats: [ 'python', 'main.py', '--enable-manager-legacy-ui' ],
32+
clientSupportsV4: false,
33+
serverSupportsV4: false,
34+
hasLegacyManager: false,
35+
extensions: []
36+
}
37+
38+
stdout | tests-ui/tests/stores/managerStateStore.test.ts > useManagerStateStore > managerUIState computed > should return NEW_UI state when client and server both support v4
39+
[Manager State Debug] {
40+
systemStats: [ 'python', 'main.py' ],
41+
clientSupportsV4: true,
42+
serverSupportsV4: true,
43+
hasLegacyManager: false,
44+
extensions: []
45+
}
46+
[Manager State Debug] {
47+
systemStats: [ 'python', 'main.py' ],
48+
clientSupportsV4: true,
49+
serverSupportsV4: true,
50+
hasLegacyManager: false,
51+
extensions: []
52+
}
53+
54+
stdout | tests-ui/tests/stores/managerStateStore.test.ts > useManagerStateStore > managerUIState computed > should return LEGACY_UI state when server supports v4 but client does not
55+
[Manager State Debug] {
56+
systemStats: [ 'python', 'main.py' ],
57+
clientSupportsV4: false,
58+
serverSupportsV4: true,
59+
hasLegacyManager: false,
60+
extensions: []
61+
}
62+
[Manager State Debug] {
63+
systemStats: [ 'python', 'main.py' ],
64+
clientSupportsV4: false,
65+
serverSupportsV4: true,
66+
hasLegacyManager: false,
67+
extensions: []
68+
}
69+
70+
stdout | tests-ui/tests/stores/managerStateStore.test.ts > useManagerStateStore > managerUIState computed > should return LEGACY_UI state when legacy manager extension exists
71+
[Manager State Debug] {
72+
systemStats: [ 'python', 'main.py' ],
73+
clientSupportsV4: false,
74+
serverSupportsV4: false,
75+
hasLegacyManager: true,
76+
extensions: [ 'Comfy.CustomNodesManager' ]
77+
}
78+
[Manager State Debug] {
79+
systemStats: [ 'python', 'main.py' ],
80+
clientSupportsV4: false,
81+
serverSupportsV4: false,
82+
hasLegacyManager: true,
83+
extensions: [ 'Comfy.CustomNodesManager' ]
84+
}
85+
86+
stdout | tests-ui/tests/stores/managerStateStore.test.ts > useManagerStateStore > managerUIState computed > should return DISABLED state when feature flags are undefined
87+
[Manager State Debug] {
88+
systemStats: [ 'python', 'main.py' ],
89+
clientSupportsV4: false,
90+
serverSupportsV4: undefined,
91+
hasLegacyManager: false,
92+
extensions: []
93+
}
94+
[Manager State Debug] {
95+
systemStats: [ 'python', 'main.py' ],
96+
clientSupportsV4: false,
97+
serverSupportsV4: undefined,
98+
hasLegacyManager: false,
99+
extensions: []
100+
}
101+
102+
stdout | tests-ui/tests/stores/managerStateStore.test.ts > useManagerStateStore > managerUIState computed > should return DISABLED state when no manager is available
103+
[Manager State Debug] {
104+
systemStats: [ 'python', 'main.py' ],
105+
clientSupportsV4: false,
106+
serverSupportsV4: false,
107+
hasLegacyManager: false,
108+
extensions: []
109+
}
110+
[Manager State Debug] {
111+
systemStats: [ 'python', 'main.py' ],
112+
clientSupportsV4: false,
113+
serverSupportsV4: false,
114+
hasLegacyManager: false,
115+
extensions: []
116+
}
117+
118+
stdout | tests-ui/tests/stores/managerStateStore.test.ts > useManagerStateStore > managerUIState computed > should handle null systemStats gracefully
119+
[Manager State Debug] {
120+
systemStats: undefined,
121+
clientSupportsV4: true,
122+
serverSupportsV4: true,
123+
hasLegacyManager: false,
124+
extensions: []
125+
}
126+
[Manager State Debug] {
127+
systemStats: undefined,
128+
clientSupportsV4: true,
129+
serverSupportsV4: true,
130+
hasLegacyManager: false,
131+
extensions: []
132+
}
133+
134+
✓ tests-ui/tests/stores/managerStateStore.test.ts (8 tests) 8ms
135+
136+
 Test Files  1 passed (1)
137+
 Tests  8 passed (8)
138+
 Start at  12:06:38
139+
 Duration  415ms (transform 32ms, setup 40ms, collect 30ms, tests 8ms, environment 115ms, prepare 31ms)
140+

‎.nx/cache/terminalOutputs/2797543614505234256‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
> vitest tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts
2+
3+
4+
 RUN  v3.2.4 /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone
5+
6+
stdout | tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts
7+
Running on localhost:3000
8+
9+
✓ tests-ui/tests/components/dialog/footer/ManagerProgressFooter.test.ts (10 tests) 66ms
10+
11+
 Test Files  1 passed (1)
12+
 Tests  10 passed (10)
13+
 Start at  11:57:11
14+
 Duration  3.41s (transform 2.03s, setup 29ms, collect 2.97s, tests 66ms, environment 112ms, prepare 29ms)
15+

‎.nx/cache/terminalOutputs/3384334817798432998‎

Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
> vite
2+
3+
4+
5+
6+
7+
8+
9+
10+
11+
12+
13+
14+
15+
16+
17+
18+
19+
20+
21+
22+
23+
24+
25+
26+
27+
28+
29+
30+
31+
32+

33+
VITE v5.4.19 ready in 351 ms
34+
35+
➜ Local: http://localhost:5173/
36+
➜ Network: http://192.168.8.247:5173/
37+
➜ Network: http://192.168.8.210:5173/
38+
➜ Vue DevTools: Open http://localhost:5173/__devtools__/ as a separate window
39+
➜ Vue DevTools: Press Alt(⌥)+Shift(⇧)+D in App to toggle the Vue DevTools
40+
 ➜ press h + enter to show help
41+
42+
 WARN  [ImportMap Plugin] No vendor chunks found to create import map.
43+
44+
45+
 WARN  [ImportMap Plugin] No vendor chunks found to create import map.
46+
47+
48+
 WARN  [ImportMap Plugin] No vendor chunks found to create import map.
49+
50+
51+
52+
53+
54+
55+
56+
57+
58+
59+
60+
61+
62+
63+
64+
65+
66+
67+
68+
69+
70+
71+
72+
73+
74+
75+
76+
77+
78+
79+
12:17:43 PM [vite] hmr update /src/components/dialog/content/manager/PackVersionSelectorPopover.vue, /src/assets/css/style.css
80+
^C

‎.nx/cache/terminalOutputs/3525738780847089296‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
> vitest tests-ui/tests/services/algoliaSearchProvider.test.ts
2+
3+
4+
 RUN  v3.2.4 /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone
5+
6+
✓ tests-ui/tests/services/algoliaSearchProvider.test.ts (10 tests) 10ms
7+
8+
 Test Files  1 passed (1)
9+
 Tests  10 passed (10)
10+
 Start at  12:13:49
11+
 Duration  505ms (transform 63ms, setup 30ms, collect 111ms, tests 10ms, environment 121ms, prepare 31ms)
12+

‎.nx/cache/terminalOutputs/3926257920216342604‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
> vitest tests-ui/tests/composables/widgets/useManagerQueue.test.ts
2+
3+
4+
 RUN  v3.2.4 /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone
5+
6+
✓ tests-ui/tests/composables/widgets/useManagerQueue.test.ts (9 tests) 5ms
7+
8+
 Test Files  1 passed (1)
9+
 Tests  9 passed (9)
10+
 Start at  12:09:44
11+
 Duration  438ms (transform 38ms, setup 33ms, collect 49ms, tests 5ms, environment 117ms, prepare 30ms)
12+

0 commit comments

Comments
 (0)