[fix] use getter functions for sidebar tab command labels to resolve i18n collection issues (#4370)

Co-authored-by: github-actions <[email protected]>

Author: christian-byrne

scripts/check-unused-i18n-keys.ts

@@ -17,7 +17,15 @@ const IGNORE_PATTERNS = [
   /^templateWorkflows\./, // Template workflows are loaded dynamically
   /^dataTypes\./, // Data types might be referenced dynamically
   /^contextMenu\./, // Context menu items might be dynamic
-  /^color\./ // Color names might be used dynamically
+  /^color\./, // Color names might be used dynamically
+  // Auto-generated categories from collect-i18n-general.ts
+  /^menuLabels\./, // Menu labels generated from command labels
+  /^settingsCategories\./, // Settings categories generated from setting definitions
+  /^serverConfigItems\./, // Server config items generated from SERVER_CONFIG_ITEMS
+  /^serverConfigCategories\./, // Server config categories generated from config categories
+  /^nodeCategories\./, // Node categories generated from node definitions
+  // Setting option values that are dynamically generated
+  /\.options\./ // All setting options are rendered dynamically
 ]
 
 // Get list of staged locale files
@@ -97,17 +105,21 @@ function shouldIgnoreKey(key: string): boolean {
 
 // Search for key usage in source files
 function isKeyUsed(key: string, sourceFiles: string[]): boolean {
+  // Escape special regex characters
+  const escapeRegex = (str: string) =>
+    str.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
+  const escapedKey = escapeRegex(key)
+  const lastPart = key.split('.').pop()
+  const escapedLastPart = lastPart ? escapeRegex(lastPart) : ''
+
   // Common patterns for i18n key usage
   const patterns = [
     // Direct usage: $t('key'), t('key'), i18n.t('key')
-    new RegExp(`[t$]\\s*\\(\\s*['"\`]${key}['"\`]`, 'g'),
+    new RegExp(`[t$]\\s*\\(\\s*['"\`]${escapedKey}['"\`]`, 'g'),
     // With namespace: $t('g.key'), t('namespace.key')
-    new RegExp(
-      `[t$]\\s*\\(\\s*['"\`][^'"]+\\.${key.split('.').pop()}['"\`]`,
-      'g'
-    ),
+    new RegExp(`[t$]\\s*\\(\\s*['"\`][^'"]+\\.${escapedLastPart}['"\`]`, 'g'),
     // Dynamic keys might reference parts of the key
-    new RegExp(`['"\`]${key}['"\`]`, 'g')
+    new RegExp(`['"\`]${escapedKey}['"\`]`, 'g')
   ]
 
   for (const file of sourceFiles) {

src/locales/en/main.json

@@ -949,7 +949,8 @@
     "Light": "Light",
     "User": "User",
     "Credits": "Credits",
-    "API Nodes": "API Nodes"
+    "API Nodes": "API Nodes",
+    "Notification Preferences": "Notification Preferences"
   },
   "serverConfigItems": {
     "listen": {

src/locales/en/settings.json

@@ -263,6 +263,10 @@
     "name": "Number of nodes suggestions",
     "tooltip": "Only for litegraph searchbox/context menu"
   },
+  "Comfy_Notification_ShowVersionUpdates": {
+    "name": "Show version updates",
+    "tooltip": "Show updates for new models, and major new features."
+  },
   "Comfy_Pointer_ClickBufferTime": {
     "name": "Pointer click drift delay",
     "tooltip": "After pressing a pointer button down, this is the maximum time (in milliseconds) that pointer movement can be ignored for.\n\nHelps prevent objects from being unintentionally nudged if the pointer is moved whilst clicking."

src/locales/es/main.json

@@ -785,13 +785,13 @@
     "Toggle Bottom Panel": "Alternar panel inferior",
     "Toggle Focus Mode": "Alternar modo de enfoque",
     "Toggle Logs Bottom Panel": "Alternar panel inferior de registros",
-    "Toggle Model Library Sidebar": "Alternar barra lateral de biblioteca de modelos",
-    "Toggle Node Library Sidebar": "Alternar barra lateral de biblioteca de nodos",
-    "Toggle Queue Sidebar": "Alternar barra lateral de cola",
+    "Toggle Model Library Sidebar": "Alternar barra lateral de la biblioteca de modelos",
+    "Toggle Node Library Sidebar": "Alternar barra lateral de la biblioteca de nodos",
+    "Toggle Queue Sidebar": "Alternar barra lateral de la cola",
     "Toggle Search Box": "Alternar caja de búsqueda",
     "Toggle Terminal Bottom Panel": "Alternar panel inferior de terminal",
     "Toggle Theme (Dark/Light)": "Alternar tema (Oscuro/Claro)",
-    "Toggle Workflows Sidebar": "Alternar barra lateral de flujos de trabajo",
+    "Toggle Workflows Sidebar": "Alternar barra lateral de los flujos de trabajo",
     "Toggle the Custom Nodes Manager": "Alternar el Administrador de Nodos Personalizados",
     "Toggle the Custom Nodes Manager Progress Bar": "Alternar la Barra de Progreso del Administrador de Nodos Personalizados",
     "Undo": "Deshacer",
@@ -1099,6 +1099,7 @@
     "Node Search Box": "Caja de Búsqueda de Nodo",
     "Node Widget": "Widget de Nodo",
     "NodeLibrary": "Biblioteca de Nodos",
+    "Notification Preferences": "Preferencias de notificación",
     "Pointer": "Puntero",
     "Queue": "Cola",
     "QueueButton": "Botón de Cola",

src/locales/es/settings.json

@@ -259,6 +259,10 @@
     "name": "Destacar nodo de ajuste",
     "tooltip": "Al arrastrar un enlace sobre un nodo con ranura de entrada viable, resalta el nodo"
   },
+  "Comfy_Notification_ShowVersionUpdates": {
+    "name": "Mostrar actualizaciones de versión",
+    "tooltip": "Mostrar actualizaciones para nuevos modelos y funciones principales nuevas."
+  },
   "Comfy_Pointer_ClickBufferTime": {
     "name": "Retraso de deriva del clic del puntero",
     "tooltip": "Después de presionar un botón del puntero, este es el tiempo máximo (en milisegundos) que se puede ignorar el movimiento del puntero.\n\nAyuda a prevenir que los objetos sean movidos involuntariamente si el puntero se mueve al hacer clic."

src/locales/fr/main.json

@@ -785,13 +785,13 @@
     "Toggle Bottom Panel": "Basculer le panneau inférieur",
     "Toggle Focus Mode": "Basculer le mode focus",
     "Toggle Logs Bottom Panel": "Basculer le panneau inférieur des journaux",
-    "Toggle Model Library Sidebar": "Basculer la barre latérale de la bibliothèque de modèles",
-    "Toggle Node Library Sidebar": "Basculer la barre latérale de la bibliothèque de nœuds",
-    "Toggle Queue Sidebar": "Basculer la barre latérale de la file d'attente",
+    "Toggle Model Library Sidebar": "Afficher/Masquer la barre latérale de la bibliothèque de modèles",
+    "Toggle Node Library Sidebar": "Afficher/Masquer la barre latérale de la bibliothèque de nœuds",
+    "Toggle Queue Sidebar": "Afficher/Masquer la barre latérale de la file d’attente",
     "Toggle Search Box": "Basculer la boîte de recherche",
     "Toggle Terminal Bottom Panel": "Basculer le panneau inférieur du terminal",
     "Toggle Theme (Dark/Light)": "Basculer le thème (Sombre/Clair)",
-    "Toggle Workflows Sidebar": "Basculer la barre latérale des flux de travail",
+    "Toggle Workflows Sidebar": "Afficher/Masquer la barre latérale des workflows",
     "Toggle the Custom Nodes Manager": "Basculer le gestionnaire de nœuds personnalisés",
     "Toggle the Custom Nodes Manager Progress Bar": "Basculer la barre de progression du gestionnaire de nœuds personnalisés",
     "Undo": "Annuler",
@@ -1099,6 +1099,7 @@
     "Node Search Box": "Boîte de Recherche de Nœud",
     "Node Widget": "Widget de Nœud",
     "NodeLibrary": "Bibliothèque de Nœuds",
+    "Notification Preferences": "Préférences de notification",
     "Pointer": "Pointeur",
     "Queue": "File d'Attente",
     "QueueButton": "Bouton de File d'Attente",

src/locales/fr/settings.json

@@ -259,6 +259,10 @@
     "name": "Le snap met en évidence le nœud",
     "tooltip": "Lorsque vous faites glisser un lien sur un nœud avec une fente d'entrée viable, mettez en évidence le nœud"
   },
+  "Comfy_Notification_ShowVersionUpdates": {
+    "name": "Afficher les mises à jour de version",
+    "tooltip": "Afficher les mises à jour pour les nouveaux modèles et les nouvelles fonctionnalités majeures."
+  },
   "Comfy_Pointer_ClickBufferTime": {
     "name": "Délai de dérive du clic du pointeur",
     "tooltip": "Après avoir appuyé sur un bouton de pointeur, c'est le temps maximum (en millisecondes) que le mouvement du pointeur peut être ignoré.\n\nAide à prévenir que les objets soient déplacés involontairement si le pointeur est déplacé lors du clic."

src/locales/ja/main.json

@@ -1099,6 +1099,7 @@
     "Node Search Box": "ノード検索ボックス",
     "Node Widget": "ノードウィジェット",
     "NodeLibrary": "ノードライブラリ",
+    "Notification Preferences": "通知設定",
     "Pointer": "ポインタ",
     "Queue": "キュー",
     "QueueButton": "キューボタン",

src/locales/ja/settings.json

@@ -259,6 +259,10 @@
     "name": "スナップハイライトノード",
     "tooltip": "有効な入力スロットを持つノードの上にリンクをドラッグすると、ノードがハイライトされます"
   },
+  "Comfy_Notification_ShowVersionUpdates": {
+    "name": "バージョン更新を表示",
+    "tooltip": "新しいモデルや主要な新機能のアップデートを表示します。"
+  },
   "Comfy_Pointer_ClickBufferTime": {
     "name": "ポインタークリックドリフト遅延",
     "tooltip": "ポインターボタンを押した後、ポインタの動きが無視される最大時間（ミリ秒単位）です。\n\nクリック中にポインタが移動した場合、オブジェクトが意図せず動かされるのを防ぎます。"

src/locales/ko/main.json

@@ -787,11 +787,11 @@
     "Toggle Logs Bottom Panel": "로그 하단 패널 전환",
     "Toggle Model Library Sidebar": "모델 라이브러리 사이드바 전환",
     "Toggle Node Library Sidebar": "노드 라이브러리 사이드바 전환",
-    "Toggle Queue Sidebar": "실행 대기열 사이드바 전환",
+    "Toggle Queue Sidebar": "대기열 사이드바 전환",
     "Toggle Search Box": "검색 상자 전환",
     "Toggle Terminal Bottom Panel": "터미널 하단 패널 전환",
     "Toggle Theme (Dark/Light)": "테마 전환 (어두운/밝은)",
-    "Toggle Workflows Sidebar": "워크플로 사이드바 전환",
+    "Toggle Workflows Sidebar": "워크플로우 사이드바 전환",
     "Toggle the Custom Nodes Manager": "커스텀 노드 매니저 전환",
     "Toggle the Custom Nodes Manager Progress Bar": "커스텀 노드 매니저 진행률 표시줄 전환",
     "Undo": "실행 취소",
@@ -1099,6 +1099,7 @@
     "Node Search Box": "노드 검색 상자",
     "Node Widget": "노드 위젯",
     "NodeLibrary": "노드 라이브러리",
+    "Notification Preferences": "알림 환경설정",
     "Pointer": "포인터",
     "Queue": "실행 대기열",
     "QueueButton": "실행 대기열 버튼",