Add browser tests for litegraph changes (#580) (#585) (#587)

* Add browser tests for litegraph changes (#580) (#585)

* Zoom speed tests

* Merge

* Prompt dialog test

* Update test expectations [skip ci]

---------

Co-authored-by: bymyself <[email protected]>
Co-authored-by: github-actions <[email protected]>

Author: 3 people

browser_tests/ComfyPage.ts

@@ -185,6 +185,12 @@ export class ComfyPage {
     )
   }
 
+  async getSetting(settingId: string) {
+    return await this.page.evaluate(async (id) => {
+      return await window['app'].ui.settings.getSettingValue(id)
+    }, settingId)
+  }
+
   async reload() {
     await this.page.reload({ timeout: 15000 })
     await this.setup()
@@ -201,7 +207,7 @@ export class ComfyPage {
   }
 
   async delay(ms: number) {
-      return new Promise(resolve => setTimeout(resolve, ms));
+    return new Promise((resolve) => setTimeout(resolve, ms))
   }
 
   async loadWorkflow(workflowName: string) {

browser_tests/interaction.spec.ts

@@ -113,6 +113,23 @@ test.describe('Node Interaction', () => {
       'text-encode-toggled-back-open.png'
     )
   })
+
+  test('Can close prompt dialog with canvas click', async ({ comfyPage }) => {
+    await comfyPage.canvas.click({
+      position: {
+        x: 724,
+        y: 645
+      }
+    })
+    await expect(comfyPage.canvas).toHaveScreenshot('prompt-dialog-opened.png')
+    await comfyPage.canvas.click({
+      position: {
+        x: 10,
+        y: 10
+      }
+    })
+    await expect(comfyPage.canvas).toHaveScreenshot('prompt-dialog-closed.png')
+  })
 })
 
 test.describe('Canvas Interaction', () => {
@@ -147,6 +164,36 @@ test.describe('Canvas Interaction', () => {
     await comfyPage.page.keyboard.up('Shift')
   })
 
+  test('Can zoom in/out after decreasing canvas zoom speed setting', async ({
+    comfyPage
+  }) => {
+    await comfyPage.setSetting('Comfy.Graph.ZoomSpeed', 1.05)
+    await comfyPage.zoom(-100, 4)
+    await expect(comfyPage.canvas).toHaveScreenshot(
+      'zoomed-in-low-zoom-speed.png'
+    )
+    await comfyPage.zoom(100, 8)
+    await expect(comfyPage.canvas).toHaveScreenshot(
+      'zoomed-out-low-zoom-speed.png'
+    )
+    await comfyPage.setSetting('Comfy.Graph.ZoomSpeed', 1.1)
+  })
+
+  test('Can zoom in/out after increasing canvas zoom speed', async ({
+    comfyPage
+  }) => {
+    await comfyPage.setSetting('Comfy.Graph.ZoomSpeed', 1.5)
+    await comfyPage.zoom(-100, 4)
+    await expect(comfyPage.canvas).toHaveScreenshot(
+      'zoomed-in-high-zoom-speed.png'
+    )
+    await comfyPage.zoom(100, 8)
+    await expect(comfyPage.canvas).toHaveScreenshot(
+      'zoomed-out-high-zoom-speed.png'
+    )
+    await comfyPage.setSetting('Comfy.Graph.ZoomSpeed', 1.1)
+  })
+
   test('Can pan', async ({ comfyPage }) => {
     await comfyPage.pan({ x: 200, y: 200 })
     await expect(comfyPage.canvas).toHaveScreenshot('panned.png')

browser_tests/interaction.spec.ts-snapshots/prompt-dialog-closed-chromium-linux.png

@@ -92,4 +92,17 @@ test.describe('Menu', () => {
     // Verify the node is added to the canvas
     expect(await comfyPage.getGraphNodesCount()).toBe(count + 1)
   })
+
+  test('Can change canvas zoom speed setting', async ({ comfyPage }) => {
+    const [defaultSpeed, maxSpeed] = [1.1, 2.5]
+    expect(await comfyPage.getSetting('Comfy.Graph.ZoomSpeed')).toBe(
+      defaultSpeed
+    )
+    await comfyPage.setSetting('Comfy.Graph.ZoomSpeed', maxSpeed)
+    expect(await comfyPage.getSetting('Comfy.Graph.ZoomSpeed')).toBe(maxSpeed)
+    await comfyPage.page.reload()
+    await comfyPage.setup()
+    expect(await comfyPage.getSetting('Comfy.Graph.ZoomSpeed')).toBe(maxSpeed)
+    await comfyPage.setSetting('Comfy.Graph.ZoomSpeed', defaultSpeed)
+  })
 })