Skip to content

Commit 3cded2c

Browse files
[fix] Remove unreliable CI wait logic from Claude review workflow (#6548)
Removes the wait-for-ci job that has been causing random workflow skips and reliability issues due to race conditions with CI check creation. Multiple attempts to fix timing issues have resulted in ongoing edge cases, so this simplifies the workflow to run immediately when the claude-review label is added. Reviews can now run in parallel with CI checks, and while they may occasionally run on PRs with failing CI, the review feedback is often valuable regardless of CI status. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6548-fix-Remove-unreliable-CI-wait-logic-from-Claude-review-workflow-29f6d73d36508125910ef4feba5abdf4) by [Unito](https://www.unito.io)
1 parent fd236b3 commit 3cded2c

File tree

1 file changed

+1
-32
lines changed

1 file changed

+1
-32
lines changed

.github/workflows/pr-claude-review.yaml

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -17,40 +17,9 @@ concurrency:
1717
cancel-in-progress: true
1818

1919
jobs:
20-
wait-for-ci:
21-
runs-on: ubuntu-latest
22-
if: github.event.label.name == 'claude-review'
23-
outputs:
24-
should-proceed: ${{ steps.check-status.outputs.proceed }}
25-
steps:
26-
- name: Wait for other CI checks
27-
uses: lewagon/wait-on-check-action@e106e5c43e8ca1edea6383a39a01c5ca495fd812
28-
with:
29-
ref: ${{ github.event.pull_request.head.sha }}
30-
check-regexp: '^(lint-and-format|test|playwright-tests)'
31-
allowed-conclusions: success,skipped,failure,cancelled,neutral,action_required,timed_out,stale
32-
wait-interval: 30
33-
repo-token: ${{ secrets.GITHUB_TOKEN }}
34-
35-
- name: Check if we should proceed
36-
id: check-status
37-
run: |
38-
CHECK_RUNS=$(gh api repos/${{ github.repository }}/commits/${{ github.event.pull_request.head.sha }}/check-runs --jq '.check_runs[] | select(.name | test("lint-and-format")) | {name, conclusion}')
39-
40-
if echo "$CHECK_RUNS" | grep -Eq '"conclusion": "(failure|cancelled|timed_out|action_required)"'; then
41-
echo "Some CI checks failed - skipping Claude review"
42-
echo "proceed=false" >> $GITHUB_OUTPUT
43-
else
44-
echo "All CI checks passed - proceeding with Claude review"
45-
echo "proceed=true" >> $GITHUB_OUTPUT
46-
fi
47-
env:
48-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
49-
5020
claude-review:
51-
needs: wait-for-ci
52-
if: needs.wait-for-ci.outputs.should-proceed == 'true'
5321
runs-on: ubuntu-latest
22+
if: github.event.label.name == 'claude-review'
5423
timeout-minutes: 30
5524
steps:
5625
- name: Checkout repository

0 commit comments

Comments
 (0)