Skip to content

Commit 61ac1d1

Browse files
christian-byrneDrJKL
authored andcommitted
fix: resolve remaining stylelint issues
- Disable no-descending-specificity (43 warnings, requires CSS refactor) - Fix 2 duplicate selectors (merge into single declaration) - Remove duplicate vendor prefix fallbacks (user-select, mask-image) - Add font fallbacks for primeicons (sans-serif) - Whitelist Vue v-bind() CSS function
1 parent a13a274 commit 61ac1d1

File tree

6 files changed

+13
-23
lines changed

6 files changed

+13
-23
lines changed

.stylelintrc.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
{
1616
"ignoreProperties": {
1717
"speak": ["none"],
18-
"app-region": ["drag", "no-drag"]
18+
"app-region": ["drag", "no-drag"],
19+
"/^(width|height)$/": ["/^v-bind/"]
1920
}
2021
}
2122
],
@@ -35,7 +36,7 @@
3536
"selector-max-type": 2,
3637
"declaration-block-no-duplicate-properties": true,
3738
"block-no-empty": true,
38-
"no-descending-specificity": true,
39+
"no-descending-specificity": null,
3940
"no-duplicate-at-import-rules": true,
4041
"at-rule-no-unknown": [
4142
true,
@@ -57,7 +58,8 @@
5758
true,
5859
{
5960
"ignoreFunctions": [
60-
"theme"
61+
"theme",
62+
"v-bind"
6163
]
6264
}
6365
]

apps/desktop-ui/src/components/install/InstallLocationPicker.vue

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,12 @@ const onFocus = async () => {
286286
.p-accordionheader {
287287
@apply rounded-t-xl rounded-b-none;
288288
}
289+
290+
.p-accordionheader-toggle-icon {
291+
&::before {
292+
content: '\e902';
293+
}
294+
}
289295
}
290296
291297
.p-accordioncontent {
@@ -302,13 +308,5 @@ const onFocus = async () => {
302308
content: '\e933';
303309
}
304310
}
305-
306-
.p-accordionpanel-active {
307-
.p-accordionheader-toggle-icon {
308-
&::before {
309-
content: '\e902';
310-
}
311-
}
312-
}
313311
}
314312
</style>

apps/desktop-ui/src/views/DesktopUpdateView.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ onUnmounted(() => electron.Validation.dispose())
6565
6666
.download-bg::before {
6767
@apply m-0 absolute text-muted;
68-
font-family: 'primeicons';
68+
font-family: 'primeicons', sans-serif;
6969
top: -2rem;
7070
right: 2rem;
7171
speak: none;

apps/desktop-ui/src/views/MaintenanceView.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ onUnmounted(() => electron.Validation.dispose())
186186
187187
.backspan::before {
188188
@apply m-0 absolute text-muted;
189-
font-family: 'primeicons';
189+
font-family: 'primeicons', sans-serif;
190190
top: -2rem;
191191
right: -2rem;
192192
speak: none;

packages/design-system/src/css/style.css

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1004,9 +1004,6 @@ audio.comfy-audio.empty-audio-widget {
10041004
.lg-node {
10051005
/* Disable text selection on all nodes */
10061006
user-select: none;
1007-
user-select: none;
1008-
user-select: none;
1009-
user-select: none;
10101007
}
10111008

10121009
.lg-node .lg-slot,
@@ -1034,7 +1031,6 @@ audio.comfy-audio.empty-audio-widget {
10341031
backdrop-filter: none;
10351032
text-shadow: none;
10361033
mask-image: none;
1037-
mask-image: none;
10381034
clip-path: none;
10391035
background-image: none;
10401036
text-rendering: optimizeSpeed;

src/platform/updates/components/WhatsNewPopup.vue

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -293,12 +293,6 @@ defineExpose({
293293
transform: translate(-50%, -50%) rotate(-45deg);
294294
}
295295
296-
/* Content Section */
297-
.popup-content {
298-
display: flex;
299-
flex-direction: column;
300-
}
301-
302296
.content-text {
303297
color: white;
304298
font-size: 14px;

0 commit comments

Comments
 (0)