Skip to content

Commit 8faf3b6

Browse files
webfilteredarjansingh
authored andcommitted
Extract registry types into workspace package (#5840)
Extracts ComfyUI registry types into a dedicated workspace package for better modularity. - **What**: Created `@comfyorg/registry-types` package to house generated type definitions - **Breaking**: None - maintains backward compatibility through re-exports at original path - **Dependencies**: Added `@comfyorg/registry-types` as workspace dependency Is this the right granularity for package extraction, or should registry types be part of a larger shared package? PR split into two tiny diffs: - [Part one](https://github.com/Comfy-Org/ComfyUI_frontend/pull/5840/files/f8d3d2fa014aa4215e99d3ea93c1ebcabd6246d6) - [Part two](https://github.com/Comfy-Org/ComfyUI_frontend/pull/5840/files/f8d3d2fa014aa4215e99d3ea93c1ebcabd6246d6..c48ca843366c86a5d2214c036dcd9b24128a970a) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5840-Extract-registry-types-into-workspace-package-27c6d73d365081dbb824d680ce739316) by [Unito](https://www.unito.io)
1 parent 81ed9d2 commit 8faf3b6

File tree

2 files changed

+46
-29
lines changed

2 files changed

+46
-29
lines changed

knip.config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ const config: KnipConfig = {
2020
project: ['src/**/*.{js,ts}', '*.{js,ts,mts}']
2121
},
2222
'packages/registry-types': {
23+
entry: ['src/comfyRegistryTypes.ts'],
2324
project: ['src/**/*.{js,ts}']
2425
}
2526
},

pnpm-lock.yaml

Lines changed: 45 additions & 29 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)