Skip to content

Commit 99b3a59

Browse files
DrJKLgithub-actions
andauthored
Style: Standardize icon use Part 1 (#5947)
## Summary Remove the mix of class based and component style icons in favor of just [classes](https://iconify.design/docs/usage/css/tailwind/tailwind4/#basic-usage). ## Changes - **What**: Migrate existing lucide icons ## Review Focus What differs between the icons before and now? ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5947-Style-Standardize-icon-use-Part-1-2846d73d365081bfa66ceb6bdaa9ff02) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]>
1 parent 0616c04 commit 99b3a59

File tree

60 files changed

+124
-119
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+124
-119
lines changed

.storybook/README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -211,18 +211,17 @@ This Storybook setup includes:
211211

212212
## Icon Usage in Storybook
213213

214-
In this project, the `<i-lucide:... />` syntax from unplugin-icons is not supported in Storybook.
214+
In this project, only the `<i class="icon-[lucide--folder]" />` syntax from unplugin-icons is supported in Storybook.
215215

216216
**Example:**
217217

218218
```vue
219219
<script setup lang="ts">
220-
import { Trophy, Settings } from 'lucide-vue-next'
221220
</script>
222221
223222
<template>
224-
<Trophy :size="16" class="text-neutral" />
225-
<Settings :size="16" class="text-neutral" />
223+
<i class="icon-[lucide--trophy] text-neutral size-4" />
224+
<i class="icon-[lucide--settings] text-neutral size-4" />
226225
</template>
227226
```
228227

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ pnpm format
255255
The project supports three types of icons, all with automatic imports (no manual imports needed):
256256

257257
1. **PrimeIcons** - Built-in PrimeVue icons using CSS classes: `<i class="pi pi-plus" />`
258-
2. **Iconify Icons** - 200,000+ icons from various libraries: `<i-lucide:settings />`, `<i-mdi:folder />`
258+
2. **Iconify Icons** - 200,000+ icons from various libraries: `<i class="icon-[lucide--settings]" />`, `<i class="icon-[mdi--folder]" />`
259259
3. **Custom Icons** - Your own SVG icons: `<i-comfy:workflow />`
260260

261261
Icons are powered by the unplugin-icons system, which automatically discovers and imports icons as Vue components. Custom icons are stored in `packages/design-system/src/icons/` and processed by `packages/design-system/src/iconCollection.ts` with automatic validation.

apps/desktop-ui/src/components/install/GpuPicker.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
:value="$t('install.gpuPicker.recommended')"
5454
class="bg-neutral-300 text-neutral-900 rounded-full text-sm font-bold px-2 py-[1px]"
5555
/>
56-
<i-lucide:badge-check class="text-neutral-300 text-lg" />
56+
<i class="icon-[lucide--badge-check] text-neutral-300 text-lg" />
5757
</div>
5858
</div>
5959

124 Bytes
Loading
148 Bytes
Loading
145 Bytes
Loading
108 Bytes
Loading
123 Bytes
Loading
135 Bytes
Loading
102 Bytes
Loading

0 commit comments

Comments
 (0)