Knip: Enable more rules (#5309)

* knip: Simplify config

* knip: enable unlisted, fix issues

* knip: Add ignore for build dependencies (Vite plugin indirect reference)

* knip: Prune dependencies

* knip: One more Unused dep

* git: Standard line end for yaml

* [auto-fix] Apply ESLint and Prettier fixes

* knip: Add exceptions for tailwindcss post-rebase.
Not sure why we need to except it.

* Update test expectations [skip ci]

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: github-actions <[email protected]>

Author: 3 people

.gitattributes

@@ -9,6 +9,7 @@
 *.mts text eol=lf
 *.ts text eol=lf
 *.vue text eol=lf
+*.yaml text eol=lf
 
 # Generated files
 src/types/comfyRegistryTypes.ts linguist-generated=true

browser_tests/fixtures/UserSelectPage.ts

@@ -1,5 +1,4 @@
-import { test as base } from '@playwright/test'
-import { Page } from 'playwright'
+import { Page, test as base } from '@playwright/test'
 
 export class UserSelectPage {
   constructor(

browser_tests/fixtures/utils/taskHistory.ts

@@ -1,7 +1,7 @@
+import type { Request, Route } from '@playwright/test'
 import _ from 'es-toolkit/compat'
 import fs from 'fs'
 import path from 'path'
-import type { Request, Route } from 'playwright'
 import { v4 as uuidv4 } from 'uuid'
 
 import type {

browser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-multiple-nodes-border-chromium-linux.png

@@ -2,24 +2,31 @@ import type { KnipConfig } from 'knip'
 
 const config: KnipConfig = {
   entry: [
+    'build/**/*.ts',
+    'scripts/**/*.{js,ts}',
     'src/main.ts',
-    'vite.config.mts',
     'vite.electron.config.mts',
-    'vite.types.config.mts',
-    'eslint.config.js',
-    'tailwind.config.ts',
-    'postcss.config.js',
-    'playwright.config.ts',
-    'playwright.i18n.config.ts',
-    'vitest.config.ts',
-    'vitest.litegraph.config.ts',
-    'scripts/**/*.{js,ts}'
+    'vite.types.config.mts'
   ],
   project: [
+    'browser_tests/**/*.{js,ts}',
+    'build/**/*.{js,ts,vue}',
+    'scripts/**/*.{js,ts}',
     'src/**/*.{js,ts,vue}',
     'tests-ui/**/*.{js,ts,vue}',
-    'browser_tests/**/*.{js,ts}',
-    'scripts/**/*.{js,ts}'
+    '*.{js,ts,mts}'
+  ],
+  ignoreDependencies: [
+    '@primeuix/forms',
+    '@primeuix/styled',
+    '@primeuix/utils',
+    '@primevue/icons',
+    '@iconify/json',
+    'tailwindcss',
+    'tailwindcss-primeui', // Need to figure out why tailwind plugin isn't applying
+    // Dev
+    '@executeautomation/playwright-mcp-server',
+    '@trivago/prettier-plugin-sort-imports'
   ],
   ignore: [
     // Generated files
@@ -57,29 +64,21 @@ const config: KnipConfig = {
   ignoreExportsUsedInFile: true,
   // Vue-specific configuration
   vue: true,
+  tailwind: true,
   // Only check for unused files, disable all other rules
   // TODO: Gradually enable other rules - see https://github.com/Comfy-Org/ComfyUI_frontend/issues/4888
   rules: {
     binaries: 'off',
     classMembers: 'off',
-    dependencies: 'off',
-    devDependencies: 'off',
     duplicates: 'off',
     enumMembers: 'off',
     exports: 'off',
     nsExports: 'off',
     nsTypes: 'off',
-    types: 'off',
-    unlisted: 'off'
+    types: 'off'
   },
   // Include dependencies analysis
-  includeEntryExports: true,
-  // Workspace configuration for monorepo-like structure
-  workspaces: {
-    '.': {
-      entry: ['src/main.ts', 'playwright.i18n.config.ts']
-    }
-  }
+  includeEntryExports: true
 }
 
 export default config

browser_tests/tests/selectionToolbox.spec.ts-snapshots/selection-toolbox-multiple-selections-border-chromium-linux.png

@@ -40,33 +40,29 @@
   "devDependencies": {
     "@eslint/js": "^9.8.0",
     "@executeautomation/playwright-mcp-server": "^1.0.6",
-    "@iconify/json": "^2.2.245",
     "@iconify/tailwind": "^1.2.0",
     "@intlify/eslint-plugin-vue-i18n": "^3.2.0",
     "@lobehub/i18n-cli": "^1.25.1",
     "@nx/eslint": "21.4.1",
     "@nx/playwright": "21.4.1",
     "@nx/storybook": "21.4.1",
     "@nx/vite": "21.4.1",
-    "@nx/web": "21.4.1",
     "@pinia/testing": "^0.1.5",
     "@playwright/test": "^1.52.0",
     "@storybook/addon-docs": "^9.1.1",
     "@storybook/vue3": "^9.1.1",
     "@storybook/vue3-vite": "^9.1.1",
     "@tailwindcss/vite": "^4.1.12",
     "@trivago/prettier-plugin-sort-imports": "^5.2.0",
-    "@types/dompurify": "^3.0.5",
     "@types/fs-extra": "^11.0.4",
     "@types/jsdom": "^21.1.7",
     "@types/node": "^20.14.8",
     "@types/semver": "^7.7.0",
     "@types/three": "^0.169.0",
     "@vitejs/plugin-vue": "^5.1.4",
+    "@vitest/coverage-v8": "^3.2.4",
     "@vitest/ui": "^3.0.0",
     "@vue/test-utils": "^2.4.6",
-    "chalk": "^5.3.0",
-    "commander": "^14.0.0",
     "eslint": "^9.12.0",
     "eslint-config-prettier": "^10.1.2",
     "eslint-plugin-prettier": "^5.2.6",
@@ -77,18 +73,13 @@
     "globals": "^15.9.0",
     "happy-dom": "^15.11.0",
     "husky": "^9.0.11",
-    "identity-obj-proxy": "^3.0.0",
-    "ink": "^6.2.2",
     "jiti": "2.4.2",
     "jsdom": "^26.1.0",
     "knip": "^5.62.0",
     "lint-staged": "^15.2.7",
     "lucide-vue-next": "^0.540.0",
     "nx": "21.4.1",
-    "postcss": "^8.4.39",
     "prettier": "^3.3.2",
-    "react": "^19.1.1",
-    "react-reconciler": "^0.32.0",
     "storybook": "^9.1.1",
     "tailwindcss": "^4.1.12",
     "tailwindcss-primeui": "^0.6.1",
@@ -111,14 +102,14 @@
     "@alloc/quick-lru": "^5.2.0",
     "@atlaskit/pragmatic-drag-and-drop": "^1.3.1",
     "@comfyorg/comfyui-electron-types": "^0.4.69",
+    "@iconify/json": "^2.2.380",
     "@primeuix/forms": "0.0.2",
     "@primeuix/styled": "0.3.2",
     "@primeuix/utils": "^0.3.2",
     "@primevue/core": "^4.2.5",
     "@primevue/forms": "^4.2.5",
     "@primevue/icons": "4.2.5",
     "@primevue/themes": "^4.2.5",
-    "@sentry/core": "^10.5.0",
     "@sentry/vue": "^8.48.0",
     "@tiptap/core": "^2.10.4",
     "@tiptap/extension-link": "^2.10.4",