Skip to content

Commit bbfada5

Browse files
simula-rgithub-actions
andauthored
Fix/vue nodes auto scale (#6664)
## Summary **Problem:** ensureCorrectLayoutScale scales up LG -> Vue. But doesn't scale down from Vue -> LG. **Solution:** Bi directional scaling. **Bonus:** fix edge cases such as subgraphs, groups, and reroutes. Also, set auto scale: true now that we 'preserve' LG scale. **IMPORTANT:** useVueNodeResizeTracking.ts sets vue node height - Litegraph.NODE_TITLE_HEIGHT on workflow load using a resize observer. Reloading the page (loading a workflow) in Vue mode, will subtract height each time. This can look like a problem caused by ensureCorrectLayoutScale. It is not. Need to fix. Here was an attempt by [removing the Litegraph.NODE_TITLE_HEIGHT entirely](#6643). ## Review Focus Full lifecycle of loading workflows and switching between vue and lg. Race conditions could be present. For example switching the mode using keybind very fast. ## Screenshots (if applicable) https://github.com/user-attachments/assets/5576b760-13a8-45b9-b8f7-64e1caf443c1 https://github.com/user-attachments/assets/46d6f870-df76-4084-968a-53cb629fc123 --------- Co-authored-by: github-actions <[email protected]>
1 parent c4477fc commit bbfada5

17 files changed

+205
-53
lines changed
-34 Bytes
Loading
115 Bytes
Loading
-882 Bytes
Loading
-947 Bytes
Loading
Loading
-1016 Bytes
Loading
Loading
-974 Bytes
Loading
-1 KB
Loading
-1 KB
Loading

0 commit comments

Comments
 (0)