fix(GraphCanvas): add ping-pong guard to palette setting watcher

DrJKL · ampcode-com · DrJKL · commit c65aebbe0c37 · 2026-01-26T00:24:54.000-08:00
Phase 4: Reactivity Fixes - prevent circular trigger when activePaletteId watcher sets Comfy.ColorPalette setting which would trigger the palette watcher back Amp-Thread-ID: https://ampcode.com/threads/T-019bf966-9b22-70af-a5be-1c9c2deb3d1e Co-authored-by: Amp <amp@ampcode.com>
diff --git a/src/components/graph/GraphCanvas.vue b/src/components/graph/GraphCanvas.vue
@@ -322,7 +322,10 @@ watch(
 watch(
   () => colorPaletteStore.activePaletteId,
   async (newValue) => {
-    await settingStore.set('Comfy.ColorPalette', newValue)
+    // Guard against ping-pong: only set if value actually differs
+    if (newValue && settingStore.get('Comfy.ColorPalette') !== newValue) {
+      await settingStore.set('Comfy.ColorPalette', newValue)
+    }
   }
 )
 

Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,10 @@ watch(`
`322`	`322`	`watch(`
`323`	`323`	`() => colorPaletteStore.activePaletteId,`
`324`	`324`	`async (newValue) => {`
`325`		`- await settingStore.set('Comfy.ColorPalette', newValue)`
	`325`	`+ // Guard against ping-pong: only set if value actually differs`
	`326`	`+ if (newValue && settingStore.get('Comfy.ColorPalette') !== newValue) {`
	`327`	`+ await settingStore.set('Comfy.ColorPalette', newValue)`
	`328`	`+ }`
`326`	`329`	`}`
`327`	`330`	`)`
`328`	`331`