Skip to content

Commit e31d98b

Browse files
fix: block missing e2e regression coverage in CodeRabbit (#9987)
## Summary Make the CodeRabbit end-to-end regression coverage check actually block fix-like PRs until it is resolved or explicitly overridden by a requested reviewer, and harden the prompt so it evaluates only PR-local metadata. ## Changes - **What**: Set the `End-to-end regression coverage for fixes` custom check mode from `warning` to `error` - **What**: Enable `reviews.request_changes_workflow` so CodeRabbit can block on failed `error` pre-merge checks - **What**: Set `reviews.pre_merge_checks.override_requested_reviewers_only` to `true` so only requested reviewers can bypass a failed check - **What**: Tighten the custom check instructions to use only PR metadata in review context, avoid shell commands, and avoid reverse-diff or base-branch file evaluation ## Review Focus Confirm this is the intended CodeRabbit enforcement model for missing Playwright regression coverage on fix-like PRs and that the prompt wording is strict enough to avoid false positives from reversed diffs.
1 parent 736f0fa commit e31d98b

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.coderabbit.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ issue_enrichment:
33
enabled: true
44
reviews:
55
high_level_summary: false
6+
request_changes_workflow: true
67
auto_review:
78
drafts: true
89
ignore_title_keywords:
@@ -13,10 +14,14 @@ reviews:
1314
- github-actions
1415
- github-actions[bot]
1516
pre_merge_checks:
17+
override_requested_reviewers_only: true
1618
custom_checks:
1719
- name: End-to-end regression coverage for fixes
18-
mode: warning
20+
mode: error
1921
instructions: |
22+
Use only PR metadata already available in the review context: the PR title, commit subjects in this PR, the files changed in this PR relative to the PR base (equivalent to `base...head`), and the PR description.
23+
Do not rely on shell commands. Do not inspect reverse diffs, files changed only on the base branch, or files outside this PR. If the changed-file list or commit subjects are unavailable, mark the check inconclusive instead of guessing.
24+
2025
Pass if at least one of the following is true:
2126
1. Neither the PR title nor any commit subject in the PR uses bug-fix language such as `fix`, `fixed`, `fixes`, `fixing`, `bugfix`, or `hotfix`.
2227
2. The PR changes at least one file under `browser_tests/`.

0 commit comments

Comments
 (0)