Skip to content

Commit e5d5c04

Browse files
christian-byrnegithub-actions
andauthored
fix and enable skipped Vue nodes bypass test (#6290)
This test was failing on main for a few days so it was marked as `fixme`. The failure was due to interaction with minimap. Just turn off the minimap for now as it's not really related to what the test is targeting (arguable). Better to at least have the coverage for now. Context: - #6127 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6290-fix-and-enable-skipped-Vue-nodes-bypass-test-2986d73d3650819faeaaf414ce2b6e61) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]>
1 parent 9350c85 commit e5d5c04

File tree

2 files changed

+19
-20
lines changed

2 files changed

+19
-20
lines changed

browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,28 @@ const BYPASS_CLASS = /before:bg-bypass\/60/
99
test.describe('Vue Node Bypass', () => {
1010
test.beforeEach(async ({ comfyPage }) => {
1111
await comfyPage.setSetting('Comfy.VueNodes.Enabled', true)
12+
await comfyPage.setSetting('Comfy.UseNewMenu', 'Top')
13+
await comfyPage.setSetting('Comfy.Minimap.Visible', false)
14+
await comfyPage.setSetting('Comfy.Graph.CanvasMenu', true)
1215
await comfyPage.vueNodes.waitForNodes()
1316
})
1417

15-
test.fixme(
16-
'should allow toggling bypass on a selected node with hotkey',
17-
async ({ comfyPage }) => {
18-
await comfyPage.setup()
19-
await comfyPage.page.getByText('Load Checkpoint').click()
20-
await comfyPage.page.keyboard.press(BYPASS_HOTKEY)
21-
22-
const checkpointNode =
23-
comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
24-
await expect(checkpointNode).toHaveClass(BYPASS_CLASS)
25-
await comfyPage.page.mouse.click(400, 300)
26-
await comfyPage.page.waitForTimeout(128)
27-
await expect(comfyPage.canvas).toHaveScreenshot(
28-
'vue-node-bypassed-state.png'
29-
)
30-
31-
await comfyPage.page.keyboard.press(BYPASS_HOTKEY)
32-
await expect(checkpointNode).not.toHaveClass(BYPASS_CLASS)
33-
}
34-
)
18+
test('should allow toggling bypass on a selected node with hotkey', async ({
19+
comfyPage
20+
}) => {
21+
await comfyPage.page.getByText('Load Checkpoint').click()
22+
await comfyPage.page.keyboard.press(BYPASS_HOTKEY)
23+
24+
const checkpointNode = comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')
25+
await expect(checkpointNode).toHaveClass(BYPASS_CLASS)
26+
await comfyPage.nextFrame()
27+
await expect(comfyPage.canvas).toHaveScreenshot(
28+
'vue-node-bypassed-state.png'
29+
)
30+
31+
await comfyPage.page.keyboard.press(BYPASS_HOTKEY)
32+
await expect(checkpointNode).not.toHaveClass(BYPASS_CLASS)
33+
})
3534

3635
test('should allow toggling bypass on multiple selected nodes with hotkey', async ({
3736
comfyPage
1.47 KB
Loading

0 commit comments

Comments
 (0)