Skip to content

Commit e7745eb

Browse files
DrJKLgithub-actions
andauthored
Style: Make components themeable (#5908)
## Summary Replace color/dark-color pairs in components with design tokens to allow for easy overriding. <!-- Also standardizes the icon pattern to simplify the tailwind config. --> ## Changes - **What**: Token based colors, for now, mostly. - **Breaking**: Got approval from Design to collapse some very similar pairs of colors that seem to have diverged in implementations over time. Some of the colors might be a little different, but we can tweak them later. ## Review Focus Still have quite a few places from which to remove `dark-theme`, but this at least gets the theming much closer. Need to decide if I want to keep going in here or cut this and do the rest in a subsequent PR. ## Screenshots (if applicable) <!-- Add screenshots or video recording to help explain your changes --> ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5908-WIP-Make-components-themeable-2816d73d365081ffbc05d189fe71084b) by [Unito](https://www.unito.io) --------- Co-authored-by: github-actions <[email protected]>
1 parent 51f0f11 commit e7745eb

File tree

50 files changed

+235
-105
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+235
-105
lines changed

browser_tests/fixtures/VueNodeHelpers.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ export class VueNodeHelpers {
2424
* Get locator for selected Vue node components (using visual selection indicators)
2525
*/
2626
get selectedNodes(): Locator {
27-
return this.page.locator(
28-
'[data-node-id].outline-black, [data-node-id].outline-white'
29-
)
27+
return this.page.locator('[data-node-id].outline-node-component-outline')
3028
}
3129

3230
/**
-33 Bytes
Loading
-29 Bytes
Loading
3 Bytes
Loading
-83 Bytes
Loading
-12 Bytes
Loading
27 Bytes
Loading
-19 Bytes
Loading
-5 Bytes
Loading
35 Bytes
Loading

0 commit comments

Comments
 (0)