Skip to content

Commit efed934

Browse files
remove tailwindcss eslint plugin (#6342)
This plugin does not seem to work well with tw v4. Can revert this PR later. --- the graph is forcing [email protected] which tries to import v3 files, or something like that. ``` > @comfyorg/[email protected] lint:fix /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone-31 > eslint src --cache --fix Oops! Something went wrong! :( ESLint: 9.35.0 Error: Error while loading rule 'tailwindcss/enforces-negative-arbitrary-values': Cannot find module '/home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone-31/node_modules/.pnpm/[email protected]/node_modules/tailwindcss/dist/lib/setupContextUtils.js' Require stack: - /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone-31/node_modules/.pnpm/[email protected][email protected]/node_modules/tailwind-api-utils/dist/index.cjs - /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone-31/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint-plugin-tailwindcss/lib/util/customConfig.js - /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone-31/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint-plugin-tailwindcss/lib/util/tailwindAPI.js - /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone-31/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint-plugin-tailwindcss/lib/rules/classnames-order.js - /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone-31/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint-plugin-tailwindcss/lib/index.js Occurred while linting /home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone-31/src/base/common/downloadUtil.ts at Module._resolveFilename (node:internal/modules/cjs/loader:1410:15) at defaultResolveImpl (node:internal/modules/cjs/loader:1051:19) at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1056:22) at Module._load (node:internal/modules/cjs/loader:1219:37) at TracingChannel.traceSync (node:diagnostics_channel:322:14) at wrapModuleLoad (node:internal/modules/cjs/loader:238:24) at Module.require (node:internal/modules/cjs/loader:1493:12) at require (node:internal/modules/helpers:152:16) at TailwindUtils.loadConfigV3 (/home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone-31/node_modules/.pnpm/[email protected][email protected]/node_modules/tailwind-api-utils/dist/index.cjs:429:31) at getTailwindConfig (/home/c_byrne/projects/comfyui-frontend-testing/ComfyUI_frontend-clone-31/node_modules/.pnpm/[email protected][email protected]/node_modules/eslint-plugin-tailwindcss/lib/util/tailwindAPI.js:14:11)  ELIFECYCLE  Command failed with exit code 2. ```
1 parent b3da6cf commit efed934

File tree

4 files changed

+8
-57
lines changed

4 files changed

+8
-57
lines changed

eslint.config.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import { createTypeScriptImportResolver } from 'eslint-import-resolver-typescrip
55
import { importX } from 'eslint-plugin-import-x'
66
import eslintPluginPrettierRecommended from 'eslint-plugin-prettier/recommended'
77
import storybook from 'eslint-plugin-storybook'
8-
import tailwind from 'eslint-plugin-tailwindcss'
98
import unusedImports from 'eslint-plugin-unused-imports'
109
import pluginVue from 'eslint-plugin-vue'
1110
import { defineConfig } from 'eslint/config'
@@ -34,11 +33,7 @@ const settings = {
3433
],
3534
noWarnOnMultipleProjects: true
3635
})
37-
],
38-
tailwindcss: {
39-
config: `${import.meta.dirname}/packages/design-system/src/css/style.css`,
40-
functions: ['cn', 'clsx', 'tw']
41-
}
36+
]
4237
} as const
4338

4439
const commonParserOptions = {
@@ -97,7 +92,6 @@ export default defineConfig([
9792
// Difference in typecheck on CI vs Local
9893
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
9994
// @ts-ignore Bad types in the plugin
100-
tailwind.configs['flat/recommended'],
10195
pluginVue.configs['flat/recommended'],
10296
eslintPluginPrettierRecommended,
10397
storybook.configs['flat/recommended'],
@@ -129,7 +123,6 @@ export default defineConfig([
129123
'import-x/no-relative-packages': 'error',
130124
'unused-imports/no-unused-imports': 'error',
131125
'no-console': ['error', { allow: ['warn', 'error'] }],
132-
'tailwindcss/no-custom-classname': 'off', // TODO: fix
133126
'vue/no-v-html': 'off',
134127
// Enforce dark-theme: instead of dark: prefix
135128
'vue/no-restricted-class': ['error', '/^dark:/'],

package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
"@storybook/vue3-vite": "catalog:",
6262
"@tailwindcss/vite": "catalog:",
6363
"@trivago/prettier-plugin-sort-imports": "catalog:",
64-
"@types/eslint-plugin-tailwindcss": "catalog:",
6564
"@types/fs-extra": "catalog:",
6665
"@types/jsdom": "catalog:",
6766
"@types/node": "catalog:",
@@ -78,7 +77,6 @@
7877
"eslint-plugin-import-x": "catalog:",
7978
"eslint-plugin-prettier": "catalog:",
8079
"eslint-plugin-storybook": "catalog:",
81-
"eslint-plugin-tailwindcss": "catalog:",
8280
"eslint-plugin-unused-imports": "catalog:",
8381
"eslint-plugin-vue": "catalog:",
8482
"fs-extra": "^11.2.0",

pnpm-lock.yaml

Lines changed: 6 additions & 44 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pnpm-workspace.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ catalog:
3030
'@storybook/vue3-vite': ^9.1.1
3131
'@tailwindcss/vite': ^4.1.12
3232
'@trivago/prettier-plugin-sort-imports': ^5.2.0
33-
'@types/eslint-plugin-tailwindcss': ^3.17.0
3433
'@types/fs-extra': ^11.0.4
3534
'@types/jsdom': ^21.1.7
3635
'@types/node': ^20.14.8
@@ -52,7 +51,6 @@ catalog:
5251
eslint-plugin-import-x: ^4.16.1
5352
eslint-plugin-prettier: ^5.5.4
5453
eslint-plugin-storybook: ^9.1.6
55-
eslint-plugin-tailwindcss: 4.0.0-beta.0
5654
eslint-plugin-unused-imports: ^4.2.0
5755
eslint-plugin-vue: ^10.4.0
5856
firebase: ^11.6.0
@@ -64,6 +62,7 @@ catalog:
6462
knip: ^5.62.0
6563
lint-staged: ^15.2.7
6664
markdown-table: ^3.0.4
65+
mixpanel-browser: ^2.71.0
6766
nx: 21.4.1
6867
picocolors: ^1.1.1
6968
pinia: ^2.1.7
@@ -99,7 +98,6 @@ catalog:
9998
zod: ^3.23.8
10099
zod-to-json-schema: ^3.24.1
101100
zod-validation-error: ^3.3.0
102-
mixpanel-browser: ^2.71.0
103101

104102
cleanupUnusedCatalogs: true
105103

0 commit comments

Comments
 (0)