Skip to content

Commit f6203e9

Browse files
committed
fix: code review
1 parent d502f03 commit f6203e9

File tree

3 files changed

+16
-6
lines changed

3 files changed

+16
-6
lines changed

src/locales/en/main.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2357,6 +2357,8 @@
23572357
"actions": {
23582358
"inspect": "Inspect asset",
23592359
"more": "More options",
2360+
"zoom": "Zoom in",
2361+
"moreOptions": "More options",
23602362
"seeMoreOutputs": "See more outputs",
23612363
"addToWorkflow": "Add to current workflow",
23622364
"download": "Download",

src/platform/assets/components/MediaAssetCard.vue

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
v-else-if="asset && adaptedAsset"
3131
:asset="adaptedAsset"
3232
:context="{ type: assetType }"
33-
class="absolute top-0 left-0 h-full w-full"
33+
class="absolute inset-0"
3434
@view="handleZoomClick"
3535
@download="actions.downloadAsset()"
3636
@video-playing-state-changed="isVideoPlaying = $event"
@@ -44,18 +44,26 @@
4444
class="absolute top-2 left-2 flex flex-wrap justify-start gap-2"
4545
>
4646
<IconGroup>
47-
<Button size="icon" @click.stop="handleZoomClick">
47+
<Button
48+
size="icon"
49+
:aria-label="$t('mediaAsset.actions.zoom')"
50+
@click.stop="handleZoomClick"
51+
>
4852
<i class="icon-[lucide--zoom-in] size-4" />
4953
</Button>
50-
<Button size="icon" @click.stop="handleContextMenu">
54+
<Button
55+
size="icon"
56+
:aria-label="$t('mediaAsset.actions.moreOptions')"
57+
@click.stop="handleContextMenu"
58+
>
5159
<i class="icon-[lucide--ellipsis] size-4" />
5260
</Button>
5361
</IconGroup>
5462
</div>
5563
</div>
5664

5765
<!-- Bottom Area: Media Info -->
58-
<div class="flex-1 w-full h-full">
66+
<div class="flex-1">
5967
<!-- Loading State -->
6068
<div v-if="loading" class="flex justify-between items-start">
6169
<div class="flex flex-col gap-1">
@@ -79,7 +87,7 @@
7987
<!-- Title -->
8088
<MediaTitle :file-name="fileName" />
8189
<!-- Metadata -->
82-
<div class="flex gap-1.5 text-xs text-zinc-400">
90+
<div class="flex gap-1.5 text-xs text-muted-foreground">
8391
<span v-if="formattedDuration">{{ formattedDuration }}</span>
8492
<span v-if="metaInfo">{{ metaInfo }}</span>
8593
</div>

src/platform/assets/components/MediaTitle.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
</template>
99

1010
<script setup lang="ts">
11-
const { fileName } = defineProps<{
11+
defineProps<{
1212
fileName: string
1313
}>()
1414
</script>

0 commit comments

Comments
 (0)