Skip to content

Commit f9483c9

Browse files
committed
test: Update the help panel tests
1 parent a49ab79 commit f9483c9

File tree

2 files changed

+34
-11
lines changed

2 files changed

+34
-11
lines changed

browser_tests/tests/nodeHelp.spec.ts

Lines changed: 30 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,9 @@ test.describe('Node Help', () => {
5858
).toBeVisible()
5959

6060
// Verify that the help page is shown for the correct node
61-
const helpPage = comfyPage.page.locator('.sidebar-content-container')
61+
const helpPage = comfyPage.page.locator(
62+
'[data-testid="properties-panel"]'
63+
)
6264
await expect(helpPage).toContainText('KSampler')
6365
await expect(helpPage.locator('.node-help-content')).toBeVisible()
6466
})
@@ -170,7 +172,9 @@ test.describe('Node Help', () => {
170172
await helpButton.click()
171173

172174
// Verify loading spinner is shown
173-
const helpPage = comfyPage.page.locator('.sidebar-content-container')
175+
const helpPage = comfyPage.page.locator(
176+
'[data-testid="properties-panel"]'
177+
)
174178
await expect(helpPage.locator('.p-progressspinner')).toBeVisible()
175179

176180
// Wait for content to load
@@ -200,7 +204,9 @@ test.describe('Node Help', () => {
200204
await helpButton.click()
201205

202206
// Verify fallback content is shown (description, inputs, outputs)
203-
const helpPage = comfyPage.page.locator('.sidebar-content-container')
207+
const helpPage = comfyPage.page.locator(
208+
'[data-testid="properties-panel"]'
209+
)
204210
await expect(helpPage).toContainText('Description')
205211
await expect(helpPage).toContainText('Inputs')
206212
await expect(helpPage).toContainText('Outputs')
@@ -233,7 +239,9 @@ test.describe('Node Help', () => {
233239
)
234240
await helpButton.click()
235241

236-
const helpPage = comfyPage.page.locator('.sidebar-content-container')
242+
const helpPage = comfyPage.page.locator(
243+
'[data-testid="properties-panel"]'
244+
)
237245
await expect(helpPage).toContainText('KSampler Documentation')
238246

239247
// Check that relative image paths are prefixed correctly
@@ -281,7 +289,9 @@ test.describe('Node Help', () => {
281289
)
282290
await helpButton.click()
283291

284-
const helpPage = comfyPage.page.locator('.sidebar-content-container')
292+
const helpPage = comfyPage.page.locator(
293+
'[data-testid="properties-panel"]'
294+
)
285295

286296
// Check relative video paths are prefixed
287297
const relativeVideo = helpPage.locator('video[src*="demo.mp4"]')
@@ -354,7 +364,9 @@ This is documentation for a custom node.
354364
if (await helpButton.isVisible()) {
355365
await helpButton.click()
356366

357-
const helpPage = comfyPage.page.locator('.sidebar-content-container')
367+
const helpPage = comfyPage.page.locator(
368+
'[data-testid="properties-panel"]'
369+
)
358370
await expect(helpPage).toContainText('Custom Node Documentation')
359371

360372
// Check image path for custom nodes
@@ -394,7 +406,9 @@ This is documentation for a custom node.
394406
)
395407
await helpButton.click()
396408

397-
const helpPage = comfyPage.page.locator('.sidebar-content-container')
409+
const helpPage = comfyPage.page.locator(
410+
'[data-testid="properties-panel"]'
411+
)
398412

399413
// Dangerous elements should be removed
400414
await expect(helpPage.locator('script')).toHaveCount(0)
@@ -461,7 +475,9 @@ This is English documentation.
461475
)
462476
await helpButton.click()
463477

464-
const helpPage = comfyPage.page.locator('.sidebar-content-container')
478+
const helpPage = comfyPage.page.locator(
479+
'[data-testid="properties-panel"]'
480+
)
465481
await expect(helpPage).toContainText('KSamplerノード')
466482
await expect(helpPage).toContainText('これは日本語のドキュメントです')
467483

@@ -484,7 +500,9 @@ This is English documentation.
484500
)
485501
await helpButton.click()
486502

487-
const helpPage = comfyPage.page.locator('.sidebar-content-container')
503+
const helpPage = comfyPage.page.locator(
504+
'[data-testid="properties-panel"]'
505+
)
488506

489507
// Should show fallback content (node description)
490508
await expect(helpPage).toBeVisible()
@@ -528,7 +546,9 @@ This is English documentation.
528546
)
529547
await helpButton.click()
530548

531-
const helpPage = comfyPage.page.locator('.sidebar-content-container')
549+
const helpPage = comfyPage.page.locator(
550+
'[data-testid="properties-panel"]'
551+
)
532552
await expect(helpPage).toContainText('KSampler Help')
533553
await expect(helpPage).toContainText('This is KSampler documentation')
534554

src/components/rightSidePanel/RightSidePanel.vue

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,10 @@ watchEffect(() => {
9595
</script>
9696

9797
<template>
98-
<div class="flex size-full flex-col bg-interface-panel-surface">
98+
<div
99+
data-testid="properties-panel"
100+
class="flex size-full flex-col bg-interface-panel-surface"
101+
>
99102
<!-- Panel Header -->
100103
<section class="pt-1">
101104
<div class="flex items-center justify-between pl-4 pr-3">

0 commit comments

Comments
 (0)