Skip to content

Commit f9d0baa

Browse files
[test] fix flaky Vue group/frame test (minimap flakiness) (#5962)
Attempts to fix flakiness when groups are enabled on the minimap and the screenshot is taken too early, before the render completes. See [comment](#5942 (comment)) for more context. May or may not solve the flakiness. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5962-wait-for-frame-on-group-creation-test-2856d73d365081f6a059ebfc5a03857c) by [Unito](https://www.unito.io)
1 parent 9d95eb5 commit f9d0baa

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

browser_tests/tests/vueNodes/groups/groups.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,15 @@ const CREATE_GROUP_HOTKEY = 'Control+g'
88
test.describe('Vue Node Groups', () => {
99
test.beforeEach(async ({ comfyPage }) => {
1010
await comfyPage.setSetting('Comfy.VueNodes.Enabled', true)
11+
await comfyPage.setSetting('Comfy.Minimap.ShowGroups', true)
1112
await comfyPage.vueNodes.waitForNodes()
1213
})
1314

1415
test('should allow creating groups with hotkey', async ({ comfyPage }) => {
1516
await comfyPage.page.getByText('Load Checkpoint').click()
1617
await comfyPage.page.getByText('KSampler').click({ modifiers: ['Control'] })
1718
await comfyPage.page.keyboard.press(CREATE_GROUP_HOTKEY)
19+
await comfyPage.nextFrame()
1820
await expect(comfyPage.canvas).toHaveScreenshot(
1921
'vue-groups-create-group.png'
2022
)

0 commit comments

Comments
 (0)