Skip to content

Commit fd75702

Browse files
[ci] allow Claude review even when Playwright and Vitest checks have failed (#5882)
Currently the claude review action will be skipped if any tests have failed. This is not really necessary, it will be more efficient to allow claude to review while still waiting for tests. This accounts for scenario where there is an expected visual baseline change, but the PR author doesn't want to regenerate baselines until everything is approved and ready to merge (as generating right away before you know whether changes will be requested can be a hassle). ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5882-ci-allow-Claude-review-even-when-Playwright-and-Vitest-checks-have-failed-27f6d73d365081ccbcdaff7104edc2fd) by [Unito](https://www.unito.io)
1 parent 1efc223 commit fd75702

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

.github/workflows/claude-pr-review.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,9 @@ jobs:
2929
- name: Check if we should proceed
3030
id: check-status
3131
run: |
32-
# Get all check runs for this commit
33-
CHECK_RUNS=$(gh api repos/${{ github.repository }}/commits/${{ github.event.pull_request.head.sha }}/check-runs --jq '.check_runs[] | select(.name | test("lint-and-format|test|playwright-tests")) | {name, conclusion}')
34-
35-
# Check if any required checks failed
36-
if echo "$CHECK_RUNS" | grep -q '"conclusion": "failure"'; then
32+
CHECK_RUNS=$(gh api repos/${{ github.repository }}/commits/${{ github.event.pull_request.head.sha }}/check-runs --jq '.check_runs[] | select(.name | test("lint-and-format")) | {name, conclusion}')
33+
34+
if echo "$CHECK_RUNS" | grep -Eq '"conclusion": "(failure|cancelled|timed_out|action_required)"'; then
3735
echo "Some CI checks failed - skipping Claude review"
3836
echo "proceed=false" >> $GITHUB_OUTPUT
3937
else

0 commit comments

Comments
 (0)